You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Jie Yu <yu...@gmail.com> on 2014/04/23 21:41:47 UTC
Review Request 20627: Fixed compiler error (gcc-4.1.2) in state tests.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20627/
-----------------------------------------------------------
Review request for mesos, Benjamin Hindman, Dominic Hamon, and Vinod Kone.
Bugs: MESOS-1232
https://issues.apache.org/jira/browse/MESOS-1232
Repository: mesos-git
Description
-------
See summary.
Diffs
-----
src/tests/state_tests.cpp 56feb27
Diff: https://reviews.apache.org/r/20627/diff/
Testing
-------
make check
gcc-4.4
gcc-4.1.2
Thanks,
Jie Yu
Re: Review Request 20627: Fixed compiler error (gcc-4.1.2) in state tests.
Posted by Dominic Hamon <dh...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20627/#review41200
-----------------------------------------------------------
Ship it!
Ship It!
- Dominic Hamon
On April 23, 2014, 12:49 p.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20627/
> -----------------------------------------------------------
>
> (Updated April 23, 2014, 12:49 p.m.)
>
>
> Review request for mesos, Benjamin Hindman, Dominic Hamon, and Vinod Kone.
>
>
> Bugs: MESOS-1232
> https://issues.apache.org/jira/browse/MESOS-1232
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/tests/state_tests.cpp 56feb27
>
> Diff: https://reviews.apache.org/r/20627/diff/
>
>
> Testing
> -------
>
> make check
>
> gcc-4.4
> gcc-4.1.2
>
>
> Thanks,
>
> Jie Yu
>
>
Re: Review Request 20627: Fixed compiler error (gcc-4.1.2) in state tests.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20627/
-----------------------------------------------------------
(Updated April 23, 2014, 7:49 p.m.)
Review request for mesos, Benjamin Hindman, Dominic Hamon, and Vinod Kone.
Changes
-------
Review comments.
Bugs: MESOS-1232
https://issues.apache.org/jira/browse/MESOS-1232
Repository: mesos-git
Description
-------
See summary.
Diffs (updated)
-----
src/tests/state_tests.cpp 56feb27
Diff: https://reviews.apache.org/r/20627/diff/
Testing
-------
make check
gcc-4.4
gcc-4.1.2
Thanks,
Jie Yu
Re: Review Request 20627: Fixed compiler error (gcc-4.1.2) in state tests.
Posted by Jie Yu <yu...@gmail.com>.
> On April 23, 2014, 7:44 p.m., Dominic Hamon wrote:
> > src/tests/state_tests.cpp, line 61
> > <https://reviews.apache.org/r/20627/diff/1/?file=566081#file566081line61>
> >
> > using namespace mesos::internal::log ?
> >
> > then the 'Initialize' type won't be ambiguous to readers.
I liked that! Fixed it.
- Jie
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20627/#review41196
-----------------------------------------------------------
On April 23, 2014, 7:41 p.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20627/
> -----------------------------------------------------------
>
> (Updated April 23, 2014, 7:41 p.m.)
>
>
> Review request for mesos, Benjamin Hindman, Dominic Hamon, and Vinod Kone.
>
>
> Bugs: MESOS-1232
> https://issues.apache.org/jira/browse/MESOS-1232
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/tests/state_tests.cpp 56feb27
>
> Diff: https://reviews.apache.org/r/20627/diff/
>
>
> Testing
> -------
>
> make check
>
> gcc-4.4
> gcc-4.1.2
>
>
> Thanks,
>
> Jie Yu
>
>
Re: Review Request 20627: Fixed compiler error (gcc-4.1.2) in state tests.
Posted by Dominic Hamon <dh...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20627/#review41196
-----------------------------------------------------------
src/tests/state_tests.cpp
<https://reviews.apache.org/r/20627/#comment74617>
using namespace mesos::internal::log ?
then the 'Initialize' type won't be ambiguous to readers.
- Dominic Hamon
On April 23, 2014, 12:41 p.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20627/
> -----------------------------------------------------------
>
> (Updated April 23, 2014, 12:41 p.m.)
>
>
> Review request for mesos, Benjamin Hindman, Dominic Hamon, and Vinod Kone.
>
>
> Bugs: MESOS-1232
> https://issues.apache.org/jira/browse/MESOS-1232
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/tests/state_tests.cpp 56feb27
>
> Diff: https://reviews.apache.org/r/20627/diff/
>
>
> Testing
> -------
>
> make check
>
> gcc-4.4
> gcc-4.1.2
>
>
> Thanks,
>
> Jie Yu
>
>
Re: Review Request 20627: Fixed compiler error (gcc-4.1.2) in state tests.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20627/#review41197
-----------------------------------------------------------
Ship it!
Ship It!
- Vinod Kone
On April 23, 2014, 7:41 p.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20627/
> -----------------------------------------------------------
>
> (Updated April 23, 2014, 7:41 p.m.)
>
>
> Review request for mesos, Benjamin Hindman, Dominic Hamon, and Vinod Kone.
>
>
> Bugs: MESOS-1232
> https://issues.apache.org/jira/browse/MESOS-1232
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/tests/state_tests.cpp 56feb27
>
> Diff: https://reviews.apache.org/r/20627/diff/
>
>
> Testing
> -------
>
> make check
>
> gcc-4.4
> gcc-4.1.2
>
>
> Thanks,
>
> Jie Yu
>
>