You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by "Andrea Del Bene (JIRA)" <ji...@apache.org> on 2012/08/16 21:21:38 UTC
[jira] [Commented] (WICKET-4715) WebApplication doesn't recognize
if an incoming request is multipart.
[ https://issues.apache.org/jira/browse/WICKET-4715?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13436247#comment-13436247 ]
Andrea Del Bene commented on WICKET-4715:
-----------------------------------------
I've seen how Commons FileUpload library solved the problem of determining if a HttpServletRequest is multipart and is quite similar to what I've done, so now I'm confident with my code :).
I've improved my patch adding a test case for multipart requests.
> WebApplication doesn't recognize if an incoming request is multipart.
> ---------------------------------------------------------------------
>
> Key: WICKET-4715
> URL: https://issues.apache.org/jira/browse/WICKET-4715
> Project: Wicket
> Issue Type: Bug
> Affects Versions: 1.5.7, 6.0.0-beta3
> Reporter: Andrea Del Bene
> Attachments: WICKET-4715.patch
>
>
> Thanks to the mail at http://apache-wicket.1842946.n4.nabble.com/Read-POST-based-request-from-external-site-td4651269.html we have spotted a problem with method newWebRequest of class WebApplication.
> It seems that this method doesn't test if the original request is multipart and doing so post parameters go lost.
> We should create a MultipartServletWebRequestImpl when such a type of request is being served. I attach a possible patch but I'm not 100% about two things:
> - which is the best way to determinate if a HttpServletRequest is multipart?
> - in order to build a MultipartServletWebRequestImpl we need to provide a string identifier for the upload. How can we generate it (in my patch it's a constant value)?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira