[GitHub] [flink] xintongsong commented on a change in pull request #9801: [FLINK-13983][runtime] Launch task executor with new memory calculation logics

[GitBox <gi...@apache.org>]

xintongsong commented on a change in pull request #9801: [FLINK-13983][runtime] Launch task executor with new memory calculation logics
URL: https://github.com/apache/flink/pull/9801#discussion_r329349401
 
 

 ##########
 File path: flink-runtime/src/main/java/org/apache/flink/runtime/clusterframework/TaskExecutorResourceUtils.java
 ##########
 @@ -125,7 +125,7 @@ public static String generateDynamicConfigsStr(final TaskExecutorResourceSpec ta
 	private static String assembleDynamicConfigsStr(final Map<String, String> configs) {
 		final StringBuffer sb = new StringBuffer();
 		for (Map.Entry<String, String> entry : configs.entrySet()) {
-			sb.append("-D").append(entry.getKey()).append("=").append(entry.getValue()).append(" ");
+			sb.append("-D ").append(entry.getKey()).append("=").append(entry.getValue()).append(" ");
 
 Review comment:
   Dynamic configs are exiting mechanism for passing configs into flink overwriting configs in flink-conf.yaml. The correct format requires a space between '-D' and the following key-value part. This change is just a fix of previous wrong format.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services