You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@bigtop.apache.org by etcola <gi...@git.apache.org> on 2015/12/13 13:29:37 UTC
[GitHub] bigtop pull request: Getting vagrant work on Windows.
GitHub user etcola opened a pull request:
https://github.com/apache/bigtop/pull/65
Getting vagrant work on Windows.
Force line endings to be LR for *.sh scripts after git checkout in windows, so that running "vagrant up" under bigtop-deploy/vm/vagrant-puppet-vm can work as expected.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/etcola/bigtop master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/bigtop/pull/65.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #65
----
commit de95a7804917889b30d4f2fcda7fa045f089b340
Author: Eric Zhu <et...@gmail.com>
Date: 2015-12-13T12:16:19Z
Getting vagrant work on Windows.
Force line endings to be LR for *.sh scripts.
commit 8d0f8102bb90fbc7c3a95ef4e8269ed8675ff165
Author: Eric Zhu <et...@gmail.com>
Date: 2015-12-13T12:19:59Z
Merge pull request #1 from etcola/hotfix-VagrantWindows-shellLineEndingsSyncError
Getting vagrant work on Windows.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] bigtop pull request: Getting vagrant work on Windows.
Posted by etcola <gi...@git.apache.org>.
Github user etcola commented on the pull request:
https://github.com/apache/bigtop/pull/65#issuecomment-164327311
Maybe I should update the README.md instead to notify windows user in the first place? Shed me some light on this please.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] bigtop pull request: Getting vagrant work on Windows.
Posted by etcola <gi...@git.apache.org>.
Github user etcola commented on the pull request:
https://github.com/apache/bigtop/pull/65#issuecomment-164327128
Yeah my bad. Typo. It should be LF. Sorry for the messed up.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] bigtop pull request: Getting vagrant work on Windows.
Posted by etcola <gi...@git.apache.org>.
Github user etcola closed the pull request at:
https://github.com/apache/bigtop/pull/65
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] bigtop pull request: Getting vagrant work on Windows.
Posted by oflebbe <gi...@git.apache.org>.
Github user oflebbe commented on the pull request:
https://github.com/apache/bigtop/pull/65#issuecomment-164267994
And BTW what is "LR" ? A typo?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] bigtop pull request: Getting vagrant work on Windows.
Posted by oflebbe <gi...@git.apache.org>.
Github user oflebbe commented on the pull request:
https://github.com/apache/bigtop/pull/65#issuecomment-166739377
If you like to document ... the wiki is an excellent place for it.
Olaf
> Am 14.12.2015 um 03:49 schrieb Eric Zhu <no...@github.com>:
>
> Maybe I should update the README.md instead to notify windows user in the first place? Shed me some light on this please.
>
> —
> Reply to this email directly or view it on GitHub.
>
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---