You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2021/08/05 03:17:02 UTC
[GitHub] [apisix-dashboard] Baoyuantop opened a new issue #2035: lint-staged caused many additional changes
Baoyuantop opened a new issue #2035:
URL: https://github.com/apache/apisix-dashboard/issues/2035
## Issue description
When committing some code changes in the `web`, `lint-staged` started and made many additional changes (regarding the code format), which caused a lot of trouble for the review code.
I noticed that this feature was added 15 days ago #1957, and the corresponding code format may be missing before then?
## Expected behavior
In a PR, `lint-staged` does not change the extra code
## How to Reproduce
Make code changes on the web, and then commit the code.
## Screenshots
https://github.com/apache/apisix-dashboard/pull/2034/files#diff-88ff6b2eb91bde63ed36ce0bbe0bc5c2f3bd70977e509e81cafd2e56b6da44dbR17
## Environment
* apisix version (cmd: `apisix version`):
* OS (cmd: `uname -a`):
* OpenResty / Nginx version (cmd: `nginx -V` or `openresty -V`):
* etcd version, if have (cmd: run `curl http://127.0.0.1:9090/v1/server_info` to get the info from server-info API):
* apisix-dashboard version, if have:
* Browser version, if have:
## Additional context
I tried lint the whole project, and the result was a lot of changes:
When commit these changes, eslint prompts many errors:
Some of them need to modify the previously non-standard code, and some need to adjust the rules of eslint to adapt to the project.
Any good suggestions？
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan commented on issue #2035: lint-staged caused many additional changes
Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on issue #2035:
URL: https://github.com/apache/apisix-dashboard/issues/2035#issuecomment-893538905
ok
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] Baoyuantop commented on issue #2035: lint-staged caused many additional changes
Posted by GitBox <gi...@apache.org>.
Baoyuantop commented on issue #2035:
URL: https://github.com/apache/apisix-dashboard/issues/2035#issuecomment-893523567
I will try to fix these `eslint` errors and then submit these changes to a PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan commented on issue #2035: lint-staged caused many additional changes
Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on issue #2035:
URL: https://github.com/apache/apisix-dashboard/issues/2035#issuecomment-893183835
cc @iamayushdas to take a look
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] liuxiran closed issue #2035: lint-staged caused many additional changes
Posted by GitBox <gi...@apache.org>.
liuxiran closed issue #2035:
URL: https://github.com/apache/apisix-dashboard/issues/2035
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan commented on issue #2035: lint-staged caused many additional changes
Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on issue #2035:
URL: https://github.com/apache/apisix-dashboard/issues/2035#issuecomment-893183835
cc @iamayushdas to take a look
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org