You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "sebastianliebscher (via GitHub)" <gi...@apache.org> on 2023/06/21 15:12:37 UTC
[GitHub] [superset] sebastianliebscher opened a new pull request, #24473: fix(build): reduce the number of pushed tags
sebastianliebscher opened a new pull request, #24473:
URL: https://github.com/apache/superset/pull/24473
### SUMMARY
On Docker Hub Superset has published over 20k tags so far with most of them not being a release tag. This is a huge amount of unnecessary tags hosted Docker Hub.
Currently, there are three scenarios of pushing tags:
- on PR by Superset committer
```
Rolling with tags:
- apache/superset:add536543b3d96774fbdebdc6c36ae286a3a329e
- apache/superset:elizabeth-fix-examples-load
- apache/superset:pr-24410
```
example: https://github.com/apache/superset/actions/runs/5282886796/jobs/9558388071
- on commit to master
```
Rolling with tags:
- apache/superset:d5f88c18f61cc919a8bdecfa92251d0d4d35abac
- apache/superset:master
- apache/superset:latest
```
example: https://github.com/apache/superset/actions/runs/5333985229/jobs/9665184088
- on release
```
Rolling with tags:
- apache/superset:2817aebd69dc7d199ec45d973a2079f35e5658b6
- apache/superset:2.1.0
- apache/superset:2.1.0
```
example: https://github.com/apache/superset/actions/runs/4613689991/jobs/8155936157
The tags `master` and `latest` are identical. I think `master` can be removed as common practice is to use `latest` tag. Also, the image SHA tags don't seem to be used by any other CI job.
I recommend reducing the pushed image tags to:
- on PR by Superset committer
```
Rolling with tags:
- apache/superset:pr-24410
```
- on commit to master
```
Rolling with tags:
- apache/superset:latest
```
- on release
```
Rolling with tags:
- apache/superset:2.1.0
```
The ephemeral env workflow shouldn't be affected by this, as it uses the "pr-(number)" image
example: https://github.com/apache/superset/actions/runs/5293709377/jobs/9582193999
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] john-bodley commented on pull request #24473: fix(build): reduce the number of pushed tags
Posted by "john-bodley (via GitHub)" <gi...@apache.org>.
john-bodley commented on PR #24473:
URL: https://github.com/apache/superset/pull/24473#issuecomment-1646311319
@craig-rueda would you mind taking a look at this given you're likely the one who's most well versed with Docker?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] sebastianliebscher closed pull request #24473: fix(build): reduce the number of pushed tags
Posted by "sebastianliebscher (via GitHub)" <gi...@apache.org>.
sebastianliebscher closed pull request #24473: fix(build): reduce the number of pushed tags
URL: https://github.com/apache/superset/pull/24473
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] craig-rueda commented on pull request #24473: fix(build): reduce the number of pushed tags
Posted by "craig-rueda (via GitHub)" <gi...@apache.org>.
craig-rueda commented on PR #24473:
URL: https://github.com/apache/superset/pull/24473#issuecomment-1646441288
This will likely break ephemerals. They currently update on each push using the current SHA.
Is there a limit with DockerHub we're running up against which prompted this fix?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org