You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Bhuvan Arumugam <bh...@apple.com> on 2015/11/02 17:23:54 UTC

Review Request 39862: Add documentation for newer metrics

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39862/
-----------------------------------------------------------

Review request for mesos, Adam B and Bernd Mathiske.


Bugs: MESOS-3569
    https://issues.apache.org/jira/browse/MESOS-3569


Repository: mesos


Description
-------

- Add notes for newer metrics
  - Fix slave port number


Diffs
-----

  docs/monitoring.md 22e2fa8e188b8e367fb67f67ce4b9f37ec285841 

Diff: https://reviews.apache.org/r/39862/diff/


Testing
-------

make check


Thanks,

Bhuvan Arumugam

Re: Review Request 39862: Add documentation for newer metrics

Posted by haosdent huang <ha...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39862/#review104729
-----------------------------------------------------------



docs/monitoring.md (line 900)
<https://reviews.apache.org/r/39862/#comment162981>

    Could you explain why change to 4891 here? Because slave default port is 5051


- haosdent huang


On Nov. 2, 2015, 4:23 p.m., Bhuvan Arumugam wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39862/
> -----------------------------------------------------------
> 
> (Updated Nov. 2, 2015, 4:23 p.m.)
> 
> 
> Review request for mesos, Adam B and Bernd Mathiske.
> 
> 
> Bugs: MESOS-3569
>     https://issues.apache.org/jira/browse/MESOS-3569
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> - Add notes for newer metrics
>   - Fix slave port number
> 
> 
> Diffs
> -----
> 
>   docs/monitoring.md 22e2fa8e188b8e367fb67f67ce4b9f37ec285841 
> 
> Diff: https://reviews.apache.org/r/39862/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Bhuvan Arumugam
> 
>

Re: Review Request 39862: Add documentation for newer metrics

Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39862/#review104745
-----------------------------------------------------------

Ship it!


thanks for updating this!


docs/monitoring.md (line 684)
<https://reviews.apache.org/r/39862/#comment162991>

    these are not just failover related slave removals but slaves removed during steady state when they fail health checks.
    
    "Number of slaves removed due to failed health checks"



docs/monitoring.md (line 900)
<https://reviews.apache.org/r/39862/#comment162992>

    s/4891/5051/


- Vinod Kone


On Nov. 2, 2015, 4:23 p.m., Bhuvan Arumugam wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39862/
> -----------------------------------------------------------
> 
> (Updated Nov. 2, 2015, 4:23 p.m.)
> 
> 
> Review request for mesos, Adam B and Bernd Mathiske.
> 
> 
> Bugs: MESOS-3569
>     https://issues.apache.org/jira/browse/MESOS-3569
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> - Add notes for newer metrics
>   - Fix slave port number
> 
> 
> Diffs
> -----
> 
>   docs/monitoring.md 22e2fa8e188b8e367fb67f67ce4b9f37ec285841 
> 
> Diff: https://reviews.apache.org/r/39862/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Bhuvan Arumugam
> 
>

Re: Review Request 39862: Add documentation for newer metrics

Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39862/#review104734
-----------------------------------------------------------


Patch looks great!

Reviews applied: [39862]

All tests passed.

- Mesos ReviewBot


On Nov. 2, 2015, 4:23 p.m., Bhuvan Arumugam wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39862/
> -----------------------------------------------------------
> 
> (Updated Nov. 2, 2015, 4:23 p.m.)
> 
> 
> Review request for mesos, Adam B and Bernd Mathiske.
> 
> 
> Bugs: MESOS-3569
>     https://issues.apache.org/jira/browse/MESOS-3569
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> - Add notes for newer metrics
>   - Fix slave port number
> 
> 
> Diffs
> -----
> 
>   docs/monitoring.md 22e2fa8e188b8e367fb67f67ce4b9f37ec285841 
> 
> Diff: https://reviews.apache.org/r/39862/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Bhuvan Arumugam
> 
>

Re: Review Request 39862: Add documentation for newer metrics

Posted by Bhuvan Arumugam <bh...@apple.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39862/
-----------------------------------------------------------

(Updated Nov. 2, 2015, 6:18 p.m.)


Review request for mesos, Adam B and Bernd Mathiske.


Bugs: MESOS-3569
    https://issues.apache.org/jira/browse/MESOS-3569


Repository: mesos


Description
-------

- Add notes for newer metrics
  - Fix slave port number


Diffs (updated)
-----

  docs/monitoring.md 22e2fa8e188b8e367fb67f67ce4b9f37ec285841 

Diff: https://reviews.apache.org/r/39862/diff/


Testing
-------

make check


Thanks,

Bhuvan Arumugam