[GitHub] [skywalking-python] kezhenxu94 commented on a diff in pull request #297: [wip]Build multi-architecture Docker images for Python agent

["kezhenxu94 (via GitHub)" <gi...@apache.org>]

kezhenxu94 commented on code in PR #297:
URL: https://github.com/apache/skywalking-python/pull/297#discussion_r1140898600


##########
docker/Makefile:
##########
@@ -37,8 +37,10 @@ build: $(TARGETS)
 push: $(PUSH_TARGETS)
 
 $(TARGETS):
+docker buildx create --use --driver docker-container --name skywalking_python_main

Review Comment:
   ```suggestion
   	docker buildx create --use --driver docker-container --name skywalking_python_main
   ```



##########
docker/Makefile:
##########
@@ -37,8 +37,10 @@ build: $(TARGETS)
 push: $(PUSH_TARGETS)
 
 $(TARGETS):
+docker buildx create --use --driver docker-container --name skywalking_python_main
 	for p in $(P); do \
-		$(D) build $(SW_BUILD_ARGS) \
+		$(D) buildx build $(SW_BUILD_ARGS) \
+				--platform linux/amd64,linux/arm64 \

Review Comment:
   For `buildx`, we need `--load` or `--push` in the command.
   
   > Build result will only remain in the build cache. To push result image into registry use --push or to load image into docker use --load.
   
   So we have to modify the Make target a bit, an example is here https://github.com/apache/skywalking-java/blob/d357bdef7a3f1f9e78e6a8e29b372f3270e1acc2/Makefile#L45-L63



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org