You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by GitBox <gi...@apache.org> on 2022/05/10 09:46:42 UTC
[GitHub] [nifi] krisztina-zsihovszki opened a new pull request, #6028: NIFI-9992 Improve configuration of InfluxDB processors, fix IT
krisztina-zsihovszki opened a new pull request, #6028:
URL: https://github.com/apache/nifi/pull/6028
<!-- Licensed to the Apache Software Foundation (ASF) under one or more -->
<!-- contributor license agreements. See the NOTICE file distributed with -->
<!-- this work for additional information regarding copyright ownership. -->
<!-- The ASF licenses this file to You under the Apache License, Version 2.0 -->
<!-- (the "License"); you may not use this file except in compliance with -->
<!-- the License. You may obtain a copy of the License at -->
<!-- http://www.apache.org/licenses/LICENSE-2.0 -->
<!-- Unless required by applicable law or agreed to in writing, software -->
<!-- distributed under the License is distributed on an "AS IS" BASIS, -->
<!-- WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. -->
<!-- See the License for the specific language governing permissions and -->
<!-- limitations under the License. -->
# Summary
[NIFI-9992](https://issues.apache.org/jira/browse/NIFI-9992)
# Tracking
Please complete the following tracking steps prior to pull request creation.
### Issue Tracking
- [X] [Apache NiFi Jira](https://issues.apache.org/jira/browse/NIFI) issue created
### Pull Request Tracking
- [X] Pull Request title starts with Apache NiFi Jira issue number, such as `NIFI-00000`
- [X] Pull Request commit message starts with Apache NiFi Jira issue number, as such `NIFI-00000`
### Pull Request Formatting
- [X] Pull Request based on current revision of the `main` branch
- [X] Pull Request refers to a feature branch with one commit containing changes
# Verification
Please indicate the verification steps performed prior to pull request creation.
### Build
- [ ] Build completed using `mvn clean install -P contrib-check`
- [X] JDK 8
- [ ] JDK 11
- [ ] JDK 17
### Licensing
- [ ] New dependencies are compatible with the [Apache License 2.0](https://apache.org/licenses/LICENSE-2.0) according to the [License Policy](https://www.apache.org/legal/resolved.html)
- [ ] New dependencies are documented in applicable `LICENSE` and `NOTICE` files
### Documentation
- [ ] Documentation formatting appears as expected in rendered files
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] krisztina-zsihovszki closed pull request #6028: NIFI-9992 Improve configuration of InfluxDB processors, fix IT
Posted by GitBox <gi...@apache.org>.
krisztina-zsihovszki closed pull request #6028: NIFI-9992 Improve configuration of InfluxDB processors, fix IT
URL: https://github.com/apache/nifi/pull/6028
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] MikeThomsen commented on pull request #6028: NIFI-9992 Improve configuration of InfluxDB processors, fix IT
Posted by GitBox <gi...@apache.org>.
MikeThomsen commented on PR #6028:
URL: https://github.com/apache/nifi/pull/6028#issuecomment-1122472660
FYSA, we are not planning to maintain our own capabilities here anymore since InfluxDB is doing that. This is their repo: https://github.com/influxdata/nifi-influxdb-bundle
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] exceptionfactory commented on a diff in pull request #6028: NIFI-9992 Improve configuration of InfluxDB processors, fix IT
Posted by GitBox <gi...@apache.org>.
exceptionfactory commented on code in PR #6028:
URL: https://github.com/apache/nifi/pull/6028#discussion_r905051766
##########
nifi-nar-bundles/nifi-influxdb-bundle/nifi-influxdb-processors/src/main/java/org/apache/nifi/processors/influxdb/AbstractInfluxDBProcessor.java:
##########
@@ -56,8 +56,8 @@ public abstract class AbstractInfluxDBProcessor extends AbstractProcessor {
.build();
public static final PropertyDescriptor INFLUX_DB_CONNECTION_TIMEOUT = new PropertyDescriptor.Builder()
- .name("InfluxDB Max Connection Time Out (seconds)")
- .displayName("InfluxDB Max Connection Time Out (seconds)")
+ .name("InfluxDB Max Connection Time Out")
Review Comment:
The property `name` cannot be changed as it would result in breaking existing configurations during an upgrade. Changing the `displayName` is acceptable.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] krisztina-zsihovszki commented on pull request #6028: NIFI-9992 Improve configuration of InfluxDB processors, fix IT
Posted by GitBox <gi...@apache.org>.
krisztina-zsihovszki commented on PR #6028:
URL: https://github.com/apache/nifi/pull/6028#issuecomment-1168343812
InfluxDB changes will be maintened in: https://github.com/influxdata/nifi-influxdb-bundle
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org