You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@inlong.apache.org by "bluewang (via GitHub)" <gi...@apache.org> on 2023/10/27 09:26:46 UTC
[PR] [INLONG-9140][Dashboard] Data synchronization sink supports table creation [inlong]
bluewang opened a new pull request, #9141:
URL: https://github.com/apache/inlong/pull/9141
…ation
### Prepare a Pull Request
*(Change the title refer to the following example)*
- Title Example: [INLONG-XYZ][Component] Title of the pull request
*(The following *XYZ* should be replaced by the actual [GitHub Issue](https://github.com/apache/inlong/issues) number)*
- Fixes https://github.com/apache/inlong/issues/9140
### Motivation
*Explain here the context, and why you're making that change. What is the problem you're trying to solve?*
### Modifications
*Describe the modifications you've done.*
### Verifying this change
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [INLONG-9140][Dashboard] Data synchronization sink supports table creation [inlong]
Posted by "EMsnap (via GitHub)" <gi...@apache.org>.
EMsnap merged PR #9141:
URL: https://github.com/apache/inlong/pull/9141
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [INLONG-9140][Dashboard] Data synchronization sink supports table creation [inlong]
Posted by "leezng (via GitHub)" <gi...@apache.org>.
leezng commented on code in PR #9141:
URL: https://github.com/apache/inlong/pull/9141#discussion_r1375592861
##########
inlong-dashboard/src/core/stores/index.ts:
##########
@@ -38,6 +39,7 @@ const state: State = {
userId: 0,
roles: [],
tenant: '',
+ syncTableData: null,
Review Comment:
It is recommended not to put syncTableData in the store. I think it is not global.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [INLONG-9140][Dashboard] Data synchronization sink supports table creation [inlong]
Posted by "EMsnap (via GitHub)" <gi...@apache.org>.
EMsnap commented on PR #9141:
URL: https://github.com/apache/inlong/pull/9141#issuecomment-1784365609
please update description
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [INLONG-9140][Dashboard] Data synchronization sink supports table creation [inlong]
Posted by "leezng (via GitHub)" <gi...@apache.org>.
leezng commented on code in PR #9141:
URL: https://github.com/apache/inlong/pull/9141#discussion_r1415150778
##########
inlong-dashboard/src/core/stores/index.ts:
##########
@@ -29,6 +29,7 @@ export interface State {
userId: number;
roles: string[];
tenant: string;
+ syncTableData: null | React.RefObject<any>;
Review Comment:
syncTableData can be removed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org