You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by tillrohrmann <gi...@git.apache.org> on 2017/08/24 15:06:31 UTC

[GitHub] flink pull request #4582: [FLINK-7504] Fence the ResourceManager

GitHub user tillrohrmann opened a pull request:

    https://github.com/apache/flink/pull/4582

    [FLINK-7504] Fence the ResourceManager

    ## What is the purpose of the change
    
    Properly fences the ResourceManager by letting it extend the FencedRpcEndpoint.
    Moreover, this PR introduces a ResourceManagerId which replaces the UUID as
    leader id/fencing token. This will give us more type safety when defining rpc
    interfaces.
    
    This PR is based on #4580 and #4578.
    
    ## Brief change log
    
    - Let `ResourceManager` extend from `FencedRpcEndpoint`
    - Introduce the `ResourceManagerId` which replaces the `ResourceManager's` leader id
    - Adapt the `ResourceManagerGateway` to not require explicitly sending the `ResourceManagerId` (this is implicitly done by the `FencedAkkaInvocationHandler`)
    - Change the `RetryingRegistration` to connect to `FencedRpcEndpoints`
    
    ## Verifying this change
    
    This change is already covered by existing tests, such as the `FencedRpcEndpointTest`.
    
    ## Does this pull request potentially affect one of the following parts:
    
      - Dependencies (does it add or upgrade a dependency): (no)
      - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
      - The serializers: (no)
      - The runtime per-record code paths (performance sensitive): (no)
      - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
    
    ## Documentation
    
      - Does this pull request introduce a new feature? (no)
      - If yes, how is the feature documented? (not applicable)
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/tillrohrmann/flink fenceResourceManager

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/4582.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #4582
    
----
commit ce34155df99ce819ab1317877f4c7c4fb71fd8d8
Author: Till Rohrmann <tr...@apache.org>
Date:   2017-08-24T13:29:47Z

    [FLINK-7501] Generalize RegisteredRpcConnection to support generic leader ids
    
    The RegisteredRpcConnection now supports generic leader ids/fencing tokens. This
    will allow to introduce component specific leader ids/fencing tokens.

commit 4aeab4f2f16cd6b0e45da4fe055064965909bd5e
Author: Till Rohrmann <tr...@apache.org>
Date:   2017-08-22T14:33:05Z

    [FLINK-7489] Remove startJobExecution and suspendExecution from JobMasterGateway
    
    The job lifecycle methods should not be exposed as RPCs. Therefore, this commit
    removes them from the JobMasterGateway definition.

commit 4dc1e264bcb77409a6266edabfc4a7ab487dad49
Author: Till Rohrmann <tr...@apache.org>
Date:   2017-08-23T15:08:55Z

    [FLINK-7078] [rpc] Introduce FencedRpcEndpoint
    
    Introduce FencedRpcEndpoint which requires all RPC messages to have a
    fencing token attached. Based on the received fencing token and the
    actual fencing token, the message will either be discarded if they are
    not equal or it will be processed. That way we are able to filter out
    old messages or messages which originate from a split brain situation

commit 24bdd1bc545eac40066bf32e6d984e817c8768f7
Author: Till Rohrmann <tr...@apache.org>
Date:   2017-08-24T13:11:00Z

    [FLINK-7504] Fence the ResourceManager
    
    Properly fences the ResourceManager by letting it extend the FencedRpcEndpoint.
    Moreover, this PR introduces a ResourceManagerId which replaces the UUID as
    leader id/fencing token. This will give us more type safety when defining rpc
    interfaces.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink pull request #4582: [FLINK-7504] Fence the ResourceManager

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/flink/pull/4582


---

[GitHub] flink issue #4582: [FLINK-7504] Fence the ResourceManager

Posted by tillrohrmann <gi...@git.apache.org>.
Github user tillrohrmann commented on the issue:

    https://github.com/apache/flink/pull/4582
  
    Travis passed. Merging this PR.


---