You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by "js8544 (via GitHub)" <gi...@apache.org> on 2023/06/01 13:42:18 UTC

[GitHub] [arrow] js8544 commented on pull request #35790: GH-35789: [C++] Remove check_overflow from CumulativeSumOptions

js8544 commented on PR #35790:
URL: https://github.com/apache/arrow/pull/35790#issuecomment-1572078655

   > > There are two variants of cumsum, `cumulative_sum` always wraps around on overflow and `cumulative_sum` always return `Status::Invalid` on overflow,
   > 
   > This does not seem to make sense to me, is there a typo?
   
   Sorry! It's a typo indeed. I meant `cumulative_sum_checked`.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org