You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@superset.apache.org by ma...@apache.org on 2018/03/26 16:44:39 UTC
[incubator-superset] branch master updated: CRUD hints around SQL
expressions (#4645)
This is an automated email from the ASF dual-hosted git repository.
maximebeauchemin pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-superset.git
The following commit(s) were added to refs/heads/master by this push:
new 336a106 CRUD hints around SQL expressions (#4645)
336a106 is described below
commit 336a1064d63a3952ffd8ed69b65d6c3d1f8af3d9
Author: Maxime Beauchemin <ma...@gmail.com>
AuthorDate: Mon Mar 26 09:44:37 2018 -0700
CRUD hints around SQL expressions (#4645)
* CRUD hints around SQL expressions
* Addressing comment
---
superset/connectors/sqla/views.py | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/superset/connectors/sqla/views.py b/superset/connectors/sqla/views.py
index 8398cbc..b667475 100644
--- a/superset/connectors/sqla/views.py
+++ b/superset/connectors/sqla/views.py
@@ -57,8 +57,8 @@ class TableColumnInlineView(CompactCRUDMixin, SupersetModelView): # noqa
'expression-defined columns in some cases. In most case '
'users should not need to alter this.'),
'expression': utils.markdown(
- 'a valid SQL expression as supported by the underlying backend. '
- 'Example: `substr(name, 1, 1)`', True),
+ 'a valid, *non-aggregating* SQL expression as supported by the '
+ 'underlying backend. Example: `substr(name, 1, 1)`', True),
'python_date_format': utils.markdown(Markup(
'The pattern of timestamp format, use '
'<a href="https://docs.python.org/2/library/'
@@ -114,8 +114,8 @@ class SqlMetricInlineView(CompactCRUDMixin, SupersetModelView): # noqa
'expression', 'table', 'd3format', 'is_restricted', 'warning_text']
description_columns = {
'expression': utils.markdown(
- 'a valid SQL expression as supported by the underlying backend. '
- 'Example: `count(DISTINCT userid)`', True),
+ 'a valid, *aggregating* SQL expression as supported by the '
+ 'underlying backend. Example: `count(DISTINCT userid)`', True),
'is_restricted': _('Whether the access to this metric is restricted '
'to certain roles. Only roles with the permission '
"'metric access on XXX (the name of this metric)' "
--
To stop receiving notification emails like this one, please contact
maximebeauchemin@apache.org.