You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@impala.apache.org by "Qifan Chen (Code Review)" <ge...@cloudera.org> on 2020/11/20 20:05:52 UTC

[Impala-ASF-CR] [WIP] IMPALA-10334 test stats extrapolation output doesn't match on erasure coding build

Qifan Chen has uploaded this change for review. ( http://gerrit.cloudera.org:8080/16756


Change subject: [WIP] IMPALA-10334 test_stats_extrapolation output doesn't match on erasure coding build
......................................................................

[WIP] IMPALA-10334 test_stats_extrapolation output doesn't match on erasure coding build

This patch skips test_stats_extrapolation for erasure code builds. The
reason is that an extra information line can be included in the scan
explain section when a hdfs table is erasure coded, which makes the
explain output non-deterministic. A new reason 'contain_full_explain'
is added to SkipIfEC to facilitate this.

Testing:
  Ran erasure coding version of the EE and CLUSTER tests.
  Ran core tests

Change-Id: I16c11aa0a1ec2d4569c272d2454915041039f950
---
M tests/common/skip.py
M tests/metadata/test_stats_extrapolation.py
2 files changed, 4 insertions(+), 0 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/56/16756/1
-- 
To view, visit http://gerrit.cloudera.org:8080/16756
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I16c11aa0a1ec2d4569c272d2454915041039f950
Gerrit-Change-Number: 16756
Gerrit-PatchSet: 1
Gerrit-Owner: Qifan Chen <qc...@cloudera.com>

[Impala-ASF-CR] IMPALA-10334 test stats extrapolation output doesn't match on erasure coding build

Posted by "Qifan Chen (Code Review)" <ge...@cloudera.org>.

Qifan Chen has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/16756 )

Change subject: IMPALA-10334 test_stats_extrapolation output doesn't match on erasure coding build
......................................................................

IMPALA-10334 test_stats_extrapolation output doesn't match on erasure coding build

This patch skips test_stats_extrapolation for erasure code builds. The
reason is that an extra erasure code information line can be included
in the scan explain section when a hdfs table is erasure coded. This
makes the explain output different between a normal build and an
erasure code build. A new reason 'contain_full_explain' is added to
SkipIfEC to facilitate this.

Testing:
  Ran erasure coding version of the EE and CLUSTER tests.
  Ran core tests

Change-Id: I16c11aa0a1ec2d4569c272d2454915041039f950
---
M tests/common/skip.py
M tests/metadata/test_stats_extrapolation.py
2 files changed, 4 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/56/16756/2
-- 
To view, visit http://gerrit.cloudera.org:8080/16756
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I16c11aa0a1ec2d4569c272d2454915041039f950
Gerrit-Change-Number: 16756
Gerrit-PatchSet: 2
Gerrit-Owner: Qifan Chen <qc...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>

[Impala-ASF-CR] IMPALA-10334 test stats extrapolation output doesn't match on erasure coding build

Posted by "Csaba Ringhofer (Code Review)" <ge...@cloudera.org>.

Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/16756 )

Change subject: IMPALA-10334 test_stats_extrapolation output doesn't match on erasure coding build
......................................................................


Patch Set 2: Code-Review+2

(1 comment)

http://gerrit.cloudera.org:8080/#/c/16756/2//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/16756/2//COMMIT_MSG@7
PS2, Line 7: IMPALA-10334 test_stats_extrapolation output doesn't match on erasure coding build
nit: we usually put : after jira



-- 
To view, visit http://gerrit.cloudera.org:8080/16756
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I16c11aa0a1ec2d4569c272d2454915041039f950
Gerrit-Change-Number: 16756
Gerrit-PatchSet: 2
Gerrit-Owner: Qifan Chen <qc...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Fri, 20 Nov 2020 20:57:53 +0000
Gerrit-HasComments: Yes