[GitHub] [airflow] potiuk edited a comment on pull request #21238: Use Identity instead of Seqence in SQLAlchemy 1.4 for MSSQL

[GitBox <gi...@apache.org>]

potiuk edited a comment on pull request #21238:
URL: https://github.com/apache/airflow/pull/21238#issuecomment-1026271689


   > How did FAB deal with this?
   
   Yeah. My thought exactly. And this was the first thing I checked. And it ain't pretty at all.
   
   Their code is extremely far away from ours - so much extremely different that I am not sure what was the original code about (and to be honest I just want to get it work rather than solve all the provenence problem) 
   
   The code we have is completely different that the current FAB code (though I checked the fields/columns and they seem to be in-sync).
   
   The current version of FAB seem sto derive their classes from mongoengine's  Document - from what I could see. B
   
   I do not think they use sequence any more in their code, but I'd say tracking the whole history and re-doing all that is far beyond the "let's fix our main" task.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org