[GitHub] [hadoop] Hexiaoqiao commented on a diff in pull request #6029: HDFS-17182. DataSetLockManager.lockLeakCheck() is not thread-safe.

["Hexiaoqiao (via GitHub)" <gi...@apache.org>]

Hexiaoqiao commented on code in PR #6029:
URL: https://github.com/apache/hadoop/pull/6029#discussion_r1326940963


##########
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/DataSetLockManager.java:
##########
@@ -256,7 +256,7 @@ private synchronized void putThreadName(String thread) {
     threadCountMap.putIfAbsent(thread, new TrackLog(thread));
   }
 
-  public void lockLeakCheck() {
+  public synchronized void lockLeakCheck() {

Review Comment:
   @LiuGuH Thanks for your contribution here. IIRC, this is only invoked when DataNode instance shutdown, and no more concurrent issue generally. So do you meet some issues here? Theoretically, I think it is better to add `synchronized`. Thanks again.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org