You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "rjgoyln (via GitHub)" <gi...@apache.org> on 2026/04/14 16:11:35 UTC
[PR] fix(migration): restore autoincrement for callback_request id during … [airflow]
rjgoyln opened a new pull request, #65230:
URL: https://github.com/apache/airflow/pull/65230
### Summary
This PR fixes a downgrade regression introduced in the 3.2.0 callback table migration.
After downgrading to 3.1.x, callback_request.id could lose its auto-increment/default behavior, which led to NotNullViolation errors and scheduler instability.
The fix restores database-specific auto-increment defaults and adds regression coverage to prevent recurrence.
### Changes
- Updated migration 0093 downgrade logic to reliably restore callback_request.id auto-increment behavior after table restructuring.
- Added PostgreSQL-specific sequence recovery: create/own sequence, set value safely for empty and non-empty tables, and re-attach nextval as column default.
- Added MySQL-specific AUTO_INCREMENT recovery using MAX(id) + 1.
- Added a PostgreSQL regression test that runs the downgrade path and verifies:
- id has a valid default expression
- inserts without an explicit id succeed.
* closes: #65000
-->
---
##### Was generative AI tooling used to co-author this PR?
<!--
If generative AI tooling has been used in the process of authoring this PR, please
change below checkbox to `[X]` followed by the name of the tool, uncomment the "Generated-by".
-->
- [ ] Yes (please specify the tool below)
<!--
Generated-by: [Tool Name] following [the guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#gen-ai-assisted-contributions)
-->
---
* Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)** for more information. Note: commit author/co-author name and email in commits become permanently public when merged.
* For fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed.
* When adding dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
* For significant user-facing changes create newsfragment: `{pr_number}.significant.rst`, in [airflow-core/newsfragments](https://github.com/apache/airflow/tree/main/airflow-core/newsfragments). You can add this file in a follow-up commit after the PR is created so you know the PR number.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Refactor: Standardize migration using Alembic batch operations [airflow]
Posted by "ashb (via GitHub)" <gi...@apache.org>.
ashb commented on code in PR #65230:
URL: https://github.com/apache/airflow/pull/65230#discussion_r3140355801
##########
airflow-core/tests/unit/migrations/test_0093_restructure_callback_table.py:
##########
@@ -0,0 +1,112 @@
+# Licensed to the Apache Software Foundation (ASF) under one
Review Comment:
Please remove this - we don't bother with tests for migration files except in very very rare circumstances
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Refactor: Standardize migration using Alembic batch operations [airflow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #65230:
URL: https://github.com/apache/airflow/pull/65230#issuecomment-4356693162
### Backport successfully created: v3-2-test
Note: As of [Merging PRs targeted for Airflow 3.X](https://github.com/apache/airflow/blob/main/dev/README_AIRFLOW3_DEV.md#merging-prs-targeted-for-airflow-3x)
the committer who merges the PR is responsible for backporting the PRs that are bug fixes (generally speaking) to the maintenance branches.
In matter of doubt please ask in [#release-management](https://apache-airflow.slack.com/archives/C03G9H97MM2) Slack channel.
<table>
<tr>
<th>Status</th>
<th>Branch</th>
<th>Result</th>
</tr>
<tr>
<td>✅</td>
<td>v3-2-test</td>
<td><a href="https://github.com/apache/airflow/pull/66189"><img src="https://img.shields.io/badge/PR-66189-blue" alt="PR Link"></a></td>
</tr>
</table>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Refactor: Standardize migration using Alembic batch operations [airflow]
Posted by "rjgoyln (via GitHub)" <gi...@apache.org>.
rjgoyln commented on code in PR #65230:
URL: https://github.com/apache/airflow/pull/65230#discussion_r3141482613
##########
airflow-core/tests/unit/migrations/test_0093_restructure_callback_table.py:
##########
@@ -0,0 +1,112 @@
+# Licensed to the Apache Software Foundation (ASF) under one
Review Comment:
Done, I have removed the test file. Thank you!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Refactor: Standardize migration using Alembic batch operations [airflow]
Posted by "kaxil (via GitHub)" <gi...@apache.org>.
kaxil merged PR #65230:
URL: https://github.com/apache/airflow/pull/65230
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org