You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@lucene.apache.org by cp...@apache.org on 2015/08/19 21:11:25 UTC
svn commit: r1696649 - in /lucene/dev/trunk/lucene: CHANGES.txt
core/src/java/org/apache/lucene/index/IndexWriterConfig.java
core/src/java/org/apache/lucene/index/LiveIndexWriterConfig.java
core/src/test/org/apache/lucene/index/TestIndexWriterConfig.java
Author: cpoerschke
Date: Wed Aug 19 19:11:24 2015
New Revision: 1696649
URL: http://svn.apache.org/r1696649
Log:
LUCENE-6738: remove IndexWriterConfig.[gs]etIndexingChain
Modified:
lucene/dev/trunk/lucene/CHANGES.txt
lucene/dev/trunk/lucene/core/src/java/org/apache/lucene/index/IndexWriterConfig.java
lucene/dev/trunk/lucene/core/src/java/org/apache/lucene/index/LiveIndexWriterConfig.java
lucene/dev/trunk/lucene/core/src/test/org/apache/lucene/index/TestIndexWriterConfig.java
Modified: lucene/dev/trunk/lucene/CHANGES.txt
URL: http://svn.apache.org/viewvc/lucene/dev/trunk/lucene/CHANGES.txt?rev=1696649&r1=1696648&r2=1696649&view=diff
==============================================================================
--- lucene/dev/trunk/lucene/CHANGES.txt (original)
+++ lucene/dev/trunk/lucene/CHANGES.txt Wed Aug 19 19:11:24 2015
@@ -90,6 +90,9 @@ Other
* LUCENE-6729: Upgrade ASM used in expressions module to version 5.0.4.
(Uwe Schindler)
+* LUCENE-6738: remove IndexWriterConfig.[gs]etIndexingChain
+ (Christine Poerschke)
+
Build
* LUCENE-6732: Improve checker for invalid source patterns to also
Modified: lucene/dev/trunk/lucene/core/src/java/org/apache/lucene/index/IndexWriterConfig.java
URL: http://svn.apache.org/viewvc/lucene/dev/trunk/lucene/core/src/java/org/apache/lucene/index/IndexWriterConfig.java?rev=1696649&r1=1696648&r2=1696649&view=diff
==============================================================================
--- lucene/dev/trunk/lucene/core/src/java/org/apache/lucene/index/IndexWriterConfig.java (original)
+++ lucene/dev/trunk/lucene/core/src/java/org/apache/lucene/index/IndexWriterConfig.java Wed Aug 19 19:11:24 2015
@@ -301,22 +301,6 @@ public final class IndexWriterConfig ext
return readerPooling;
}
- /** Expert: sets the {@link DocConsumer} chain to be used to process documents.
- *
- * <p>Only takes effect when IndexWriter is first created. */
- IndexWriterConfig setIndexingChain(IndexingChain indexingChain) {
- if (indexingChain == null) {
- throw new IllegalArgumentException("indexingChain must not be null");
- }
- this.indexingChain = indexingChain;
- return this;
- }
-
- @Override
- IndexingChain getIndexingChain() {
- return indexingChain;
- }
-
/**
* Expert: Controls when segments are flushed to disk during indexing.
* The {@link FlushPolicy} initialized during {@link IndexWriter} instantiation and once initialized
Modified: lucene/dev/trunk/lucene/core/src/java/org/apache/lucene/index/LiveIndexWriterConfig.java
URL: http://svn.apache.org/viewvc/lucene/dev/trunk/lucene/core/src/java/org/apache/lucene/index/LiveIndexWriterConfig.java?rev=1696649&r1=1696648&r2=1696649&view=diff
==============================================================================
--- lucene/dev/trunk/lucene/core/src/java/org/apache/lucene/index/LiveIndexWriterConfig.java (original)
+++ lucene/dev/trunk/lucene/core/src/java/org/apache/lucene/index/LiveIndexWriterConfig.java Wed Aug 19 19:11:24 2015
@@ -380,8 +380,7 @@ public class LiveIndexWriterConfig {
}
/**
- * Returns the indexing chain set on
- * {@link IndexWriterConfig#setIndexingChain(IndexingChain)}.
+ * Returns the indexing chain.
*/
IndexingChain getIndexingChain() {
return indexingChain;
Modified: lucene/dev/trunk/lucene/core/src/test/org/apache/lucene/index/TestIndexWriterConfig.java
URL: http://svn.apache.org/viewvc/lucene/dev/trunk/lucene/core/src/test/org/apache/lucene/index/TestIndexWriterConfig.java?rev=1696649&r1=1696648&r2=1696649&view=diff
==============================================================================
--- lucene/dev/trunk/lucene/core/src/test/org/apache/lucene/index/TestIndexWriterConfig.java (original)
+++ lucene/dev/trunk/lucene/core/src/test/org/apache/lucene/index/TestIndexWriterConfig.java Wed Aug 19 19:11:24 2015
@@ -245,14 +245,6 @@ public class TestIndexWriterConfig exten
// Test IndexingChain
assertTrue(DocumentsWriterPerThread.defaultIndexingChain == conf.getIndexingChain());
- conf.setIndexingChain(new MyIndexingChain());
- assertEquals(MyIndexingChain.class, conf.getIndexingChain().getClass());
- try {
- conf.setIndexingChain(null);
- fail();
- } catch (IllegalArgumentException e) {
- // ok
- }
try {
conf.setMaxBufferedDeleteTerms(0);