You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@datafusion.apache.org by "n0r0shi (via GitHub)" <gi...@apache.org> on 2026/02/25 05:07:21 UTC
[PR] feat: support ilike expression [datafusion-comet]
n0r0shi opened a new pull request, #3589:
URL: https://github.com/apache/datafusion-comet/pull/3589
## Summary
- Wire `ilike` from the `datafusion-spark` crate (`SparkILike`) to Comet
- Register in `jni_api.rs` and add serde mapping in `QueryPlanSerde.scala`
- Custom handler `CometILike` in `strings.scala` to reject non-default escape characters
- ILIKE requires case-insensitive comparison which depends on locale-specific case conversion. When `spark.comet.caseConversion.enabled` is disabled (default), ILIKE falls back to Spark to avoid incompatibilities with Rust's Unicode-based `to_lowercase()` vs Java's locale-aware rules (e.g. Turkish I)
Please let me know if the `caseConversion` handling is not appropriate
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] feat: support ilike expression [datafusion-comet]
Posted by "andygrove (via GitHub)" <gi...@apache.org>.
andygrove commented on PR #3589:
URL: https://github.com/apache/datafusion-comet/pull/3589#issuecomment-4032315043
Moving to draft until feedback is addressed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] feat: support ilike expression [datafusion-comet]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #3589:
URL: https://github.com/apache/datafusion-comet/pull/3589#issuecomment-4414227634
Thank you for your contribution. Unfortunately, this pull request is stale because it has been open 60 days with no activity. Please remove the stale label or comment or this will be closed in 7 days.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] feat: support ilike expression [datafusion-comet]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] closed pull request #3589: feat: support ilike expression
URL: https://github.com/apache/datafusion-comet/pull/3589
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org