[GitHub] [incubator-nuttx] GUIDINGLI edited a comment on pull request #5198: xtensa: fix lack of float register save & resotre

[GitBox <gi...@apache.org>]

GUIDINGLI edited a comment on pull request #5198:
URL: https://github.com/apache/incubator-nuttx/pull/5198#issuecomment-1008996802


   > @GUIDINGLI thanks for the detailed summary. For 2. I have a commit to fix that, I was willing to submit it after finishing another work. I also have a commit to fix `top_of_stack` in `xtensa_createstack`, is this the error you were referring to in 1.?
   
   error is here:
   ```
   -      cpstart      = (uintptr_t)_CP_ALIGNDOWN(XCHAL_CP0_SA_ALIGN,
   -                                              top_of_stack -
   -                                              XCHAL_CP1_SA_ALIGN);
   ```
   XCHAL_CP1_SA_ALIGN should be XTENSA_CP_SA_SIZE.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org