You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by "hudi-bot (via GitHub)" <gi...@apache.org> on 2025/11/30 12:19:02 UTC
[I] Revisit compact() and logCompact() methods in BaseHoodieWriteClient [hudi]
hudi-bot opened a new issue, #17000:
URL: https://github.com/apache/hudi/issues/17000
Revisit compact() and logCompact() methods in BaseHoodieWriteClient.
looks like we only need it for metadata table. we should see if we can avoid public methods at writeClient layer.
## JIRA info
- Link: https://issues.apache.org/jira/browse/HUDI-9390
- Type: Improvement
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Revisit compact() and logCompact() methods in BaseHoodieWriteClient [hudi]
Posted by "rangareddy (via GitHub)" <gi...@apache.org>.
rangareddy commented on issue #17000:
URL: https://github.com/apache/hudi/issues/17000#issuecomment-5391441937
This issue was reviewed as part of the JIRA-migrated backlog triage (HUDI-9390).
**Findings: confirmed, and there are four overloads rather than two.**
In `hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/BaseHoodieWriteClient.java`:
```java
:1300 public HoodieWriteMetadata<O> compact(String compactionInstantTime)
:1346 public HoodieWriteMetadata<O> logCompact(String logCompactionInstantTime)
:1360 public HoodieWriteMetadata<O> compact(String compactionInstantTime, boolean shouldComplete)
:1381 public HoodieWriteMetadata<O> logCompact(String logCompactionInstantTime, boolean shouldComplete)
```
So the public surface this ticket wants narrowed is unchanged.
Two things worth settling before touching it. First, `BaseHoodieWriteClient` is a public API surface, so reducing visibility is a semantic-versioning-relevant change and needs a deprecation path rather than a straight removal. Second, the premise in the description - "looks like we only need it for metadata table" - is the part to verify first: an audit of callers (including any outside this repo's control, since this is a client-facing class) determines whether the methods can be narrowed at all or only marked internal.
Keeping this open.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org