You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zookeeper.apache.org by "Flavio Paiva Junqueira (JIRA)" <ji...@apache.org> on 2008/10/14 01:21:44 UTC
[jira] Created: (ZOOKEEPER-185) Improved version of FLETest
Improved version of FLETest
---------------------------
Key: ZOOKEEPER-185
URL: https://issues.apache.org/jira/browse/ZOOKEEPER-185
Project: Zookeeper
Issue Type: Improvement
Components: leaderElection
Affects Versions: 3.0.0
Reporter: Flavio Paiva Junqueira
Assignee: Flavio Paiva Junqueira
FLETest sometimes fails because we don't run it along with all other parts of ZooKeeper. I'm attaching a patch that modifies the current implementation of FLETest and simulates the expected behavior of other parts of ZooKeeper when running along with them.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-185) Improved version of FLETest
Posted by "Flavio Paiva Junqueira (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-185?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Flavio Paiva Junqueira updated ZOOKEEPER-185:
---------------------------------------------
Attachment: ZOOKEEPER-185.patch
I'm uploading the patch I have committed. I've only changed the name of a variable as Ben suggested.
> Improved version of FLETest
> ---------------------------
>
> Key: ZOOKEEPER-185
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-185
> Project: Zookeeper
> Issue Type: Improvement
> Components: leaderElection
> Affects Versions: 3.0.0
> Reporter: Flavio Paiva Junqueira
> Assignee: Flavio Paiva Junqueira
> Fix For: 3.0.0
>
> Attachments: ZOOKEEPER-185.patch, ZOOKEEPER-185.patch, ZOOKEEPER-185.patch
>
>
> FLETest sometimes fails because we don't run it along with all other parts of ZooKeeper. I'm attaching a patch that modifies the current implementation of FLETest and simulates the expected behavior of other parts of ZooKeeper when running along with them.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-185) Improved version of FLETest
Posted by "Flavio Paiva Junqueira (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-185?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Flavio Paiva Junqueira updated ZOOKEEPER-185:
---------------------------------------------
Attachment: ZOOKEEPER-185.patch
Cleaned up the previous patch and added some comments.
> Improved version of FLETest
> ---------------------------
>
> Key: ZOOKEEPER-185
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-185
> Project: Zookeeper
> Issue Type: Improvement
> Components: leaderElection
> Affects Versions: 3.0.0
> Reporter: Flavio Paiva Junqueira
> Assignee: Flavio Paiva Junqueira
> Attachments: ZOOKEEPER-185.patch, ZOOKEEPER-185.patch
>
>
> FLETest sometimes fails because we don't run it along with all other parts of ZooKeeper. I'm attaching a patch that modifies the current implementation of FLETest and simulates the expected behavior of other parts of ZooKeeper when running along with them.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-185) Improved version of FLETest
Posted by "Flavio Paiva Junqueira (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-185?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Flavio Paiva Junqueira updated ZOOKEEPER-185:
---------------------------------------------
Resolution: Fixed
Status: Resolved (was: Patch Available)
Committed
> Improved version of FLETest
> ---------------------------
>
> Key: ZOOKEEPER-185
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-185
> Project: Zookeeper
> Issue Type: Improvement
> Components: leaderElection
> Affects Versions: 3.0.0
> Reporter: Flavio Paiva Junqueira
> Assignee: Flavio Paiva Junqueira
> Fix For: 3.0.0
>
> Attachments: ZOOKEEPER-185.patch, ZOOKEEPER-185.patch, ZOOKEEPER-185.patch
>
>
> FLETest sometimes fails because we don't run it along with all other parts of ZooKeeper. I'm attaching a patch that modifies the current implementation of FLETest and simulates the expected behavior of other parts of ZooKeeper when running along with them.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-185) Improved version of FLETest
Posted by "Flavio Paiva Junqueira (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-185?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Flavio Paiva Junqueira updated ZOOKEEPER-185:
---------------------------------------------
Status: Patch Available (was: Open)
> Improved version of FLETest
> ---------------------------
>
> Key: ZOOKEEPER-185
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-185
> Project: Zookeeper
> Issue Type: Improvement
> Components: leaderElection
> Affects Versions: 3.0.0
> Reporter: Flavio Paiva Junqueira
> Assignee: Flavio Paiva Junqueira
> Attachments: ZOOKEEPER-185.patch, ZOOKEEPER-185.patch
>
>
> FLETest sometimes fails because we don't run it along with all other parts of ZooKeeper. I'm attaching a patch that modifies the current implementation of FLETest and simulates the expected behavior of other parts of ZooKeeper when running along with them.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-185) Improved version of FLETest
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-185?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12639797#action_12639797 ]
Hudson commented on ZOOKEEPER-185:
----------------------------------
Integrated in ZooKeeper-trunk #114 (See [http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/114/])
> Improved version of FLETest
> ---------------------------
>
> Key: ZOOKEEPER-185
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-185
> Project: Zookeeper
> Issue Type: Improvement
> Components: leaderElection
> Affects Versions: 3.0.0
> Reporter: Flavio Paiva Junqueira
> Assignee: Flavio Paiva Junqueira
> Fix For: 3.0.0
>
> Attachments: ZOOKEEPER-185.patch, ZOOKEEPER-185.patch, ZOOKEEPER-185.patch
>
>
> FLETest sometimes fails because we don't run it along with all other parts of ZooKeeper. I'm attaching a patch that modifies the current implementation of FLETest and simulates the expected behavior of other parts of ZooKeeper when running along with them.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-185) Improved version of FLETest
Posted by "Benjamin Reed (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-185?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Benjamin Reed updated ZOOKEEPER-185:
------------------------------------
Hadoop Flags: [Reviewed]
+1 Looks good. My only suggestion would be to rename deadCount to successCount or something like that.
> Improved version of FLETest
> ---------------------------
>
> Key: ZOOKEEPER-185
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-185
> Project: Zookeeper
> Issue Type: Improvement
> Components: leaderElection
> Affects Versions: 3.0.0
> Reporter: Flavio Paiva Junqueira
> Assignee: Flavio Paiva Junqueira
> Attachments: ZOOKEEPER-185.patch, ZOOKEEPER-185.patch
>
>
> FLETest sometimes fails because we don't run it along with all other parts of ZooKeeper. I'm attaching a patch that modifies the current implementation of FLETest and simulates the expected behavior of other parts of ZooKeeper when running along with them.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-185) Improved version of FLETest
Posted by "Flavio Paiva Junqueira (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-185?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Flavio Paiva Junqueira updated ZOOKEEPER-185:
---------------------------------------------
Fix Version/s: 3.0.0
> Improved version of FLETest
> ---------------------------
>
> Key: ZOOKEEPER-185
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-185
> Project: Zookeeper
> Issue Type: Improvement
> Components: leaderElection
> Affects Versions: 3.0.0
> Reporter: Flavio Paiva Junqueira
> Assignee: Flavio Paiva Junqueira
> Fix For: 3.0.0
>
> Attachments: ZOOKEEPER-185.patch, ZOOKEEPER-185.patch, ZOOKEEPER-185.patch
>
>
> FLETest sometimes fails because we don't run it along with all other parts of ZooKeeper. I'm attaching a patch that modifies the current implementation of FLETest and simulates the expected behavior of other parts of ZooKeeper when running along with them.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-185) Improved version of FLETest
Posted by "Flavio Paiva Junqueira (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-185?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Flavio Paiva Junqueira updated ZOOKEEPER-185:
---------------------------------------------
Attachment: ZOOKEEPER-185.patch
> Improved version of FLETest
> ---------------------------
>
> Key: ZOOKEEPER-185
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-185
> Project: Zookeeper
> Issue Type: Improvement
> Components: leaderElection
> Affects Versions: 3.0.0
> Reporter: Flavio Paiva Junqueira
> Assignee: Flavio Paiva Junqueira
> Attachments: ZOOKEEPER-185.patch
>
>
> FLETest sometimes fails because we don't run it along with all other parts of ZooKeeper. I'm attaching a patch that modifies the current implementation of FLETest and simulates the expected behavior of other parts of ZooKeeper when running along with them.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-185) Improved version of FLETest
Posted by "Patrick Hunt (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-185?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12639260#action_12639260 ]
Patrick Hunt commented on ZOOKEEPER-185:
----------------------------------------
I ran this patch ~25 times and it never failed. Looks good!
> Improved version of FLETest
> ---------------------------
>
> Key: ZOOKEEPER-185
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-185
> Project: Zookeeper
> Issue Type: Improvement
> Components: leaderElection
> Affects Versions: 3.0.0
> Reporter: Flavio Paiva Junqueira
> Assignee: Flavio Paiva Junqueira
> Attachments: ZOOKEEPER-185.patch
>
>
> FLETest sometimes fails because we don't run it along with all other parts of ZooKeeper. I'm attaching a patch that modifies the current implementation of FLETest and simulates the expected behavior of other parts of ZooKeeper when running along with them.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.