You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by "Timothy St. Clair" <ts...@redhat.com> on 2014/03/07 17:56:57 UTC

Review Request 18910: Removal of python-boto from the repo and add configure checks.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18910/
-----------------------------------------------------------

Review request for mesos, Ben Becker and Till Toenshoff.


Bugs: MESOS-1072
    https://issues.apache.org/jira/browse/MESOS-1072


Repository: mesos-git


Description
-------

Python boto exists on nearly all platforms that I can think of.  It makes sense to add the check to configure and remove from the repo.


Diffs
-----

  3rdparty/Makefile.am 8e1d91535205ae4988f5d948060d0335795c8d6e 
  3rdparty/versions.am 102d6f4e8338037d08c19581111b81fa8a0622b1 
  LICENSE b45416f1cc1bb98e8edb1ebdc078b05e6c514439 
  configure.ac 91ddf57b3836bcdb31e5f7cf1e64cf8d14743374 
  ec2/mesos-ec2 3bc5d6307b2759cec0cea430b44baa2809a6f2d2 
  m4/ac_python_module.m4 PRE-CREATION 
  mesos.pc.in PRE-CREATION 

Diff: https://reviews.apache.org/r/18910/diff/


Testing
-------

make check.


Thanks,

Timothy St. Clair


Re: Review Request 18910: Removal of python-boto from the repo and add configure checks.

Posted by Mesos ReviewBot <de...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18910/#review36537
-----------------------------------------------------------


Patch looks great!

Reviews applied: [18910]

All tests passed.

- Mesos ReviewBot


On March 7, 2014, 4:56 p.m., Timothy St. Clair wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18910/
> -----------------------------------------------------------
> 
> (Updated March 7, 2014, 4:56 p.m.)
> 
> 
> Review request for mesos, Ben Becker and Till Toenshoff.
> 
> 
> Bugs: MESOS-1072
>     https://issues.apache.org/jira/browse/MESOS-1072
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> Python boto exists on nearly all platforms that I can think of.  It makes sense to add the check to configure and remove from the repo.
> 
> 
> Diffs
> -----
> 
>   3rdparty/Makefile.am 8e1d91535205ae4988f5d948060d0335795c8d6e 
>   3rdparty/versions.am 102d6f4e8338037d08c19581111b81fa8a0622b1 
>   LICENSE b45416f1cc1bb98e8edb1ebdc078b05e6c514439 
>   configure.ac 91ddf57b3836bcdb31e5f7cf1e64cf8d14743374 
>   ec2/mesos-ec2 3bc5d6307b2759cec0cea430b44baa2809a6f2d2 
>   m4/ac_python_module.m4 PRE-CREATION 
>   mesos.pc.in PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/18910/diff/
> 
> 
> Testing
> -------
> 
> make check.
> 
> 
> Thanks,
> 
> Timothy St. Clair
> 
>


Re: Review Request 18910: Removal of python-boto from the repo and add configure checks.

Posted by "Timothy St. Clair" <ts...@redhat.com>.

> On March 12, 2014, 8:32 p.m., Benjamin Hindman wrote:
> > This looks good Tim. I get the feeling that the mesos.pc.in doesn't need to be in this review though?

It doesn't but it's so minor it didn't warrant a separate patch, so I started adding it here. 


- Timothy


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18910/#review36979
-----------------------------------------------------------


On March 12, 2014, 9:50 p.m., Timothy St. Clair wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18910/
> -----------------------------------------------------------
> 
> (Updated March 12, 2014, 9:50 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Till Toenshoff.
> 
> 
> Bugs: MESOS-1072
>     https://issues.apache.org/jira/browse/MESOS-1072
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> Python boto exists on nearly all platforms that I can think of.  It makes sense to add the check to configure and remove from the repo.
> 
> 
> Diffs
> -----
> 
>   3rdparty/Makefile.am 8e1d915 
>   3rdparty/versions.am 102d6f4 
>   LICENSE b45416f 
>   configure.ac 639d4ad 
>   docs/getting-started.md 45a4f14 
>   ec2/mesos-ec2 3bc5d63 
>   m4/ac_python_module.m4 PRE-CREATION 
>   mesos.pc.in PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/18910/diff/
> 
> 
> Testing
> -------
> 
> make check.
> 
> 
> Thanks,
> 
> Timothy St. Clair
> 
>


Re: Review Request 18910: Removal of python-boto from the repo and add configure checks.

Posted by Benjamin Hindman <be...@berkeley.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18910/#review36979
-----------------------------------------------------------

Ship it!


This looks good Tim. I get the feeling that the mesos.pc.in doesn't need to be in this review though?


mesos.pc.in
<https://reviews.apache.org/r/18910/#comment68205>

    Do you need the newline?


- Benjamin Hindman


On March 7, 2014, 10:58 p.m., Timothy St. Clair wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18910/
> -----------------------------------------------------------
> 
> (Updated March 7, 2014, 10:58 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Till Toenshoff.
> 
> 
> Bugs: MESOS-1072
>     https://issues.apache.org/jira/browse/MESOS-1072
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> Python boto exists on nearly all platforms that I can think of.  It makes sense to add the check to configure and remove from the repo.
> 
> 
> Diffs
> -----
> 
>   3rdparty/Makefile.am 8e1d915 
>   3rdparty/versions.am 102d6f4 
>   LICENSE b45416f 
>   configure.ac 91ddf57 
>   docs/getting-started.md 3379f9d 
>   ec2/mesos-ec2 3bc5d63 
>   m4/ac_python_module.m4 PRE-CREATION 
>   mesos.pc.in PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/18910/diff/
> 
> 
> Testing
> -------
> 
> make check.
> 
> 
> Thanks,
> 
> Timothy St. Clair
> 
>


Re: Review Request 18910: Removal of python-boto from the repo and add configure checks.

Posted by Benjamin Hindman <be...@berkeley.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18910/#review36999
-----------------------------------------------------------


This was submitted. FYI, it didn't include the removal of the actual zip file, which I added to the patch.

- Benjamin Hindman


On March 12, 2014, 9:50 p.m., Timothy St. Clair wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18910/
> -----------------------------------------------------------
> 
> (Updated March 12, 2014, 9:50 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Till Toenshoff.
> 
> 
> Bugs: MESOS-1072
>     https://issues.apache.org/jira/browse/MESOS-1072
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> Python boto exists on nearly all platforms that I can think of.  It makes sense to add the check to configure and remove from the repo.
> 
> 
> Diffs
> -----
> 
>   3rdparty/Makefile.am 8e1d915 
>   3rdparty/versions.am 102d6f4 
>   LICENSE b45416f 
>   configure.ac 639d4ad 
>   docs/getting-started.md 45a4f14 
>   ec2/mesos-ec2 3bc5d63 
>   m4/ac_python_module.m4 PRE-CREATION 
>   mesos.pc.in PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/18910/diff/
> 
> 
> Testing
> -------
> 
> make check.
> 
> 
> Thanks,
> 
> Timothy St. Clair
> 
>


Re: Review Request 18910: Removal of python-boto from the repo and add configure checks.

Posted by "Timothy St. Clair" <ts...@redhat.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18910/
-----------------------------------------------------------

(Updated March 12, 2014, 9:50 p.m.)


Review request for mesos, Benjamin Hindman and Till Toenshoff.


Changes
-------

Updated patch per review


Bugs: MESOS-1072
    https://issues.apache.org/jira/browse/MESOS-1072


Repository: mesos-git


Description
-------

Python boto exists on nearly all platforms that I can think of.  It makes sense to add the check to configure and remove from the repo.


Diffs (updated)
-----

  3rdparty/Makefile.am 8e1d915 
  3rdparty/versions.am 102d6f4 
  LICENSE b45416f 
  configure.ac 639d4ad 
  docs/getting-started.md 45a4f14 
  ec2/mesos-ec2 3bc5d63 
  m4/ac_python_module.m4 PRE-CREATION 
  mesos.pc.in PRE-CREATION 

Diff: https://reviews.apache.org/r/18910/diff/


Testing
-------

make check.


Thanks,

Timothy St. Clair


Re: Review Request 18910: Removal of python-boto from the repo and add configure checks.

Posted by "Timothy St. Clair" <ts...@redhat.com>.

> On March 12, 2014, 1:54 a.m., Till Toenshoff wrote:
> > Looks good. I wonder if a more explicit dependency documentation would help. Wouldn't it also be great to warn users that mesos-ec2 services wont be usable when boto was not detected on their system?

I think adding the explicit warning makes sense, I'll update. 


- Timothy


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18910/#review36882
-----------------------------------------------------------


On March 7, 2014, 10:58 p.m., Timothy St. Clair wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18910/
> -----------------------------------------------------------
> 
> (Updated March 7, 2014, 10:58 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Till Toenshoff.
> 
> 
> Bugs: MESOS-1072
>     https://issues.apache.org/jira/browse/MESOS-1072
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> Python boto exists on nearly all platforms that I can think of.  It makes sense to add the check to configure and remove from the repo.
> 
> 
> Diffs
> -----
> 
>   3rdparty/Makefile.am 8e1d915 
>   3rdparty/versions.am 102d6f4 
>   LICENSE b45416f 
>   configure.ac 91ddf57 
>   docs/getting-started.md 3379f9d 
>   ec2/mesos-ec2 3bc5d63 
>   m4/ac_python_module.m4 PRE-CREATION 
>   mesos.pc.in PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/18910/diff/
> 
> 
> Testing
> -------
> 
> make check.
> 
> 
> Thanks,
> 
> Timothy St. Clair
> 
>


Re: Review Request 18910: Removal of python-boto from the repo and add configure checks.

Posted by "Timothy St. Clair" <ts...@redhat.com>.

> On March 12, 2014, 1:54 a.m., Till Toenshoff wrote:
> > docs/getting-started.md, line 36
> > <https://reviews.apache.org/r/18910/diff/2/?file=513927#file513927line36>
> >
> >     Would you mind moving python-boto into another line and adding a comment to make the need for python-boto it a bit more explicit?
> >     
> >     pip would be commonly used for installing python modules and that is AFAIK the only non tarball distribution for our OSX users.
> 
> Timothy St. Clair wrote:
>     boto is in ports.

It seem trivial, but if others want it I'll make a separate line.  The message that is displays should make everything pretty apparent. 


- Timothy


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18910/#review36882
-----------------------------------------------------------


On March 12, 2014, 9:50 p.m., Timothy St. Clair wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18910/
> -----------------------------------------------------------
> 
> (Updated March 12, 2014, 9:50 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Till Toenshoff.
> 
> 
> Bugs: MESOS-1072
>     https://issues.apache.org/jira/browse/MESOS-1072
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> Python boto exists on nearly all platforms that I can think of.  It makes sense to add the check to configure and remove from the repo.
> 
> 
> Diffs
> -----
> 
>   3rdparty/Makefile.am 8e1d915 
>   3rdparty/versions.am 102d6f4 
>   LICENSE b45416f 
>   configure.ac 639d4ad 
>   docs/getting-started.md 45a4f14 
>   ec2/mesos-ec2 3bc5d63 
>   m4/ac_python_module.m4 PRE-CREATION 
>   mesos.pc.in PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/18910/diff/
> 
> 
> Testing
> -------
> 
> make check.
> 
> 
> Thanks,
> 
> Timothy St. Clair
> 
>


Re: Review Request 18910: Removal of python-boto from the repo and add configure checks.

Posted by "Timothy St. Clair" <ts...@redhat.com>.

> On March 12, 2014, 1:54 a.m., Till Toenshoff wrote:
> > docs/getting-started.md, line 36
> > <https://reviews.apache.org/r/18910/diff/2/?file=513927#file513927line36>
> >
> >     Would you mind moving python-boto into another line and adding a comment to make the need for python-boto it a bit more explicit?
> >     
> >     pip would be commonly used for installing python modules and that is AFAIK the only non tarball distribution for our OSX users.

boto is in ports.


- Timothy


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18910/#review36882
-----------------------------------------------------------


On March 7, 2014, 10:58 p.m., Timothy St. Clair wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18910/
> -----------------------------------------------------------
> 
> (Updated March 7, 2014, 10:58 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Till Toenshoff.
> 
> 
> Bugs: MESOS-1072
>     https://issues.apache.org/jira/browse/MESOS-1072
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> Python boto exists on nearly all platforms that I can think of.  It makes sense to add the check to configure and remove from the repo.
> 
> 
> Diffs
> -----
> 
>   3rdparty/Makefile.am 8e1d915 
>   3rdparty/versions.am 102d6f4 
>   LICENSE b45416f 
>   configure.ac 91ddf57 
>   docs/getting-started.md 3379f9d 
>   ec2/mesos-ec2 3bc5d63 
>   m4/ac_python_module.m4 PRE-CREATION 
>   mesos.pc.in PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/18910/diff/
> 
> 
> Testing
> -------
> 
> make check.
> 
> 
> Thanks,
> 
> Timothy St. Clair
> 
>


Re: Review Request 18910: Removal of python-boto from the repo and add configure checks.

Posted by Till Toenshoff <to...@me.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18910/#review36882
-----------------------------------------------------------


Looks good. I wonder if a more explicit dependency documentation would help. Wouldn't it also be great to warn users that mesos-ec2 services wont be usable when boto was not detected on their system?


docs/getting-started.md
<https://reviews.apache.org/r/18910/#comment68076>

    Would you mind moving python-boto into another line and adding a comment to make the need for python-boto it a bit more explicit?
    
    pip would be commonly used for installing python modules and that is AFAIK the only non tarball distribution for our OSX users.


- Till Toenshoff


On March 7, 2014, 10:58 p.m., Timothy St. Clair wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18910/
> -----------------------------------------------------------
> 
> (Updated March 7, 2014, 10:58 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Till Toenshoff.
> 
> 
> Bugs: MESOS-1072
>     https://issues.apache.org/jira/browse/MESOS-1072
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> Python boto exists on nearly all platforms that I can think of.  It makes sense to add the check to configure and remove from the repo.
> 
> 
> Diffs
> -----
> 
>   3rdparty/Makefile.am 8e1d915 
>   3rdparty/versions.am 102d6f4 
>   LICENSE b45416f 
>   configure.ac 91ddf57 
>   docs/getting-started.md 3379f9d 
>   ec2/mesos-ec2 3bc5d63 
>   m4/ac_python_module.m4 PRE-CREATION 
>   mesos.pc.in PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/18910/diff/
> 
> 
> Testing
> -------
> 
> make check.
> 
> 
> Thanks,
> 
> Timothy St. Clair
> 
>


Re: Review Request 18910: Removal of python-boto from the repo and add configure checks.

Posted by Mesos ReviewBot <de...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18910/#review36584
-----------------------------------------------------------


Patch looks great!

Reviews applied: [18910]

All tests passed.

- Mesos ReviewBot


On March 7, 2014, 10:58 p.m., Timothy St. Clair wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18910/
> -----------------------------------------------------------
> 
> (Updated March 7, 2014, 10:58 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Till Toenshoff.
> 
> 
> Bugs: MESOS-1072
>     https://issues.apache.org/jira/browse/MESOS-1072
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> Python boto exists on nearly all platforms that I can think of.  It makes sense to add the check to configure and remove from the repo.
> 
> 
> Diffs
> -----
> 
>   3rdparty/Makefile.am 8e1d915 
>   3rdparty/versions.am 102d6f4 
>   LICENSE b45416f 
>   configure.ac 91ddf57 
>   docs/getting-started.md 3379f9d 
>   ec2/mesos-ec2 3bc5d63 
>   m4/ac_python_module.m4 PRE-CREATION 
>   mesos.pc.in PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/18910/diff/
> 
> 
> Testing
> -------
> 
> make check.
> 
> 
> Thanks,
> 
> Timothy St. Clair
> 
>


Re: Review Request 18910: Removal of python-boto from the repo and add configure checks.

Posted by "Timothy St. Clair" <ts...@redhat.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18910/
-----------------------------------------------------------

(Updated March 7, 2014, 10:58 p.m.)


Review request for mesos, Benjamin Hindman and Till Toenshoff.


Changes
-------

Cleanup mesos.pc.in and minor doc addition


Bugs: MESOS-1072
    https://issues.apache.org/jira/browse/MESOS-1072


Repository: mesos-git


Description
-------

Python boto exists on nearly all platforms that I can think of.  It makes sense to add the check to configure and remove from the repo.


Diffs (updated)
-----

  3rdparty/Makefile.am 8e1d915 
  3rdparty/versions.am 102d6f4 
  LICENSE b45416f 
  configure.ac 91ddf57 
  docs/getting-started.md 3379f9d 
  ec2/mesos-ec2 3bc5d63 
  m4/ac_python_module.m4 PRE-CREATION 
  mesos.pc.in PRE-CREATION 

Diff: https://reviews.apache.org/r/18910/diff/


Testing
-------

make check.


Thanks,

Timothy St. Clair


Re: Review Request 18910: Removal of python-boto from the repo and add configure checks.

Posted by "Timothy St. Clair" <ts...@redhat.com>.

> On March 7, 2014, 7:24 p.m., Nikita Vetoshkin wrote:
> > mesos.pc.in, line 6
> > <https://reviews.apache.org/r/18910/diff/1/?file=513744#file513744line6>
> >
> >     Efficient what? :) Seems like ending is missing

lol, nice catch.  I'll update.


- Timothy


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18910/#review36560
-----------------------------------------------------------


On March 7, 2014, 5:39 p.m., Timothy St. Clair wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18910/
> -----------------------------------------------------------
> 
> (Updated March 7, 2014, 5:39 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Till Toenshoff.
> 
> 
> Bugs: MESOS-1072
>     https://issues.apache.org/jira/browse/MESOS-1072
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> Python boto exists on nearly all platforms that I can think of.  It makes sense to add the check to configure and remove from the repo.
> 
> 
> Diffs
> -----
> 
>   3rdparty/Makefile.am 8e1d91535205ae4988f5d948060d0335795c8d6e 
>   3rdparty/versions.am 102d6f4e8338037d08c19581111b81fa8a0622b1 
>   LICENSE b45416f1cc1bb98e8edb1ebdc078b05e6c514439 
>   configure.ac 91ddf57b3836bcdb31e5f7cf1e64cf8d14743374 
>   ec2/mesos-ec2 3bc5d6307b2759cec0cea430b44baa2809a6f2d2 
>   m4/ac_python_module.m4 PRE-CREATION 
>   mesos.pc.in PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/18910/diff/
> 
> 
> Testing
> -------
> 
> make check.
> 
> 
> Thanks,
> 
> Timothy St. Clair
> 
>


Re: Review Request 18910: Removal of python-boto from the repo and add configure checks.

Posted by Nikita Vetoshkin <ni...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18910/#review36560
-----------------------------------------------------------



mesos.pc.in
<https://reviews.apache.org/r/18910/#comment67563>

    Efficient what? :) Seems like ending is missing


- Nikita Vetoshkin


On March 7, 2014, 5:39 p.m., Timothy St. Clair wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18910/
> -----------------------------------------------------------
> 
> (Updated March 7, 2014, 5:39 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Till Toenshoff.
> 
> 
> Bugs: MESOS-1072
>     https://issues.apache.org/jira/browse/MESOS-1072
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> Python boto exists on nearly all platforms that I can think of.  It makes sense to add the check to configure and remove from the repo.
> 
> 
> Diffs
> -----
> 
>   3rdparty/Makefile.am 8e1d91535205ae4988f5d948060d0335795c8d6e 
>   3rdparty/versions.am 102d6f4e8338037d08c19581111b81fa8a0622b1 
>   LICENSE b45416f1cc1bb98e8edb1ebdc078b05e6c514439 
>   configure.ac 91ddf57b3836bcdb31e5f7cf1e64cf8d14743374 
>   ec2/mesos-ec2 3bc5d6307b2759cec0cea430b44baa2809a6f2d2 
>   m4/ac_python_module.m4 PRE-CREATION 
>   mesos.pc.in PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/18910/diff/
> 
> 
> Testing
> -------
> 
> make check.
> 
> 
> Thanks,
> 
> Timothy St. Clair
> 
>


Re: Review Request 18910: Removal of python-boto from the repo and add configure checks.

Posted by "Timothy St. Clair" <ts...@redhat.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18910/
-----------------------------------------------------------

(Updated March 7, 2014, 5:39 p.m.)


Review request for mesos, Benjamin Hindman and Till Toenshoff.


Bugs: MESOS-1072
    https://issues.apache.org/jira/browse/MESOS-1072


Repository: mesos-git


Description
-------

Python boto exists on nearly all platforms that I can think of.  It makes sense to add the check to configure and remove from the repo.


Diffs
-----

  3rdparty/Makefile.am 8e1d91535205ae4988f5d948060d0335795c8d6e 
  3rdparty/versions.am 102d6f4e8338037d08c19581111b81fa8a0622b1 
  LICENSE b45416f1cc1bb98e8edb1ebdc078b05e6c514439 
  configure.ac 91ddf57b3836bcdb31e5f7cf1e64cf8d14743374 
  ec2/mesos-ec2 3bc5d6307b2759cec0cea430b44baa2809a6f2d2 
  m4/ac_python_module.m4 PRE-CREATION 
  mesos.pc.in PRE-CREATION 

Diff: https://reviews.apache.org/r/18910/diff/


Testing
-------

make check.


Thanks,

Timothy St. Clair