[GitHub] [arrow-datafusion] xudong963 commented on a change in pull request #1317: Extract Explain, Analyze, Extension in LogicalPlan as independent struct

[GitBox <gi...@apache.org>]

xudong963 commented on a change in pull request #1317:
URL: https://github.com/apache/arrow-datafusion/pull/1317#discussion_r750946040



##########
File path: ballista/rust/core/src/serde/logical_plan/to_proto.rs
##########
@@ -973,24 +973,24 @@ impl TryInto<protobuf::LogicalPlanNode> for &LogicalPlan {
                     )),
                 })
             }
-            LogicalPlan::Analyze { verbose, input, .. } => {
-                let input: protobuf::LogicalPlanNode = input.as_ref().try_into()?;
+            LogicalPlan::Analyze(a) => {

Review comment:
       In fact, I don't have a strong desire which is better. When the struct has many variables, I'd like to use `StructVar(s) => {s.v1, s.v2 ...}`




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org