[GitHub] [geode] gesterzhou opened pull request #2673: GEODE-5890: a cleaner fix to skip calling GatewayConflictResolver if …

["gesterzhou (GitHub)" <gi...@apache.org>]

…tag has

the same distributed system id.

@boglesby @jhuynh1 

Thank you for submitting a contribution to Apache Geode.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?

- [ ] Has your PR been rebased against the latest commit within the target branch (typically `develop`)?

- [ ] Is your initial contribution a single, squashed commit?

- [ ] Does `gradlew build` run cleanly?

- [ ] Have you written or updated unit tests to verify your changes?

- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?

### Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and
submit an update to your PR as soon as possible. If you need help, please send an
email to dev@geode.apache.org.


[ Full content available at: https://github.com/apache/geode/pull/2673 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] gesterzhou commented on pull request #2673: GEODE-5890: a cleaner fix to skip calling GatewayConflictResolver if …

["gesterzhou (GitHub)" <gi...@apache.org>]

This is the bug I fixed yesterday. In current code, we did not throw CME immediately when found tagDsid == stampDsid and tagTime <= stampTime. Instead, we throw CME when 
tagDsid == stampDsid and tagTime < stampTime. See following code:
    if (tagTime > stampTime || tagTime == stampTime && tagDsid >= stampDsid) {
      if (isDebugEnabled) {
        logger.debug("allowing event");
      }
      return true;
    }

I will split the test into 2, another for resolver. 

[ Full content available at: https://github.com/apache/geode/pull/2673 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] jhuynh1 commented on pull request #2673: GEODE-5890: a cleaner fix to skip calling GatewayConflictResolver if …

["jhuynh1 (GitHub)" <gi...@apache.org>]

Is there a reason why we are now checking >= instead of just >?

[ Full content available at: https://github.com/apache/geode/pull/2673 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] gesterzhou commented on issue #2673: GEODE-5890: a cleaner fix to skip calling GatewayConflictResolver if …

["gesterzhou (GitHub)" <gi...@apache.org>]

added test case to verify resolver not call in misorder case:
verify(resolver, never()).onEvent(any(), any());

[ Full content available at: https://github.com/apache/geode/pull/2673 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] jhuynh1 commented on pull request #2673: GEODE-5890: a cleaner fix to skip calling GatewayConflictResolver if …

["jhuynh1 (GitHub)" <gi...@apache.org>]

Would you be able to separate this into a separate test?  It will make the test more granular and easier to debug

[ Full content available at: https://github.com/apache/geode/pull/2673 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] gesterzhou closed pull request #2673: GEODE-5890: a cleaner fix to skip calling GatewayConflictResolver if …

["gesterzhou (GitHub)" <gi...@apache.org>]

[ pull request closed by gesterzhou ]

[ Full content available at: https://github.com/apache/geode/pull/2673 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org