[jira] [Updated] (SOLR-6840) Remove legacy solr.xml mode

["Erick Erickson (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/SOLR-6840?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Erick Erickson updated SOLR-6840:
---------------------------------
    Attachment: SOLR-6840.patch

OK, the bare beginnings of the patch. What it does:

1> removes _all_ of the references I could find  to any <cores.... tags.

2> Tries to deal with SolrTestCaseJ4 and TestHarness. TestHarness used to have a hard-coded <cores bit, but it doesn't now. Basically I create a core.properties file in the test area and include a name, schema and config, now the initCore tests in SolrTestCaseJ4 set the env var to  the file names being passed in. There are comments particularly in SolrTestDase4J that show an alternative approach, but that copies files all over the place and I really don't like that at all. I'm utterly sure that there's more work to do with these two files.....

3> removes anything like solr*old*.xml from the source tree.

Gets 78 more tests to pass. There are only 158 failing now. It started with 236 failing. So it's at least progress. Sounds worse than it is I suspect.

So I'm putting it up for comments on the approach, particularly the new core.properties, SolrTestCaseJ4 and TestHarness (not, I really haven't worked on this last).

And I'm also wondering if there's any good way to split this work up. There's going to be a LOT of tedious work to get all the tests to pass. But reconciling multiple people's patches will be an absolute pain. Maybe if people work on bits just put up patches (appropriately labeled) that just include the delta (or as close as one can get easily) and I'll reconcile and keep the uber-patch as current as I can? I may be able to look at TestHarness a bit more tonight...

> Remove legacy solr.xml mode
> ---------------------------
>
>                 Key: SOLR-6840
>                 URL: https://issues.apache.org/jira/browse/SOLR-6840
>             Project: Solr
>          Issue Type: Task
>            Reporter: Steve Rowe
>            Assignee: Erick Erickson
>            Priority: Blocker
>             Fix For: 5.0
>
>         Attachments: SOLR-6840.patch
>
>
> On the [Solr Cores and solr.xml page|https://cwiki.apache.org/confluence/display/solr/Solr+Cores+and+solr.xml], the Solr Reference Guide says:
> {quote}
> Starting in Solr 4.3, Solr will maintain two distinct formats for {{solr.xml}}, the _legacy_ and _discovery_ modes. The former is the format we have become accustomed to in which all of the cores one wishes to define in a Solr instance are defined in {{solr.xml}} in {{<cores><core/>...<core/></cores>}} tags. This format will continue to be supported through the entire 4.x code line.
> As of Solr 5.0 this form of solr.xml will no longer be supported.  Instead Solr will support _core discovery_. [...]
> The new "core discovery mode" structure for solr.xml will become mandatory as of Solr 5.0, see: Format of solr.xml.
> {quote}
> AFAICT, nothing has been done to remove legacy {{solr.xml}} mode from 5.0 or trunk.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org