You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Jie Yu <yu...@gmail.com> on 2018/09/01 04:26:12 UTC
Review Request 68594: Made overlay backend destroy more robust.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68594/
-----------------------------------------------------------
Review request for mesos, Chun-Hung Hsiao and Gilbert Song.
Bugs: MESOS-9196
https://issues.apache.org/jira/browse/MESOS-9196
Repository: mesos
Description
-------
Use MNT_DETACH for `unmount` so that if there are still processes
holding files or directies in the rootfs (e.g., regular filesystem
indexing), the unmount will still be successful. The kernel will cleanup
the mount when the number of references reach zero. Also, do not return
hard failure if `rmdir` failed. It's also possible that `rmdir` returns
EBUSY. See more details in MESOS-9196.
Diffs
-----
src/slave/containerizer/mesos/provisioner/backends/overlay.cpp e32b9918ac15122477e05ebe701c9425bbefa809
Diff: https://reviews.apache.org/r/68594/diff/1/
Testing
-------
sudo make check
Thanks,
Jie Yu
Re: Review Request 68594: Made overlay backend destroy more robust.
Posted by Gilbert Song <so...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68594/#review208215
-----------------------------------------------------------
Ship it!
Ship It!
- Gilbert Song
On Aug. 31, 2018, 9:50 p.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68594/
> -----------------------------------------------------------
>
> (Updated Aug. 31, 2018, 9:50 p.m.)
>
>
> Review request for mesos, Chun-Hung Hsiao and Gilbert Song.
>
>
> Bugs: MESOS-9196
> https://issues.apache.org/jira/browse/MESOS-9196
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Use MNT_DETACH for `unmount` so that if there are still processes
> holding files or directories in the rootfs (e.g., regular filesystem
> indexing), the unmount will still be successful. The kernel will cleanup
> the mount when the number of references reach zero. Also, do not return
> hard failure if `rmdir` failed. It's also possible that `rmdir` returns
> EBUSY. See more details in MESOS-9196.
>
>
> Diffs
> -----
>
> src/slave/containerizer/mesos/provisioner/backends/overlay.cpp e32b9918ac15122477e05ebe701c9425bbefa809
>
>
> Diff: https://reviews.apache.org/r/68594/diff/2/
>
>
> Testing
> -------
>
> sudo make check
>
>
> Thanks,
>
> Jie Yu
>
>
Re: Review Request 68594: Made overlay backend destroy more robust.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68594/
-----------------------------------------------------------
(Updated Sept. 1, 2018, 4:50 a.m.)
Review request for mesos, Chun-Hung Hsiao and Gilbert Song.
Changes
-------
Fixed typos.
Bugs: MESOS-9196
https://issues.apache.org/jira/browse/MESOS-9196
Repository: mesos
Description (updated)
-------
Use MNT_DETACH for `unmount` so that if there are still processes
holding files or directories in the rootfs (e.g., regular filesystem
indexing), the unmount will still be successful. The kernel will cleanup
the mount when the number of references reach zero. Also, do not return
hard failure if `rmdir` failed. It's also possible that `rmdir` returns
EBUSY. See more details in MESOS-9196.
Diffs (updated)
-----
src/slave/containerizer/mesos/provisioner/backends/overlay.cpp e32b9918ac15122477e05ebe701c9425bbefa809
Diff: https://reviews.apache.org/r/68594/diff/2/
Changes: https://reviews.apache.org/r/68594/diff/1-2/
Testing
-------
sudo make check
Thanks,
Jie Yu