[GitHub] [incubator-sdap-nexus] ngachung commented on a diff in pull request #243: SDAP-459 - Ensure min/max lat/lon values are float

["ngachung (via GitHub)" <gi...@apache.org>]

ngachung commented on code in PR #243:
URL: https://github.com/apache/incubator-sdap-nexus/pull/243#discussion_r1175573703


##########
data-access/nexustiles/nexustiles.py:
##########
@@ -500,7 +500,13 @@ def _metadata_store_docs_to_tiles(self, *store_docs):
                 if isinstance(max_lon, list):
                     max_lon = max_lon[0]
 
-                tile.bbox = BBox(min_lat, max_lat, min_lon, max_lon)
+                # In case it's been stored as a string
+                # Observed in JPL CDMS SDAP deployment
+                tile.bbox = BBox(
+                    float(min_lat), 
+                    float(max_lat), 
+                    float(min_lon), 
+                    float(max_lon))

Review Comment:
   @RKuttruff Since we've addressed the underlying cause of why Solr returned these values as string, this change is no longer needed right?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@sdap.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org