You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2022/08/05 10:06:28 UTC

[GitHub] [shardingsphere] sunkai-cai opened a new pull request, #19904: add registerMbeans of DataSourceProperties(Hikari)

sunkai-cai opened a new pull request, #19904:
URL: https://github.com/apache/shardingsphere/pull/19904

   Fixes #19085
   related issue #15695
   
   Changes proposed in this pull request:
   - support Hikari to use JMX
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] codecov-commenter commented on pull request #19904: add registerMbeans of DataSourceProperties(Hikari)

Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #19904:
URL: https://github.com/apache/shardingsphere/pull/19904#issuecomment-1207405491

   # [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/19904?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#19904](https://codecov.io/gh/apache/shardingsphere/pull/19904?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (ddbe96e) into [master](https://codecov.io/gh/apache/shardingsphere/commit/bd7f5ca8effc4f4fcc376e1e795543ef62d38bd7?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (bd7f5ca) will **decrease** coverage by `0.10%`.
   > The diff coverage is `62.29%`.
   
   ```diff
   @@             Coverage Diff              @@
   ##             master   #19904      +/-   ##
   ============================================
   - Coverage     60.24%   60.13%   -0.11%     
   - Complexity     2420     2422       +2     
   ============================================
     Files          3853     3882      +29     
     Lines         54924    55055     +131     
     Branches       7700     7701       +1     
   ============================================
   + Hits          33089    33110      +21     
   - Misses        18993    19103     +110     
     Partials       2842     2842              
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/19904?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...ojo/rule/YamlOnRuleAlteredActionConfiguration.java](https://codecov.io/gh/apache/shardingsphere/pull/19904/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtaW5mcmEvc2hhcmRpbmdzcGhlcmUtaW5mcmEtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9pbmZyYS95YW1sL2NvbmZpZy9wb2pvL3J1bGUvWWFtbE9uUnVsZUFsdGVyZWRBY3Rpb25Db25maWd1cmF0aW9uLmphdmE=) | `100.00% <ø> (+60.00%)` | :arrow_up: |
   | [...eline/scenario/rulealtered/RuleAlteredContext.java](https://codecov.io/gh/apache/shardingsphere/pull/19904/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUta2VybmVsL3NoYXJkaW5nc3BoZXJlLWRhdGEtcGlwZWxpbmUvc2hhcmRpbmdzcGhlcmUtZGF0YS1waXBlbGluZS1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9kYXRhL3BpcGVsaW5lL3NjZW5hcmlvL3J1bGVhbHRlcmVkL1J1bGVBbHRlcmVkQ29udGV4dC5qYXZh) | `0.00% <ø> (ø)` | |
   | [...rio/rulealtered/prepare/InventoryTaskSplitter.java](https://codecov.io/gh/apache/shardingsphere/pull/19904/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUta2VybmVsL3NoYXJkaW5nc3BoZXJlLWRhdGEtcGlwZWxpbmUvc2hhcmRpbmdzcGhlcmUtZGF0YS1waXBlbGluZS1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9kYXRhL3BpcGVsaW5lL3NjZW5hcmlvL3J1bGVhbHRlcmVkL3ByZXBhcmUvSW52ZW50b3J5VGFza1NwbGl0dGVyLmphdmE=) | `0.00% <0.00%> (ø)` | |
   | [.../config/yaml/YamlProxyDataSourceConfiguration.java](https://codecov.io/gh/apache/shardingsphere/pull/19904/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtcHJveHkvc2hhcmRpbmdzcGhlcmUtcHJveHktYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvcHJveHkvYmFja2VuZC9jb25maWcveWFtbC9ZYW1sUHJveHlEYXRhU291cmNlQ29uZmlndXJhdGlvbi5qYXZh) | `100.00% <ø> (ø)` | |
   | [...sql/common/statement/dcl/CreateGroupStatement.java](https://codecov.io/gh/apache/shardingsphere/pull/19904/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLXN0YXRlbWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc3FsL3BhcnNlci9zcWwvY29tbW9uL3N0YXRlbWVudC9kY2wvQ3JlYXRlR3JvdXBTdGF0ZW1lbnQuamF2YQ==) | `0.00% <0.00%> (ø)` | |
   | [...postgresql/dcl/PostgreSQLCreateGroupStatement.java](https://codecov.io/gh/apache/shardingsphere/pull/19904/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLXN0YXRlbWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc3FsL3BhcnNlci9zcWwvZGlhbGVjdC9zdGF0ZW1lbnQvcG9zdGdyZXNxbC9kY2wvUG9zdGdyZVNRTENyZWF0ZUdyb3VwU3RhdGVtZW50LmphdmE=) | `0.00% <0.00%> (ø)` | |
   | [.../data/pipeline/YamlPipelineInputConfiguration.java](https://codecov.io/gh/apache/shardingsphere/pull/19904/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtaW5mcmEvc2hhcmRpbmdzcGhlcmUtaW5mcmEtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9pbmZyYS95YW1sL2NvbmZpZy9wb2pvL2RhdGEvcGlwZWxpbmUvWWFtbFBpcGVsaW5lSW5wdXRDb25maWd1cmF0aW9uLmphdmE=) | `36.36% <36.36%> (ø)` | |
   | [...data/pipeline/YamlPipelineOutputConfiguration.java](https://codecov.io/gh/apache/shardingsphere/pull/19904/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtaW5mcmEvc2hhcmRpbmdzcGhlcmUtaW5mcmEtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9pbmZyYS95YW1sL2NvbmZpZy9wb2pvL2RhdGEvcGlwZWxpbmUvWWFtbFBpcGVsaW5lT3V0cHV0Q29uZmlndXJhdGlvbi5qYXZh) | `37.50% <37.50%> (ø)` | |
   | [...peline/YamlPipelineOutputConfigurationSwapper.java](https://codecov.io/gh/apache/shardingsphere/pull/19904/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtaW5mcmEvc2hhcmRpbmdzcGhlcmUtaW5mcmEtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9pbmZyYS95YW1sL2NvbmZpZy9zd2FwcGVyL3J1bGUvZGF0YS9waXBlbGluZS9ZYW1sUGlwZWxpbmVPdXRwdXRDb25maWd1cmF0aW9uU3dhcHBlci5qYXZh) | `63.63% <63.63%> (ø)` | |
   | [...ipeline/YamlPipelineInputConfigurationSwapper.java](https://codecov.io/gh/apache/shardingsphere/pull/19904/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtaW5mcmEvc2hhcmRpbmdzcGhlcmUtaW5mcmEtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9pbmZyYS95YW1sL2NvbmZpZy9zd2FwcGVyL3J1bGUvZGF0YS9waXBlbGluZS9ZYW1sUGlwZWxpbmVJbnB1dENvbmZpZ3VyYXRpb25Td2FwcGVyLmphdmE=) | `69.23% <69.23%> (ø)` | |
   | ... and [111 more](https://codecov.io/gh/apache/shardingsphere/pull/19904/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   :mega: Codecov can now indicate which changes are the most critical in Pull Requests. [Learn more](https://about.codecov.io/product/feature/runtime-insights/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] TeslaCN commented on a diff in pull request #19904: add registerMbeans of DataSourceProperties(Hikari)

Posted by GitBox <gi...@apache.org>.
TeslaCN commented on code in PR #19904:
URL: https://github.com/apache/shardingsphere/pull/19904#discussion_r939774133


##########
shardingsphere-infra/shardingsphere-infra-common/src/main/java/org/apache/shardingsphere/infra/datasource/config/PoolConfiguration.java:
##########
@@ -40,6 +40,8 @@ public final class PoolConfiguration {
     private final Integer minPoolSize;
     
     private final Boolean readOnly;
-    
+
+    private final Boolean registerMbeans;

Review Comment:
   Could we set this by `customProperties`? `registerMbeans` is Hikari's property, but PoolConfiguration is a common configuration.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] sunkai-cai closed pull request #19904: add registerMbeans of DataSourceProperties(Hikari)

Posted by GitBox <gi...@apache.org>.
sunkai-cai closed pull request #19904: add registerMbeans of  DataSourceProperties(Hikari)
URL: https://github.com/apache/shardingsphere/pull/19904


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org