[GitHub] [jackrabbit-oak] fabriziofortino commented on a diff in pull request #897: OAK-10187: oak-search-elastic: update Java Client independently of HLRC

["fabriziofortino (via GitHub)" <gi...@apache.org>]

fabriziofortino commented on code in PR #897:
URL: https://github.com/apache/jackrabbit-oak/pull/897#discussion_r1166457774


##########
oak-search-elastic/pom.xml:
##########
@@ -33,7 +33,8 @@
   <description>Oak Elasticsearch integration subproject</description>
 
   <properties>
-    <elasticsearch.version>7.17.7</elasticsearch.version>
+    <elasticsearch.hlrc.version>7.17.9</elasticsearch.hlrc.version>
+    <elasticsearch.java.version>8.5.3</elasticsearch.java.version>

Review Comment:
   Good point. I just read the elasticsearch java client is [forward compatible](https://www.elastic.co/guide/en/elasticsearch/client/java-api-client/current/introduction.html#:~:text=Elasticsearch%20language%20clients%20are%20only,distributions%20and%20without%20guarantees%20made.) while the HLRC was just backward compatible.
   
   Regarding the ingester, I am not sure it's already at the same level as the HLRC BulkProcessor. Retries seem to be missing. I would prefer to have them implemented in the client instead of implementing this logic in OAK.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@jackrabbit.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org