[jira] [Commented] (CB-14256) coho audit-license-headers issues in cordova-fetch

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CB-14256?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16570714#comment-16570714 ] 

ASF GitHub Bot commented on CB-14256:
-------------------------------------

brodybits opened a new pull request #34: CB-14256 license header fixes
URL: https://github.com/apache/cordova-fetch/pull/34
 
 
   ref: <https://issues.apache.org/jira/browse/CB-14256>
   
   - `dos2unix spec/support/dummy-local-plugin/plugin.xml`
   - add license header to `spec/support/dummy-local-plugin/plugin.xml` (copied from cordova-plugin-device)
   - `.ratignore` cover artifacts in `spec/support/repo-name-neq-plugin-id.git`
   
   needed for `coho audit-license-headers -r fetch` to pass ref: <https://github.com/apache/cordova-coho/blob/master/docs/tools-release-process.md#test>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> coho audit-license-headers issues in cordova-fetch
> --------------------------------------------------
>
>                 Key: CB-14256
>                 URL: https://issues.apache.org/jira/browse/CB-14256
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: cordova-fetch
>            Reporter: Chris Brody
>            Assignee: Chris Brody
>            Priority: Major
>
> {{coho audit-license-headers -r fetch}} uncovered the following text files without a valid license header:
>  * {{spec/support/dummy-local-plugin/plugin.xml}}
>  * {{spec/support/repo-name-neq-plugin-id.git/HEAD}}
>  * {{spec/support/repo-name-neq-plugin-id.git/config}}
>  * {{spec/support/repo-name-neq-plugin-id.git/refs/heads/master}}
> On the {{1.3.x}} branch this issue only shows up in {{spec/support/dummy-local-plugin/plugin.xml}} at this time.
> Recommended solution is to add standard header to {{spec/support/dummy-local-plugin/plugin.xml}} and add the other files to {{.ratignore}}.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org