You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "Shay Banon (JIRA)" <ji...@codehaus.org> on 2012/06/23 16:28:21 UTC
[jira] (MSHADE-123) 1.7 Causes failures in other plugins make
"basedir" point to the build dir
Shay Banon created MSHADE-123:
---------------------------------
Summary: 1.7 Causes failures in other plugins make "basedir" point to the build dir
Key: MSHADE-123
URL: https://jira.codehaus.org/browse/MSHADE-123
Project: Maven 2.x Shade Plugin
Issue Type: Bug
Reporter: Shay Banon
Priority: Blocker
Upgrading the 1.7 causes other plugins to have basedir now pointing to build dir, or something similar. The attached test case shows that with shade plugin 1.5, the assembly plugins successfully finds the sample.txt file (in basedir), while upgrading to 1.7 shade plugin causes the assembly plugin not to find it.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://jira.codehaus.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] (MSHADE-123) 1.7 Causes failures in other plugins make
"basedir" point to the build dir
Posted by "Benson Margulies (JIRA)" <ji...@codehaus.org>.
[ https://jira.codehaus.org/browse/MSHADE-123?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Benson Margulies closed MSHADE-123.
-----------------------------------
Resolution: Fixed
Fix Version/s: 1.7.1
------------------------------------------------------------------------
r1354435 | bimargulies | 2012-06-27 07:37:39 -0400 (Wed, 27 Jun 2012) | 3 lines
MSHADE-123: 1.7 Causes failures in other plugins make "basedir" point to the build dir
o revert the default back to basedir until and unless we come up with something better.
------------------------------------------------------------------------
> 1.7 Causes failures in other plugins make "basedir" point to the build dir
> --------------------------------------------------------------------------
>
> Key: MSHADE-123
> URL: https://jira.codehaus.org/browse/MSHADE-123
> Project: Maven 2.x Shade Plugin
> Issue Type: Bug
> Reporter: Shay Banon
> Assignee: Benson Margulies
> Priority: Blocker
> Fix For: 1.7.1
>
> Attachments: mvn-shade.zip
>
>
> Upgrading the 1.7 causes other plugins to have basedir now pointing to build dir, or something similar. The attached test case shows that with shade plugin 1.5, the assembly plugins successfully finds the sample.txt file (in basedir), while upgrading to 1.7 shade plugin causes the assembly plugin not to find it.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://jira.codehaus.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] (MSHADE-123) 1.7 Causes failures in other plugins make
"basedir" point to the build dir
Posted by "Hung Huynh (JIRA)" <ji...@codehaus.org>.
[ https://jira.codehaus.org/browse/MSHADE-123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=306610#comment-306610 ]
Hung Huynh commented on MSHADE-123:
-----------------------------------
I just got hit by this bug using maven-shade-plugin 1.7.1 and maven-assembly-plugin 2.3. References to ${basedir} in assembly plugin configuration file are all wrong.
> 1.7 Causes failures in other plugins make "basedir" point to the build dir
> --------------------------------------------------------------------------
>
> Key: MSHADE-123
> URL: https://jira.codehaus.org/browse/MSHADE-123
> Project: Maven 2.x Shade Plugin
> Issue Type: Bug
> Reporter: Shay Banon
> Assignee: Benson Margulies
> Priority: Blocker
> Fix For: 1.7.1
>
> Attachments: mvn-shade.zip
>
>
> Upgrading the 1.7 causes other plugins to have basedir now pointing to build dir, or something similar. The attached test case shows that with shade plugin 1.5, the assembly plugins successfully finds the sample.txt file (in basedir), while upgrading to 1.7 shade plugin causes the assembly plugin not to find it.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://jira.codehaus.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] (MSHADE-123) 1.7 Causes failures in other plugins make
"basedir" point to the build dir
Posted by "Benson Margulies (JIRA)" <ji...@codehaus.org>.
[ https://jira.codehaus.org/browse/MSHADE-123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=301765#comment-301765 ]
Benson Margulies commented on MSHADE-123:
-----------------------------------------
OK, I see how this happens. The question is going to be how to fix it.
The d-r-p becomes 'the pom', and its location is now in target to avoid build collisions, but now basedir tracks it. I believe I can fix this by fixing the basedir for the d-r-p model.
> 1.7 Causes failures in other plugins make "basedir" point to the build dir
> --------------------------------------------------------------------------
>
> Key: MSHADE-123
> URL: https://jira.codehaus.org/browse/MSHADE-123
> Project: Maven 2.x Shade Plugin
> Issue Type: Bug
> Reporter: Shay Banon
> Assignee: Benson Margulies
> Priority: Blocker
> Attachments: mvn-shade.zip
>
>
> Upgrading the 1.7 causes other plugins to have basedir now pointing to build dir, or something similar. The attached test case shows that with shade plugin 1.5, the assembly plugins successfully finds the sample.txt file (in basedir), while upgrading to 1.7 shade plugin causes the assembly plugin not to find it.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://jira.codehaus.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] (MSHADE-123) 1.7 Causes failures in other plugins make
"basedir" point to the build dir
Posted by "Benson Margulies (JIRA)" <ji...@codehaus.org>.
[ https://jira.codehaus.org/browse/MSHADE-123?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Benson Margulies reassigned MSHADE-123:
---------------------------------------
Assignee: Benson Margulies
> 1.7 Causes failures in other plugins make "basedir" point to the build dir
> --------------------------------------------------------------------------
>
> Key: MSHADE-123
> URL: https://jira.codehaus.org/browse/MSHADE-123
> Project: Maven 2.x Shade Plugin
> Issue Type: Bug
> Reporter: Shay Banon
> Assignee: Benson Margulies
> Priority: Blocker
> Attachments: mvn-shade.zip
>
>
> Upgrading the 1.7 causes other plugins to have basedir now pointing to build dir, or something similar. The attached test case shows that with shade plugin 1.5, the assembly plugins successfully finds the sample.txt file (in basedir), while upgrading to 1.7 shade plugin causes the assembly plugin not to find it.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://jira.codehaus.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] (MSHADE-123) 1.7 Causes failures in other plugins make
"basedir" point to the build dir
Posted by "Shay Banon (JIRA)" <ji...@codehaus.org>.
[ https://jira.codehaus.org/browse/MSHADE-123?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Shay Banon updated MSHADE-123:
------------------------------
Attachment: mvn-shade.zip
Attached the project, simply extract and run, you will see the failure. Change the shade version to 1.5, and it works well.
> 1.7 Causes failures in other plugins make "basedir" point to the build dir
> --------------------------------------------------------------------------
>
> Key: MSHADE-123
> URL: https://jira.codehaus.org/browse/MSHADE-123
> Project: Maven 2.x Shade Plugin
> Issue Type: Bug
> Reporter: Shay Banon
> Priority: Blocker
> Attachments: mvn-shade.zip
>
>
> Upgrading the 1.7 causes other plugins to have basedir now pointing to build dir, or something similar. The attached test case shows that with shade plugin 1.5, the assembly plugins successfully finds the sample.txt file (in basedir), while upgrading to 1.7 shade plugin causes the assembly plugin not to find it.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://jira.codehaus.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] (MSHADE-123) 1.7 Causes failures in other plugins make
"basedir" point to the build dir
Posted by "Benson Margulies (JIRA)" <ji...@codehaus.org>.
[ https://jira.codehaus.org/browse/MSHADE-123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=301766#comment-301766 ]
Benson Margulies commented on MSHADE-123:
-----------------------------------------
Drat. project.getBasedir() returns the parent dir of the pom file, period, alternative.
This seems to require a change to the MavenProject class.
> 1.7 Causes failures in other plugins make "basedir" point to the build dir
> --------------------------------------------------------------------------
>
> Key: MSHADE-123
> URL: https://jira.codehaus.org/browse/MSHADE-123
> Project: Maven 2.x Shade Plugin
> Issue Type: Bug
> Reporter: Shay Banon
> Assignee: Benson Margulies
> Priority: Blocker
> Attachments: mvn-shade.zip
>
>
> Upgrading the 1.7 causes other plugins to have basedir now pointing to build dir, or something similar. The attached test case shows that with shade plugin 1.5, the assembly plugins successfully finds the sample.txt file (in basedir), while upgrading to 1.7 shade plugin causes the assembly plugin not to find it.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://jira.codehaus.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] (MSHADE-123) 1.7 Causes failures in other plugins make
"basedir" point to the build dir
Posted by "Benson Margulies (JIRA)" <ji...@codehaus.org>.
[ https://jira.codehaus.org/browse/MSHADE-123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=301978#comment-301978 ]
Benson Margulies commented on MSHADE-123:
-----------------------------------------
r1354439 | bimargulies | 2012-06-27 07:42:24 -0400 (Wed, 27 Jun 2012) | 3 lines
MSHADE-123: 1.7 Causes failures in other plugins make "basedir" point to the build dir
o forgot to document the situation in the main checkin.
------------------------------------------------------------------------
> 1.7 Causes failures in other plugins make "basedir" point to the build dir
> --------------------------------------------------------------------------
>
> Key: MSHADE-123
> URL: https://jira.codehaus.org/browse/MSHADE-123
> Project: Maven 2.x Shade Plugin
> Issue Type: Bug
> Reporter: Shay Banon
> Assignee: Benson Margulies
> Priority: Blocker
> Fix For: 1.7.1
>
> Attachments: mvn-shade.zip
>
>
> Upgrading the 1.7 causes other plugins to have basedir now pointing to build dir, or something similar. The attached test case shows that with shade plugin 1.5, the assembly plugins successfully finds the sample.txt file (in basedir), while upgrading to 1.7 shade plugin causes the assembly plugin not to find it.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://jira.codehaus.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] (MSHADE-123) 1.7 Causes failures in other plugins make
"basedir" point to the build dir
Posted by "Benson Margulies (JIRA)" <ji...@codehaus.org>.
[ https://jira.codehaus.org/browse/MSHADE-123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=301767#comment-301767 ]
Benson Margulies commented on MSHADE-123:
-----------------------------------------
Workaround: explicitly set the location of the dependency-reduced-pom to be in the basedir instead of in target.
> 1.7 Causes failures in other plugins make "basedir" point to the build dir
> --------------------------------------------------------------------------
>
> Key: MSHADE-123
> URL: https://jira.codehaus.org/browse/MSHADE-123
> Project: Maven 2.x Shade Plugin
> Issue Type: Bug
> Reporter: Shay Banon
> Assignee: Benson Margulies
> Priority: Blocker
> Attachments: mvn-shade.zip
>
>
> Upgrading the 1.7 causes other plugins to have basedir now pointing to build dir, or something similar. The attached test case shows that with shade plugin 1.5, the assembly plugins successfully finds the sample.txt file (in basedir), while upgrading to 1.7 shade plugin causes the assembly plugin not to find it.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://jira.codehaus.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira