You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@opendal.apache.org by "Xuanwo (via GitHub)" <gi...@apache.org> on 2023/12/20 03:52:20 UTC

[PR] fix(ci): Make sure merge_local_staging handles all subdir [incubator-opendal]

Xuanwo opened a new pull request, #3788:
URL: https://github.com/apache/incubator-opendal/pull/3788

   Fix https://github.com/apache/incubator-opendal/issues/3787


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] fix(ci): Make sure merge_local_staging handles all subdir [incubator-opendal]

Posted by "tisonkun (via GitHub)" <gi...@apache.org>.
tisonkun commented on code in PR #3788:
URL: https://github.com/apache/incubator-opendal/pull/3788#discussion_r1432224640


##########
scripts/merge_local_staging.py:
##########
@@ -21,27 +21,36 @@
 import sys
 
 
-def copy_and_append_index(target_directory, dir_path):
-    sub_dir_name = os.path.basename(os.listdir(dir_path)[0])
-    sub_dir_path = os.path.join(dir_path, sub_dir_name)
+def copy_and_append_index(target_directory, staging_directory):

Review Comment:
   > too complex to understand
   
   For example,
   
   1. check dir or file multiple times, why?
   2. manually concat filename, distinguish files and dirs. I'm afraid that it's brittle and doesn't work better than a bash script.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] fix(ci): Make sure merge_local_staging handles all subdir [incubator-opendal]

Posted by "tisonkun (via GitHub)" <gi...@apache.org>.
tisonkun commented on PR #3788:
URL: https://github.com/apache/incubator-opendal/pull/3788#issuecomment-1863837658

   > Tested locally with linux x86_64 & aarch artifacts:
   
   Can you download the uploaded artifacts (linux, macos, window) and test the script on those artifacts?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] fix(ci): Make sure merge_local_staging handles all subdir [incubator-opendal]

Posted by "tisonkun (via GitHub)" <gi...@apache.org>.
tisonkun commented on code in PR #3788:
URL: https://github.com/apache/incubator-opendal/pull/3788#discussion_r1432225847


##########
scripts/merge_local_staging.py:
##########
@@ -21,27 +21,36 @@
 import sys
 
 
-def copy_and_append_index(target_directory, dir_path):
-    sub_dir_name = os.path.basename(os.listdir(dir_path)[0])
-    sub_dir_path = os.path.join(dir_path, sub_dir_name)
+def copy_and_append_index(target_directory, staging_directory):

Review Comment:
   A Pythonic way is using `pathlib` and logging each mutations.
   
   Use `os` is almost the same as a bash script.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] fix(ci): Make sure merge_local_staging handles all subdir [incubator-opendal]

Posted by "Xuanwo (via GitHub)" <gi...@apache.org>.
Xuanwo commented on code in PR #3788:
URL: https://github.com/apache/incubator-opendal/pull/3788#discussion_r1432224038


##########
scripts/merge_local_staging.py:
##########
@@ -51,6 +58,8 @@ def copy_and_append_index(target_directory, dir_path):
 target_directory = sys.argv[1]
 
 # Loop through each provided directory argument
-for i in range(2, len(sys.argv)):
-    dir_path = sys.argv[i]
+for dir_path in sys.argv[2:]:
+    if not os.path.isdir(dir_path):
+        print(f"Warning: {dir_path} is not a valid directory. Skipping.")

Review Comment:
   Addressed.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] fix(ci): Make sure merge_local_staging handles all subdir [incubator-opendal]

Posted by "Xuanwo (via GitHub)" <gi...@apache.org>.
Xuanwo commented on PR #3788:
URL: https://github.com/apache/incubator-opendal/pull/3788#issuecomment-1863837419

   By the way, the scripts in main works the same. So this PR might not address the problem entirely.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] fix(ci): Make sure merge_local_staging handles all subdir [incubator-opendal]

Posted by "tisonkun (via GitHub)" <gi...@apache.org>.
tisonkun commented on code in PR #3788:
URL: https://github.com/apache/incubator-opendal/pull/3788#discussion_r1432225847


##########
scripts/merge_local_staging.py:
##########
@@ -21,27 +21,36 @@
 import sys
 
 
-def copy_and_append_index(target_directory, dir_path):
-    sub_dir_name = os.path.basename(os.listdir(dir_path)[0])
-    sub_dir_path = os.path.join(dir_path, sub_dir_name)
+def copy_and_append_index(target_directory, staging_directory):

Review Comment:
   A Pythonic way is using `pathlib` and logging each mutations (also the status after mutation perhaps in DEBUG level).
   
   Use `os` is almost the same as a bash script.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] fix(ci): Make sure merge_local_staging handles all subdir [incubator-opendal]

Posted by "tisonkun (via GitHub)" <gi...@apache.org>.
tisonkun commented on PR #3788:
URL: https://github.com/apache/incubator-opendal/pull/3788#issuecomment-1863828991

   > May you test it by dry run?
   
   I ever test the original script by download the final artifacts.
   
   The workflow file already have a `${{ github.event_name != 'pull_request' }}` in deploy step but missing a upload artifact for debugging.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] fix(ci): Make sure merge_local_staging handles all subdir [incubator-opendal]

Posted by "tisonkun (via GitHub)" <gi...@apache.org>.
tisonkun commented on code in PR #3788:
URL: https://github.com/apache/incubator-opendal/pull/3788#discussion_r1432256502


##########
.github/workflows/release_java.yml:
##########
@@ -168,6 +168,10 @@ jobs:
             ~/osx-x86_64-local-staging/staging \
             ~/osx-aarch_64-local-staging/staging
 
+          tree -a $LOCAL_STAGING_DIR/staging
+

Review Comment:
   nit: make it part of the Python script, perhaps a debug function and called at last.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] fix(ci): Make sure merge_local_staging handles all subdir [incubator-opendal]

Posted by "tisonkun (via GitHub)" <gi...@apache.org>.
tisonkun commented on code in PR #3788:
URL: https://github.com/apache/incubator-opendal/pull/3788#discussion_r1432223346


##########
scripts/merge_local_staging.py:
##########
@@ -51,6 +58,8 @@ def copy_and_append_index(target_directory, dir_path):
 target_directory = sys.argv[1]
 
 # Loop through each provided directory argument
-for i in range(2, len(sys.argv)):
-    dir_path = sys.argv[i]
+for dir_path in sys.argv[2:]:
+    if not os.path.isdir(dir_path):
+        print(f"Warning: {dir_path} is not a valid directory. Skipping.")

Review Comment:
   We always pass dir. We should panic if the argument is not a dir.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] fix(ci): Make sure merge_local_staging handles all subdir [incubator-opendal]

Posted by "tisonkun (via GitHub)" <gi...@apache.org>.
tisonkun commented on PR #3788:
URL: https://github.com/apache/incubator-opendal/pull/3788#issuecomment-1863825001

   In another perspective, the PR description doesn't tell why the preview script doesn't convey all the variants. I guess it's some override rather than append logic. But it's not easy to reverse engineer the patch to understand.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] fix(ci): Make sure merge_local_staging handles all subdir [incubator-opendal]

Posted by "Xuanwo (via GitHub)" <gi...@apache.org>.
Xuanwo commented on code in PR #3788:
URL: https://github.com/apache/incubator-opendal/pull/3788#discussion_r1432237080


##########
scripts/merge_local_staging.py:
##########
@@ -21,27 +21,36 @@
 import sys
 
 
-def copy_and_append_index(target_directory, dir_path):
-    sub_dir_name = os.path.basename(os.listdir(dir_path)[0])
-    sub_dir_path = os.path.join(dir_path, sub_dir_name)
+def copy_and_append_index(target_directory, staging_directory):

Review Comment:
   Refactored



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] fix(ci): Make sure merge_local_staging handles all subdir [incubator-opendal]

Posted by "Xuanwo (via GitHub)" <gi...@apache.org>.
Xuanwo commented on PR #3788:
URL: https://github.com/apache/incubator-opendal/pull/3788#issuecomment-1863835860

   Tested locally with linux x86_64 & aarch artifacts:
   
   ```shell
   > python ./merge_local_staging.py ./staging /tmp/linux-aarch_64-local-staging/staging /tmp/linux-x86_64-local-staging/staging
   Target directory set to staging
   Processing /tmp/linux-aarch_64-local-staging/staging
   Appending /tmp/linux-aarch_64-local-staging/staging/16a16cf8585f60/.index to staging/16a16cf8585f60/.index
   Copying /tmp/linux-aarch_64-local-staging/staging/16a16cf8585f60/org to staging/16a16cf8585f60
   Processing /tmp/linux-x86_64-local-staging/staging
   Appending /tmp/linux-x86_64-local-staging/staging/16a16cf8585f60/.index to staging/16a16cf8585f60/.index
   Copying /tmp/linux-x86_64-local-staging/staging/16a16cf8585f60/org to staging/16a16cf8585f60
   ```
   
   ![image](https://github.com/apache/incubator-opendal/assets/5351546/1fc834d7-9b59-4d52-b7bb-d3d4468e2c77)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] fix(ci): Make sure merge_local_staging handles all subdir [incubator-opendal]

Posted by "Xuanwo (via GitHub)" <gi...@apache.org>.
Xuanwo commented on PR #3788:
URL: https://github.com/apache/incubator-opendal/pull/3788#issuecomment-1863837882

   > Can you download the uploaded artifacts (linux, macos, window) and test the script on those artifacts?
   
   Yep. I test it in this way.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] fix(ci): Make sure merge_local_staging handles all subdir [incubator-opendal]

Posted by "Xuanwo (via GitHub)" <gi...@apache.org>.
Xuanwo commented on PR #3788:
URL: https://github.com/apache/incubator-opendal/pull/3788#issuecomment-1863836674

   Also added tree command to check if we merged correctly.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] fix(ci): Make sure merge_local_staging handles all subdir [incubator-opendal]

Posted by "Xuanwo (via GitHub)" <gi...@apache.org>.
Xuanwo merged PR #3788:
URL: https://github.com/apache/incubator-opendal/pull/3788


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] fix(ci): Make sure merge_local_staging handles all subdir [incubator-opendal]

Posted by "Xuanwo (via GitHub)" <gi...@apache.org>.
Xuanwo commented on code in PR #3788:
URL: https://github.com/apache/incubator-opendal/pull/3788#discussion_r1432263308


##########
.github/workflows/release_java.yml:
##########
@@ -168,6 +168,10 @@ jobs:
             ~/osx-x86_64-local-staging/staging \
             ~/osx-aarch_64-local-staging/staging
 
+          tree -a $LOCAL_STAGING_DIR/staging
+

Review Comment:
   Addressed



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] fix(ci): Make sure merge_local_staging handles all subdir [incubator-opendal]

Posted by "tisonkun (via GitHub)" <gi...@apache.org>.
tisonkun commented on code in PR #3788:
URL: https://github.com/apache/incubator-opendal/pull/3788#discussion_r1432224241


##########
scripts/merge_local_staging.py:
##########
@@ -21,27 +21,36 @@
 import sys
 
 
-def copy_and_append_index(target_directory, dir_path):
-    sub_dir_name = os.path.basename(os.listdir(dir_path)[0])
-    sub_dir_path = os.path.join(dir_path, sub_dir_name)
+def copy_and_append_index(target_directory, staging_directory):

Review Comment:
   This script is too complex to understand. Either
   
   1. Write comments and print message, add a method doc string to describe what it does.
   2. Revert to the Netty script. I think it can handle a new staging variant and we actually need not to modify it.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] fix(ci): Make sure merge_local_staging handles all subdir [incubator-opendal]

Posted by "tisonkun (via GitHub)" <gi...@apache.org>.
tisonkun commented on code in PR #3788:
URL: https://github.com/apache/incubator-opendal/pull/3788#discussion_r1432224640


##########
scripts/merge_local_staging.py:
##########
@@ -21,27 +21,36 @@
 import sys
 
 
-def copy_and_append_index(target_directory, dir_path):
-    sub_dir_name = os.path.basename(os.listdir(dir_path)[0])
-    sub_dir_path = os.path.join(dir_path, sub_dir_name)
+def copy_and_append_index(target_directory, staging_directory):

Review Comment:
   > too complex to understand
   
   For example,
   
   1. check dir or file multiple times, why?
   2. manually concat filename, distinguish files and dirs on copying. I'm afraid that it's brittle and doesn't work better than a bash script.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] fix(ci): Make sure merge_local_staging handles all subdir [incubator-opendal]

Posted by "Xuanwo (via GitHub)" <gi...@apache.org>.
Xuanwo commented on PR #3788:
URL: https://github.com/apache/incubator-opendal/pull/3788#issuecomment-1863844190

   Tested on all artifacts downloaded from: https://github.com/apache/incubator-opendal/actions/runs/7046140331
   
   ```shell
   :( python ./merge_local_staging.py ./staging /tmp/linux-aarch_64-local-staging/staging /tmp/linux-x86_64-local-staging/staging /tmp/windows-x86_64-local-staging/staging /tmp/osx-aarch_64-local-staging/staging /tmp/osx-x86_64-local-staging/staging 
   Target directory set to staging
   Processing /tmp/linux-aarch_64-local-staging/staging
   Appending /tmp/linux-aarch_64-local-staging/staging/16a16cf8585f60/.index to staging/16a16cf8585f60/.index
   Copying /tmp/linux-aarch_64-local-staging/staging/16a16cf8585f60/org to staging/16a16cf8585f60
   Processing /tmp/linux-x86_64-local-staging/staging
   Appending /tmp/linux-x86_64-local-staging/staging/16a16cf8585f60/.index to staging/16a16cf8585f60/.index
   Copying /tmp/linux-x86_64-local-staging/staging/16a16cf8585f60/org to staging/16a16cf8585f60
   Processing /tmp/windows-x86_64-local-staging/staging
   Appending /tmp/windows-x86_64-local-staging/staging/16a16cf8585f60/.index to staging/16a16cf8585f60/.index
   Copying /tmp/windows-x86_64-local-staging/staging/16a16cf8585f60/org to staging/16a16cf8585f60
   Processing /tmp/osx-aarch_64-local-staging/staging
   Appending /tmp/osx-aarch_64-local-staging/staging/16a16cf8585f60/.index to staging/16a16cf8585f60/.index
   Copying /tmp/osx-aarch_64-local-staging/staging/16a16cf8585f60/org to staging/16a16cf8585f60
   Processing /tmp/osx-x86_64-local-staging/staging
   Appending /tmp/osx-x86_64-local-staging/staging/16a16cf8585f60/.index to staging/16a16cf8585f60/.index
   Copying /tmp/osx-x86_64-local-staging/staging/16a16cf8585f60/org to staging/16a16cf8585f60
   ```
   
   index file:
   
   ```shell
   org/apache/opendal/opendal-java/0.43.0/opendal-java-0.43.0.jar=org.apache.opendal:opendal-java:0.43.0:n/a:jar:jar:opendal-java-0.43.0.pom:n/a:n/a:n/a
   org/apache/opendal/opendal-java/0.43.0/opendal-java-0.43.0-source-release.zip=org.apache.opendal:opendal-java:0.43.0:source-release:zip:zip:n/a:n/a:n/a:n/a
   org/apache/opendal/opendal-java/0.43.0/opendal-java-0.43.0-sources.jar=org.apache.opendal:opendal-java:0.43.0:sources:java-source:jar:n/a:n/a:n/a:n/a
   org/apache/opendal/opendal-java/0.43.0/opendal-java-0.43.0-javadoc.jar=org.apache.opendal:opendal-java:0.43.0:javadoc:javadoc:jar:n/a:n/a:n/a:n/a
   org/apache/opendal/opendal-java/0.43.0/opendal-java-0.43.0-linux-aarch_64.jar=org.apache.opendal:opendal-java:0.43.0:linux-aarch_64:jar:jar:n/a:n/a:n/a:n/a
   org/apache/opendal/opendal-java/0.43.0/opendal-java-0.43.0-source-release.zip.sha512=org.apache.opendal:opendal-java:0.43.0:source-release:zip.sha512:zip.sha512:n/a:n/a:n/a:n/a
   org/apache/opendal/opendal-java/0.43.0/opendal-java-0.43.0.jar.asc=org.apache.opendal:opendal-java:0.43.0:n/a:jar.asc:jar.asc:n/a:n/a:n/a:n/a
   org/apache/opendal/opendal-java/0.43.0/opendal-java-0.43.0.pom.asc=org.apache.opendal:opendal-java:0.43.0:n/a:pom.asc:pom.asc:n/a:n/a:n/a:n/a
   org/apache/opendal/opendal-java/0.43.0/opendal-java-0.43.0-source-release.zip.asc=org.apache.opendal:opendal-java:0.43.0:source-release:zip.asc:zip.asc:n/a:n/a:n/a:n/a
   org/apache/opendal/opendal-java/0.43.0/opendal-java-0.43.0-sources.jar.asc=org.apache.opendal:opendal-java:0.43.0:sources:jar.asc:jar.asc:n/a:n/a:n/a:n/a
   org/apache/opendal/opendal-java/0.43.0/opendal-java-0.43.0-javadoc.jar.asc=org.apache.opendal:opendal-java:0.43.0:javadoc:jar.asc:jar.asc:n/a:n/a:n/a:n/a
   org/apache/opendal/opendal-java/0.43.0/opendal-java-0.43.0-linux-aarch_64.jar.asc=org.apache.opendal:opendal-java:0.43.0:linux-aarch_64:jar.asc:jar.asc:n/a:n/a:n/a:n/a
   org/apache/opendal/opendal-java/0.43.0/opendal-java-0.43.0.jar=org.apache.opendal:opendal-java:0.43.0:n/a:jar:jar:opendal-java-0.43.0.pom:n/a:n/a:n/a
   org/apache/opendal/opendal-java/0.43.0/opendal-java-0.43.0-source-release.zip=org.apache.opendal:opendal-java:0.43.0:source-release:zip:zip:n/a:n/a:n/a:n/a
   org/apache/opendal/opendal-java/0.43.0/opendal-java-0.43.0-sources.jar=org.apache.opendal:opendal-java:0.43.0:sources:java-source:jar:n/a:n/a:n/a:n/a
   org/apache/opendal/opendal-java/0.43.0/opendal-java-0.43.0-javadoc.jar=org.apache.opendal:opendal-java:0.43.0:javadoc:javadoc:jar:n/a:n/a:n/a:n/a
   org/apache/opendal/opendal-java/0.43.0/opendal-java-0.43.0-linux-x86_64.jar=org.apache.opendal:opendal-java:0.43.0:linux-x86_64:jar:jar:n/a:n/a:n/a:n/a
   org/apache/opendal/opendal-java/0.43.0/opendal-java-0.43.0-source-release.zip.sha512=org.apache.opendal:opendal-java:0.43.0:source-release:zip.sha512:zip.sha512:n/a:n/a:n/a:n/a
   org/apache/opendal/opendal-java/0.43.0/opendal-java-0.43.0.jar.asc=org.apache.opendal:opendal-java:0.43.0:n/a:jar.asc:jar.asc:n/a:n/a:n/a:n/a
   org/apache/opendal/opendal-java/0.43.0/opendal-java-0.43.0.pom.asc=org.apache.opendal:opendal-java:0.43.0:n/a:pom.asc:pom.asc:n/a:n/a:n/a:n/a
   org/apache/opendal/opendal-java/0.43.0/opendal-java-0.43.0-source-release.zip.asc=org.apache.opendal:opendal-java:0.43.0:source-release:zip.asc:zip.asc:n/a:n/a:n/a:n/a
   org/apache/opendal/opendal-java/0.43.0/opendal-java-0.43.0-sources.jar.asc=org.apache.opendal:opendal-java:0.43.0:sources:jar.asc:jar.asc:n/a:n/a:n/a:n/a
   org/apache/opendal/opendal-java/0.43.0/opendal-java-0.43.0-javadoc.jar.asc=org.apache.opendal:opendal-java:0.43.0:javadoc:jar.asc:jar.asc:n/a:n/a:n/a:n/a
   org/apache/opendal/opendal-java/0.43.0/opendal-java-0.43.0-linux-x86_64.jar.asc=org.apache.opendal:opendal-java:0.43.0:linux-x86_64:jar.asc:jar.asc:n/a:n/a:n/a:n/a
   org/apache/opendal/opendal-java/0.43.0/opendal-java-0.43.0.jar=org.apache.opendal:opendal-java:0.43.0:n/a:jar:jar:opendal-java-0.43.0.pom:n/a:n/a:n/a
   org/apache/opendal/opendal-java/0.43.0/opendal-java-0.43.0-source-release.zip=org.apache.opendal:opendal-java:0.43.0:source-release:zip:zip:n/a:n/a:n/a:n/a
   org/apache/opendal/opendal-java/0.43.0/opendal-java-0.43.0-sources.jar=org.apache.opendal:opendal-java:0.43.0:sources:java-source:jar:n/a:n/a:n/a:n/a
   org/apache/opendal/opendal-java/0.43.0/opendal-java-0.43.0-javadoc.jar=org.apache.opendal:opendal-java:0.43.0:javadoc:javadoc:jar:n/a:n/a:n/a:n/a
   org/apache/opendal/opendal-java/0.43.0/opendal-java-0.43.0-windows-x86_64.jar=org.apache.opendal:opendal-java:0.43.0:windows-x86_64:jar:jar:n/a:n/a:n/a:n/a
   org/apache/opendal/opendal-java/0.43.0/opendal-java-0.43.0-source-release.zip.sha512=org.apache.opendal:opendal-java:0.43.0:source-release:zip.sha512:zip.sha512:n/a:n/a:n/a:n/a
   org/apache/opendal/opendal-java/0.43.0/opendal-java-0.43.0.jar.asc=org.apache.opendal:opendal-java:0.43.0:n/a:jar.asc:jar.asc:n/a:n/a:n/a:n/a
   org/apache/opendal/opendal-java/0.43.0/opendal-java-0.43.0.pom.asc=org.apache.opendal:opendal-java:0.43.0:n/a:pom.asc:pom.asc:n/a:n/a:n/a:n/a
   org/apache/opendal/opendal-java/0.43.0/opendal-java-0.43.0-source-release.zip.asc=org.apache.opendal:opendal-java:0.43.0:source-release:zip.asc:zip.asc:n/a:n/a:n/a:n/a
   org/apache/opendal/opendal-java/0.43.0/opendal-java-0.43.0-sources.jar.asc=org.apache.opendal:opendal-java:0.43.0:sources:jar.asc:jar.asc:n/a:n/a:n/a:n/a
   org/apache/opendal/opendal-java/0.43.0/opendal-java-0.43.0-javadoc.jar.asc=org.apache.opendal:opendal-java:0.43.0:javadoc:jar.asc:jar.asc:n/a:n/a:n/a:n/a
   org/apache/opendal/opendal-java/0.43.0/opendal-java-0.43.0-windows-x86_64.jar.asc=org.apache.opendal:opendal-java:0.43.0:windows-x86_64:jar.asc:jar.asc:n/a:n/a:n/a:n/a
   org/apache/opendal/opendal-java/0.43.0/opendal-java-0.43.0.jar=org.apache.opendal:opendal-java:0.43.0:n/a:jar:jar:opendal-java-0.43.0.pom:n/a:n/a:n/a
   org/apache/opendal/opendal-java/0.43.0/opendal-java-0.43.0-source-release.zip=org.apache.opendal:opendal-java:0.43.0:source-release:zip:zip:n/a:n/a:n/a:n/a
   org/apache/opendal/opendal-java/0.43.0/opendal-java-0.43.0-sources.jar=org.apache.opendal:opendal-java:0.43.0:sources:java-source:jar:n/a:n/a:n/a:n/a
   org/apache/opendal/opendal-java/0.43.0/opendal-java-0.43.0-javadoc.jar=org.apache.opendal:opendal-java:0.43.0:javadoc:javadoc:jar:n/a:n/a:n/a:n/a
   org/apache/opendal/opendal-java/0.43.0/opendal-java-0.43.0-osx-aarch_64.jar=org.apache.opendal:opendal-java:0.43.0:osx-aarch_64:jar:jar:n/a:n/a:n/a:n/a
   org/apache/opendal/opendal-java/0.43.0/opendal-java-0.43.0-source-release.zip.sha512=org.apache.opendal:opendal-java:0.43.0:source-release:zip.sha512:zip.sha512:n/a:n/a:n/a:n/a
   org/apache/opendal/opendal-java/0.43.0/opendal-java-0.43.0.jar.asc=org.apache.opendal:opendal-java:0.43.0:n/a:jar.asc:jar.asc:n/a:n/a:n/a:n/a
   org/apache/opendal/opendal-java/0.43.0/opendal-java-0.43.0.pom.asc=org.apache.opendal:opendal-java:0.43.0:n/a:pom.asc:pom.asc:n/a:n/a:n/a:n/a
   org/apache/opendal/opendal-java/0.43.0/opendal-java-0.43.0-source-release.zip.asc=org.apache.opendal:opendal-java:0.43.0:source-release:zip.asc:zip.asc:n/a:n/a:n/a:n/a
   org/apache/opendal/opendal-java/0.43.0/opendal-java-0.43.0-sources.jar.asc=org.apache.opendal:opendal-java:0.43.0:sources:jar.asc:jar.asc:n/a:n/a:n/a:n/a
   org/apache/opendal/opendal-java/0.43.0/opendal-java-0.43.0-javadoc.jar.asc=org.apache.opendal:opendal-java:0.43.0:javadoc:jar.asc:jar.asc:n/a:n/a:n/a:n/a
   org/apache/opendal/opendal-java/0.43.0/opendal-java-0.43.0-osx-aarch_64.jar.asc=org.apache.opendal:opendal-java:0.43.0:osx-aarch_64:jar.asc:jar.asc:n/a:n/a:n/a:n/a
   org/apache/opendal/opendal-java/0.43.0/opendal-java-0.43.0.jar=org.apache.opendal:opendal-java:0.43.0:n/a:jar:jar:opendal-java-0.43.0.pom:n/a:n/a:n/a
   org/apache/opendal/opendal-java/0.43.0/opendal-java-0.43.0-source-release.zip=org.apache.opendal:opendal-java:0.43.0:source-release:zip:zip:n/a:n/a:n/a:n/a
   org/apache/opendal/opendal-java/0.43.0/opendal-java-0.43.0-sources.jar=org.apache.opendal:opendal-java:0.43.0:sources:java-source:jar:n/a:n/a:n/a:n/a
   org/apache/opendal/opendal-java/0.43.0/opendal-java-0.43.0-javadoc.jar=org.apache.opendal:opendal-java:0.43.0:javadoc:javadoc:jar:n/a:n/a:n/a:n/a
   org/apache/opendal/opendal-java/0.43.0/opendal-java-0.43.0-osx-x86_64.jar=org.apache.opendal:opendal-java:0.43.0:osx-x86_64:jar:jar:n/a:n/a:n/a:n/a
   org/apache/opendal/opendal-java/0.43.0/opendal-java-0.43.0-source-release.zip.sha512=org.apache.opendal:opendal-java:0.43.0:source-release:zip.sha512:zip.sha512:n/a:n/a:n/a:n/a
   org/apache/opendal/opendal-java/0.43.0/opendal-java-0.43.0.jar.asc=org.apache.opendal:opendal-java:0.43.0:n/a:jar.asc:jar.asc:n/a:n/a:n/a:n/a
   org/apache/opendal/opendal-java/0.43.0/opendal-java-0.43.0.pom.asc=org.apache.opendal:opendal-java:0.43.0:n/a:pom.asc:pom.asc:n/a:n/a:n/a:n/a
   org/apache/opendal/opendal-java/0.43.0/opendal-java-0.43.0-source-release.zip.asc=org.apache.opendal:opendal-java:0.43.0:source-release:zip.asc:zip.asc:n/a:n/a:n/a:n/a
   org/apache/opendal/opendal-java/0.43.0/opendal-java-0.43.0-sources.jar.asc=org.apache.opendal:opendal-java:0.43.0:sources:jar.asc:jar.asc:n/a:n/a:n/a:n/a
   org/apache/opendal/opendal-java/0.43.0/opendal-java-0.43.0-javadoc.jar.asc=org.apache.opendal:opendal-java:0.43.0:javadoc:jar.asc:jar.asc:n/a:n/a:n/a:n/a
   org/apache/opendal/opendal-java/0.43.0/opendal-java-0.43.0-osx-x86_64.jar.asc=org.apache.opendal:opendal-java:0.43.0:osx-x86_64:jar.asc:jar.asc:n/a:n/a:n/a:n/a
   ```
   
   file tree:
   
   ```shell
   ./staging
   └── 16a16cf8585f60
       ├── .index
       └── org
           └── apache
               └── opendal
                   └── opendal-java
                       ├── 0.43.0
                       │   ├── opendal-java-0.43.0.jar
                       │   ├── opendal-java-0.43.0.jar.asc
                       │   ├── opendal-java-0.43.0-javadoc.jar
                       │   ├── opendal-java-0.43.0-javadoc.jar.asc
                       │   ├── opendal-java-0.43.0-linux-aarch_64.jar
                       │   ├── opendal-java-0.43.0-linux-aarch_64.jar.asc
                       │   ├── opendal-java-0.43.0-linux-x86_64.jar
                       │   ├── opendal-java-0.43.0-linux-x86_64.jar.asc
                       │   ├── opendal-java-0.43.0-osx-aarch_64.jar
                       │   ├── opendal-java-0.43.0-osx-aarch_64.jar.asc
                       │   ├── opendal-java-0.43.0-osx-x86_64.jar
                       │   ├── opendal-java-0.43.0-osx-x86_64.jar.asc
                       │   ├── opendal-java-0.43.0.pom
                       │   ├── opendal-java-0.43.0.pom.asc
                       │   ├── opendal-java-0.43.0-source-release.zip
                       │   ├── opendal-java-0.43.0-source-release.zip.asc
                       │   ├── opendal-java-0.43.0-source-release.zip.sha512
                       │   ├── opendal-java-0.43.0-sources.jar
                       │   ├── opendal-java-0.43.0-sources.jar.asc
                       │   ├── opendal-java-0.43.0-windows-x86_64.jar
                       │   └── opendal-java-0.43.0-windows-x86_64.jar.asc
                       └── maven-metadata-nexus.xml
   
   7 directories, 23 files
   ```
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] fix(ci): Make sure merge_local_staging handles all subdir [incubator-opendal]

Posted by "tisonkun (via GitHub)" <gi...@apache.org>.
tisonkun commented on PR #3788:
URL: https://github.com/apache/incubator-opendal/pull/3788#issuecomment-1863838313

   @Xuanwo but you test only for linux aarch64 and x8664. Let's try for what exactly the script does to avoid some subtle issue.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] fix(ci): Make sure merge_local_staging handles all subdir [incubator-opendal]

Posted by "suyanhanx (via GitHub)" <gi...@apache.org>.
suyanhanx commented on PR #3788:
URL: https://github.com/apache/incubator-opendal/pull/3788#issuecomment-1863827881

   😦May you test it by dry run?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org