You are viewing a plain text version of this content. The canonical link for it is here.
Posted to cvs@httpd.apache.org by bn...@apache.org on 2007/10/30 16:46:07 UTC
svn commit: r590122 - /httpd/httpd/trunk/include/scoreboard.h
Author: bnicholes
Date: Tue Oct 30 08:46:06 2007
New Revision: 590122
URL: http://svn.apache.org/viewvc?rev=590122&view=rev
Log:
The function ap_time_process_request() needs to be declared appropriately if it is going to be used externally (now being called by mod_echo)
Modified:
httpd/httpd/trunk/include/scoreboard.h
Modified: httpd/httpd/trunk/include/scoreboard.h
URL: http://svn.apache.org/viewvc/httpd/httpd/trunk/include/scoreboard.h?rev=590122&r1=590121&r2=590122&view=diff
==============================================================================
--- httpd/httpd/trunk/include/scoreboard.h (original)
+++ httpd/httpd/trunk/include/scoreboard.h Tue Oct 30 08:46:06 2007
@@ -176,7 +176,7 @@
AP_DECLARE(int) ap_update_child_status(ap_sb_handle_t *sbh, int status, request_rec *r);
AP_DECLARE(int) ap_update_child_status_from_indexes(int child_num, int thread_num,
int status, request_rec *r);
-void ap_time_process_request(ap_sb_handle_t *sbh, int status);
+AP_DECLARE(void) ap_time_process_request(ap_sb_handle_t *sbh, int status);
AP_DECLARE(worker_score *) ap_get_scoreboard_worker(ap_sb_handle_t *sbh);
AP_DECLARE(worker_score *) ap_get_scoreboard_worker_from_indexes(int child_num,
Re: svn commit: r590122 - /httpd/httpd/trunk/include/scoreboard.h
Posted by "William A. Rowe, Jr." <wr...@rowe-clan.net>.
FYI - mod_echo illustrated that there's value in recording info by connection
into the scoreboard, as opposed to only by request.
We could just as easily move scoreboard-update-by-conn into scoreboard.c - which
would we rather do?
Bill
bnicholes@apache.org wrote:
> Author: bnicholes
> Date: Tue Oct 30 08:46:06 2007
> New Revision: 590122
>
> URL: http://svn.apache.org/viewvc?rev=590122&view=rev
> Log:
> The function ap_time_process_request() needs to be declared appropriately if it is going to be used externally (now being called by mod_echo)
>
> Modified:
> httpd/httpd/trunk/include/scoreboard.h
>
> Modified: httpd/httpd/trunk/include/scoreboard.h
> URL: http://svn.apache.org/viewvc/httpd/httpd/trunk/include/scoreboard.h?rev=590122&r1=590121&r2=590122&view=diff
> ==============================================================================
> --- httpd/httpd/trunk/include/scoreboard.h (original)
> +++ httpd/httpd/trunk/include/scoreboard.h Tue Oct 30 08:46:06 2007
> @@ -176,7 +176,7 @@
> AP_DECLARE(int) ap_update_child_status(ap_sb_handle_t *sbh, int status, request_rec *r);
> AP_DECLARE(int) ap_update_child_status_from_indexes(int child_num, int thread_num,
> int status, request_rec *r);
> -void ap_time_process_request(ap_sb_handle_t *sbh, int status);
> +AP_DECLARE(void) ap_time_process_request(ap_sb_handle_t *sbh, int status);
>
> AP_DECLARE(worker_score *) ap_get_scoreboard_worker(ap_sb_handle_t *sbh);
> AP_DECLARE(worker_score *) ap_get_scoreboard_worker_from_indexes(int child_num,
>
>
>
>
Re: svn commit: r590122 - /httpd/httpd/trunk/include/scoreboard.h
Posted by Ruediger Pluem <rp...@apache.org>.
On 10/30/2007 04:46 PM, bnicholes@apache.org wrote:
> Author: bnicholes
> Date: Tue Oct 30 08:46:06 2007
> New Revision: 590122
>
> URL: http://svn.apache.org/viewvc?rev=590122&view=rev
> Log:
> The function ap_time_process_request() needs to be declared appropriately if it is going to be used externally (now being called by mod_echo)
>
> Modified:
> httpd/httpd/trunk/include/scoreboard.h
>
> Modified: httpd/httpd/trunk/include/scoreboard.h
> URL: http://svn.apache.org/viewvc/httpd/httpd/trunk/include/scoreboard.h?rev=590122&r1=590121&r2=590122&view=diff
> ==============================================================================
> --- httpd/httpd/trunk/include/scoreboard.h (original)
> +++ httpd/httpd/trunk/include/scoreboard.h Tue Oct 30 08:46:06 2007
> @@ -176,7 +176,7 @@
> AP_DECLARE(int) ap_update_child_status(ap_sb_handle_t *sbh, int status, request_rec *r);
> AP_DECLARE(int) ap_update_child_status_from_indexes(int child_num, int thread_num,
> int status, request_rec *r);
> -void ap_time_process_request(ap_sb_handle_t *sbh, int status);
> +AP_DECLARE(void) ap_time_process_request(ap_sb_handle_t *sbh, int status);
Doesn't this require some sort of bump (minor / major) since scoreboard.h is public?
Regards
Rüdiger