You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Diana Arroyo <da...@us.ibm.com> on 2015/12/08 23:13:14 UTC
Review Request 41104: Addes some additional missing source files and
put the source files in proper order
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41104/
-----------------------------------------------------------
Review request for mesos, Artem Harutyunyan, Alex Clemmer, Joris Van Remoortere, and Joseph Wu.
Bugs: MESOS-3843
https://issues.apache.org/jira/browse/MESOS-3843
Repository: mesos
Description
-------
Addes some additional missing source files and put the source files in proper order
Diffs
-----
src/CMakeLists.txt c0d77c745eb5b12dd6d9d7afaba7e820f8d848ef
Diff: https://reviews.apache.org/r/41104/diff/
Testing
-------
Tested on Ubuntu and OSX.
Thanks,
Diana Arroyo
Re: Review Request 41104: Addes some additional missing source files
and put the source files in proper order
Posted by Joseph Wu <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41104/#review109447
-----------------------------------------------------------
src/CMakeLists.txt (line 120)
<https://reviews.apache.org/r/41104/#comment168979>
This one should be separate from the `LINUX_SRC`. i.e. OSX is posix, but not linux.
- Joseph Wu
On Dec. 8, 2015, 2:13 p.m., Diana Arroyo wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41104/
> -----------------------------------------------------------
>
> (Updated Dec. 8, 2015, 2:13 p.m.)
>
>
> Review request for mesos, Artem Harutyunyan, Alex Clemmer, Joris Van Remoortere, and Joseph Wu.
>
>
> Bugs: MESOS-3843
> https://issues.apache.org/jira/browse/MESOS-3843
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Addes some additional missing source files and put the source files in proper order
>
>
> Diffs
> -----
>
> src/CMakeLists.txt c0d77c745eb5b12dd6d9d7afaba7e820f8d848ef
>
> Diff: https://reviews.apache.org/r/41104/diff/
>
>
> Testing
> -------
>
> Tested on Ubuntu and OSX.
>
>
> Thanks,
>
> Diana Arroyo
>
>
Re: Review Request 41104: Addes some additional missing source files
and put the source files in proper order
Posted by Alex Clemmer <cl...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41104/#review109564
-----------------------------------------------------------
src/CMakeLists.txt (line 248)
<https://reviews.apache.org/r/41104/#comment169136>
Per our conversation and #40951, I think it makes sense that we keep this `MESOS_SRC` and move it to be with the other definitions of `MESOS_SRC`.
- Alex Clemmer
On Dec. 8, 2015, 10:13 p.m., Diana Arroyo wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41104/
> -----------------------------------------------------------
>
> (Updated Dec. 8, 2015, 10:13 p.m.)
>
>
> Review request for mesos, Artem Harutyunyan, Alex Clemmer, Joris Van Remoortere, and Joseph Wu.
>
>
> Bugs: MESOS-3843
> https://issues.apache.org/jira/browse/MESOS-3843
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Addes some additional missing source files and put the source files in proper order
>
>
> Diffs
> -----
>
> src/CMakeLists.txt c0d77c745eb5b12dd6d9d7afaba7e820f8d848ef
>
> Diff: https://reviews.apache.org/r/41104/diff/
>
>
> Testing
> -------
>
> Tested on Ubuntu and OSX.
>
>
> Thanks,
>
> Diana Arroyo
>
>