[GitHub] [cloudstack] svenvogel opened a new pull request #3346: Fix template size for managed storage / refactor cloud-install-sys-tmplt and createtmplt.sh

[GitBox <gi...@apache.org>]

svenvogel opened a new pull request #3346: Fix template size for managed storage / refactor cloud-install-sys-tmplt and createtmplt.sh
URL: https://github.com/apache/cloudstack/pull/3346
 
 
   ## Description
   <!--- Describe your changes in detail -->
   * remove unused old vars and functions e.g. today, chksum...
   * rename createtmplt.sh to createtemplt to unify the files in overall context
   * add function to calculate the virtual size of template for managed storage (netapp solidfire) so that the copy process is working from NFS to iSCSI correctly
   * refactor cloud-install-sys-tmplt creates all settings of template.properties
   * refactor createtmplt shall create only the templates e.g. uncompress and install ...
   
   <!-- For new features, provide link to FS, dev ML discussion etc. -->
   <!-- In case of bug fix, the expected and actual behaviours, steps to reproduce. -->
   
   <!-- When "Fixes: #<id>" is specified, the issue/PR will automatically be closed when this PR gets merged -->
   <!-- For addressing multiple issues/PRs, use multiple "Fixes: #<id>" -->
   <!-- Fixes: # -->
   
   ## Types of changes
   <!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: -->
   - [ ] Breaking change (fix or feature that would cause existing functionality to change)
   - [ ] New feature (non-breaking change which adds functionality)
   - [X] Bug fix (non-breaking change which fixes an issue)
   - [ ] Enhancement (improves an existing feature and functionality)
   - [X] Cleanup (Code refactoring and cleanup, that may add test cases)
   
   ## Screenshots (if appropriate):
   
   ## How Has This Been Tested?
   <!-- Please describe in detail how you tested your changes. -->
   tested manually in our production environment with different files like vhd, qcow2 and ova
   <!-- Include details of your testing environment, and the tests you ran to -->
   
   
   
   <!-- Please read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/master/CONTRIBUTING.md) document -->
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services