You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@helix.apache.org by GitBox <gi...@apache.org> on 2020/12/10 02:35:33 UTC

[GitHub] [helix] pkuwm opened a new pull request #1588: Fix controller pipeline invoking log info

pkuwm opened a new pull request #1588:
URL: https://github.com/apache/helix/pull/1588


   ### Issues
   
   - [ ] My PR addresses the following Helix issues and references them in the PR description:
   
   Fixes #1587 
   
   ### Description
   
   - [ ] Here are some details about my PR, including screenshots of any UI changes:
   
   The log in controller pipeline is incorrect: cluster name and pipeline name is mis-ordered
   
   2020/12/09 00:00:00.003 INFO [GenericHelixController] [HelixController-pipeline-task-(3e8ae1f7)] [helix] [] START: Invoking cluster-name controller pipeline for cluster: TASK. Event type: OnDemandRebalance, ID: 3e8ae1f7. Event session ID: 60057fd565a1196
   
   The cluster is should not be TASK but the real cluster name.
   
   ### Tests
   
   - [ ] The following tests are written for this issue:
   
   (List the names of added unit/integration tests)
   
   - [ ] The following is the result of the "mvn test" command on the appropriate module:
   
   (Before CI test pass, please copy & paste the result of "mvn test")
   
   ### Documentation (Optional)
   
   - In case of new functionality, my PR adds documentation in the following wiki page:
   
   (Link the GitHub wiki you added)
   
   ### Commits
   
   - My commits all reference appropriate Apache Helix GitHub issues in their subject lines. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
     1. Subject is separated from body by a blank line
     1. Subject is limited to 50 characters (not including Jira issue reference)
     1. Subject does not end with a period
     1. Subject uses the imperative mood ("add", not "adding")
     1. Body wraps at 72 characters
     1. Body explains "what" and "why", not "how"
   
   ### Code Quality
   
   - My diff has been formatted using helix-style.xml 
   (helix-style-intellij.xml if IntelliJ IDE is used)
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org

[GitHub] [helix] pkuwm merged pull request #1588: Fix controller pipeline invoking log info

Posted by GitBox <gi...@apache.org>.
pkuwm merged pull request #1588:
URL: https://github.com/apache/helix/pull/1588


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org

[GitHub] [helix] pkuwm commented on pull request #1588: Fix controller pipeline invoking log info

Posted by GitBox <gi...@apache.org>.
pkuwm commented on pull request #1588:
URL: https://github.com/apache/helix/pull/1588#issuecomment-745009246


   This PR is ready to be merged, approved by @dasahcc @jiajunwang @alirezazamani 
   
   The log for invoking pipeline in controller is incorrect: cluster name and pipeline name is mis-ordered. This commit corrects the order.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org

[GitHub] [helix] dasahcc commented on pull request #1588: Fix controller pipeline invoking log info

Posted by GitBox <gi...@apache.org>.
dasahcc commented on pull request #1588:
URL: https://github.com/apache/helix/pull/1588#issuecomment-744881329


   @pkuwm If you are ready, remember to add the final statement. Then merge into master.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org