You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@pig.apache.org by "Olga Natkovich (JIRA)" <ji...@apache.org> on 2009/09/11 21:38:57 UTC
[jira] Created: (PIG-956) Reduce patch testing time
Reduce patch testing time
-------------------------
Key: PIG-956
URL: https://issues.apache.org/jira/browse/PIG-956
Project: Pig
Issue Type: Improvement
Affects Versions: 0.4.0
Reporter: Olga Natkovich
Assignee: Olga Natkovich
Fix For: 0.6.0
The proposal is to split the tests into 2 groups:
(1) Ten-minute tests - this is a set of tests that run with every patch submission and takes aproximately 10 minutes
(2) All tests - these include all tests and they will run nightly
This is similar to work done in Hadoop: http://issues.apache.org/jira/browse/HDFS-458
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (PIG-956) Reduce patch testing time
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12760503#action_12760503 ]
Hadoop QA commented on PIG-956:
-------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12420749/PIG-956.patch
against trunk revision 819691.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 75 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs warnings.
-1 release audit. The applied patch generated 281 release audit warnings (more than the trunk's current 279 warnings).
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results: http://hudson.zones.apache.org/hudson/job/Pig-Patch-h7.grid.sp2.yahoo.net/49/testReport/
Release audit warnings: http://hudson.zones.apache.org/hudson/job/Pig-Patch-h7.grid.sp2.yahoo.net/49/artifact/trunk/patchprocess/releaseAuditDiffWarnings.txt
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Pig-Patch-h7.grid.sp2.yahoo.net/49/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: http://hudson.zones.apache.org/hudson/job/Pig-Patch-h7.grid.sp2.yahoo.net/49/console
This message is automatically generated.
> Reduce patch testing time
> -------------------------
>
> Key: PIG-956
> URL: https://issues.apache.org/jira/browse/PIG-956
> Project: Pig
> Issue Type: Improvement
> Affects Versions: 0.4.0
> Reporter: Olga Natkovich
> Assignee: Olga Natkovich
> Fix For: 0.6.0
>
> Attachments: PIG-956.patch
>
>
> The proposal is to split the tests into 2 groups:
> (1) Ten-minute tests - this is a set of tests that run with every patch submission and takes aproximately 10 minutes
> (2) All tests - these include all tests and they will run nightly
> This is similar to work done in Hadoop: http://issues.apache.org/jira/browse/HDFS-458
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (PIG-956) Reduce patch testing time
Posted by "Olga Natkovich (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12760454#action_12760454 ]
Olga Natkovich commented on PIG-956:
------------------------------------
The test-commit target runs 7-8 minutes and has coverage of 53% (compared to 70% for the entire set of tests)
> Reduce patch testing time
> -------------------------
>
> Key: PIG-956
> URL: https://issues.apache.org/jira/browse/PIG-956
> Project: Pig
> Issue Type: Improvement
> Affects Versions: 0.4.0
> Reporter: Olga Natkovich
> Assignee: Olga Natkovich
> Fix For: 0.6.0
>
> Attachments: PIG-956.patch
>
>
> The proposal is to split the tests into 2 groups:
> (1) Ten-minute tests - this is a set of tests that run with every patch submission and takes aproximately 10 minutes
> (2) All tests - these include all tests and they will run nightly
> This is similar to work done in Hadoop: http://issues.apache.org/jira/browse/HDFS-458
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Issue Comment Edited: (PIG-956) Reduce patch testing time
Posted by "Olga Natkovich (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12754298#action_12754298 ]
Olga Natkovich edited comment on PIG-956 at 9/11/09 12:41 PM:
--------------------------------------------------------------
My plan is to do the following:
(1) Take all the tests that take 5 seconds or less and put them into 10 minute tests
(2) Create a TestCheckin - that runs a few end-to-end tests
(1) + (2) combined will be the Ten-minute test group.
Going forward, any files (this is at the test file level) that take 5 seconds or less can be added to the Ten-minute tests. Also, when any really major feature is added, an end-2-end query can be added or existing one modified in the TestCheckin.
was (Author: olgan):
My plan is to do the following:
(1) Take all the tests that take 5 seconds or less and put them into 10 minute tests
(2) Create a TestCheckin - that runs a few end-to-end tests
(1) + (2) combined will be the Ten-minute test group.
Goint forward, any files (this is at the test file level) that take 5 seconds or less can be added to the Ten-minute tests. Also, when any really major feature is added, an end-2-end query can be added or existing one modified in the TestCheckin.
> Reduce patch testing time
> -------------------------
>
> Key: PIG-956
> URL: https://issues.apache.org/jira/browse/PIG-956
> Project: Pig
> Issue Type: Improvement
> Affects Versions: 0.4.0
> Reporter: Olga Natkovich
> Assignee: Olga Natkovich
> Fix For: 0.6.0
>
>
> The proposal is to split the tests into 2 groups:
> (1) Ten-minute tests - this is a set of tests that run with every patch submission and takes aproximately 10 minutes
> (2) All tests - these include all tests and they will run nightly
> This is similar to work done in Hadoop: http://issues.apache.org/jira/browse/HDFS-458
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (PIG-956) Reduce patch testing time
Posted by "Olga Natkovich (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-956?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Olga Natkovich updated PIG-956:
-------------------------------
Resolution: Fixed
Status: Resolved (was: Patch Available)
patch committed to trunk and branch-0.5
> Reduce patch testing time
> -------------------------
>
> Key: PIG-956
> URL: https://issues.apache.org/jira/browse/PIG-956
> Project: Pig
> Issue Type: Improvement
> Affects Versions: 0.4.0
> Reporter: Olga Natkovich
> Assignee: Olga Natkovich
> Fix For: 0.6.0
>
> Attachments: PIG-956.patch
>
>
> The proposal is to split the tests into 2 groups:
> (1) Ten-minute tests - this is a set of tests that run with every patch submission and takes aproximately 10 minutes
> (2) All tests - these include all tests and they will run nightly
> This is similar to work done in Hadoop: http://issues.apache.org/jira/browse/HDFS-458
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (PIG-956) Reduce patch testing time
Posted by "Olga Natkovich (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-956?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Olga Natkovich updated PIG-956:
-------------------------------
Status: Patch Available (was: Open)
> Reduce patch testing time
> -------------------------
>
> Key: PIG-956
> URL: https://issues.apache.org/jira/browse/PIG-956
> Project: Pig
> Issue Type: Improvement
> Affects Versions: 0.4.0
> Reporter: Olga Natkovich
> Assignee: Olga Natkovich
> Fix For: 0.6.0
>
> Attachments: PIG-956.patch
>
>
> The proposal is to split the tests into 2 groups:
> (1) Ten-minute tests - this is a set of tests that run with every patch submission and takes aproximately 10 minutes
> (2) All tests - these include all tests and they will run nightly
> This is similar to work done in Hadoop: http://issues.apache.org/jira/browse/HDFS-458
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (PIG-956) Reduce patch testing time
Posted by "Daniel Dai (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12760716#action_12760716 ]
Daniel Dai commented on PIG-956:
--------------------------------
Patch looks good. It takes less than 8 min to run test-commit on my machine. For release audit warning, I think it is unnecessarily to add license comments into to a plain text file. +1 for the patch.
> Reduce patch testing time
> -------------------------
>
> Key: PIG-956
> URL: https://issues.apache.org/jira/browse/PIG-956
> Project: Pig
> Issue Type: Improvement
> Affects Versions: 0.4.0
> Reporter: Olga Natkovich
> Assignee: Olga Natkovich
> Fix For: 0.6.0
>
> Attachments: PIG-956.patch
>
>
> The proposal is to split the tests into 2 groups:
> (1) Ten-minute tests - this is a set of tests that run with every patch submission and takes aproximately 10 minutes
> (2) All tests - these include all tests and they will run nightly
> This is similar to work done in Hadoop: http://issues.apache.org/jira/browse/HDFS-458
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (PIG-956) Reduce patch testing time
Posted by "Olga Natkovich (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12760705#action_12760705 ]
Olga Natkovich commented on PIG-956:
------------------------------------
The two warnings are there because of the 2 files that I added to list the tests don't have apache header. I don't think JUnit will allow a header there. I checked that Hadoop does not have the header there.
Once the patch is reviewed, I will commit it to trunk and also to the branch-0.5
> Reduce patch testing time
> -------------------------
>
> Key: PIG-956
> URL: https://issues.apache.org/jira/browse/PIG-956
> Project: Pig
> Issue Type: Improvement
> Affects Versions: 0.4.0
> Reporter: Olga Natkovich
> Assignee: Olga Natkovich
> Fix For: 0.6.0
>
> Attachments: PIG-956.patch
>
>
> The proposal is to split the tests into 2 groups:
> (1) Ten-minute tests - this is a set of tests that run with every patch submission and takes aproximately 10 minutes
> (2) All tests - these include all tests and they will run nightly
> This is similar to work done in Hadoop: http://issues.apache.org/jira/browse/HDFS-458
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (PIG-956) Reduce patch testing time
Posted by "Olga Natkovich (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12754298#action_12754298 ]
Olga Natkovich commented on PIG-956:
------------------------------------
My plan is to do the following:
(1) Take all the tests that take 5 seconds or less and put them into 10 minute tests
(2) Create a TestCheckin - that runs a few end-to-end tests
(1) + (2) combined will be the Ten-minute test group.
Goint forward, any files (this is at the test file level) that take 5 seconds or less can be added to the Ten-minute tests. Also, when any really major feature is added, an end-2-end query can be added or existing one modified in the TestCheckin.
> Reduce patch testing time
> -------------------------
>
> Key: PIG-956
> URL: https://issues.apache.org/jira/browse/PIG-956
> Project: Pig
> Issue Type: Improvement
> Affects Versions: 0.4.0
> Reporter: Olga Natkovich
> Assignee: Olga Natkovich
> Fix For: 0.6.0
>
>
> The proposal is to split the tests into 2 groups:
> (1) Ten-minute tests - this is a set of tests that run with every patch submission and takes aproximately 10 minutes
> (2) All tests - these include all tests and they will run nightly
> This is similar to work done in Hadoop: http://issues.apache.org/jira/browse/HDFS-458
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (PIG-956) Reduce patch testing time
Posted by "Olga Natkovich (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-956?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Olga Natkovich updated PIG-956:
-------------------------------
Attachment: PIG-956.patch
> Reduce patch testing time
> -------------------------
>
> Key: PIG-956
> URL: https://issues.apache.org/jira/browse/PIG-956
> Project: Pig
> Issue Type: Improvement
> Affects Versions: 0.4.0
> Reporter: Olga Natkovich
> Assignee: Olga Natkovich
> Fix For: 0.6.0
>
> Attachments: PIG-956.patch
>
>
> The proposal is to split the tests into 2 groups:
> (1) Ten-minute tests - this is a set of tests that run with every patch submission and takes aproximately 10 minutes
> (2) All tests - these include all tests and they will run nightly
> This is similar to work done in Hadoop: http://issues.apache.org/jira/browse/HDFS-458
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.