[GitHub] [superset] john-bodley commented on a diff in pull request #24009: fix(sqllab): rollback clean comments out

["john-bodley (via GitHub)" <gi...@apache.org>]

john-bodley commented on code in PR #24009:
URL: https://github.com/apache/superset/pull/24009#discussion_r1190209512


##########
superset-frontend/src/SqlLab/components/RunQueryActionButton/index.tsx:
##########
@@ -106,7 +105,9 @@ const RunQueryActionButton = ({
     : Button;
 
   const sqlContent = selectedText || sql || '';
-  const isDisabled = cleanSqlComments(sqlContent).length === 0;
+  const isDisabled =

Review Comment:
   Maybe outside the scope of this PR, but I wonder if we should remove the `isDisable` logic as well. Regex's scare me.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org