You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@falcon.apache.org by Peeyush Bishnoi <bp...@yahoo.co.in> on 2015/11/05 15:50:49 UTC
Re: Review Request 39649: FALCON-1486 : Add Unit Test cases for HiveDR
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39649/
-----------------------------------------------------------
(Updated Nov. 5, 2015, 2:50 p.m.)
Review request for Falcon.
Bugs: FALCON-1486
https://issues.apache.org/jira/browse/FALCON-1486
Repository: falcon-git
Description
-------
FALCON-1486 : Add Unit Test cases for HiveDR
Diffs (updated)
-----
addons/hivedr/pom.xml 8905513
addons/hivedr/src/main/java/org/apache/falcon/hive/HiveDRTool.java c3d9b5c
addons/hivedr/src/main/java/org/apache/falcon/hive/MetaStoreEventSourcer.java 0e12e89
addons/hivedr/src/test/java/org/apache/falcon/hive/HiveDRTest.java PRE-CREATION
pom.xml 87c55e3
Diff: https://reviews.apache.org/r/39649/diff/
Testing
-------
Yes
Thanks,
Peeyush Bishnoi
Re: Review Request 39649: FALCON-1486 : Add Unit Test cases for HiveDR
Posted by Ajay Yadava <aj...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39649/#review106641
-----------------------------------------------------------
+1. LGTM
- Ajay Yadava
On Nov. 16, 2015, 5:46 a.m., Peeyush Bishnoi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39649/
> -----------------------------------------------------------
>
> (Updated Nov. 16, 2015, 5:46 a.m.)
>
>
> Review request for Falcon.
>
>
> Bugs: FALCON-1486
> https://issues.apache.org/jira/browse/FALCON-1486
>
>
> Repository: falcon-git
>
>
> Description
> -------
>
> FALCON-1486 : Add Unit Test cases for HiveDR
>
>
> Diffs
> -----
>
> addons/hivedr/pom.xml c887166
> addons/hivedr/src/main/java/org/apache/falcon/hive/HiveDRTool.java c3d9b5c
> addons/hivedr/src/main/java/org/apache/falcon/hive/MetaStoreEventSourcer.java 0e12e89
> addons/hivedr/src/test/java/org/apache/falcon/hive/HiveDRTest.java PRE-CREATION
> pom.xml 6f2c480
>
> Diff: https://reviews.apache.org/r/39649/diff/
>
>
> Testing
> -------
>
> Yes
>
>
> Thanks,
>
> Peeyush Bishnoi
>
>
Re: Review Request 39649: FALCON-1486 : Add Unit Test cases for HiveDR
Posted by Ajay Yadava <aj...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39649/#review106844
-----------------------------------------------------------
Ship it!
Ship It!
- Ajay Yadava
On Nov. 16, 2015, 5:46 a.m., Peeyush Bishnoi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39649/
> -----------------------------------------------------------
>
> (Updated Nov. 16, 2015, 5:46 a.m.)
>
>
> Review request for Falcon.
>
>
> Bugs: FALCON-1486
> https://issues.apache.org/jira/browse/FALCON-1486
>
>
> Repository: falcon-git
>
>
> Description
> -------
>
> FALCON-1486 : Add Unit Test cases for HiveDR
>
>
> Diffs
> -----
>
> addons/hivedr/pom.xml c887166
> addons/hivedr/src/main/java/org/apache/falcon/hive/HiveDRTool.java c3d9b5c
> addons/hivedr/src/main/java/org/apache/falcon/hive/MetaStoreEventSourcer.java 0e12e89
> addons/hivedr/src/test/java/org/apache/falcon/hive/HiveDRTest.java PRE-CREATION
> pom.xml 6f2c480
>
> Diff: https://reviews.apache.org/r/39649/diff/
>
>
> Testing
> -------
>
> Yes
>
>
> Thanks,
>
> Peeyush Bishnoi
>
>
Re: Review Request 39649: FALCON-1486 : Add Unit Test cases for HiveDR
Posted by Peeyush Bishnoi <bp...@yahoo.co.in>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39649/
-----------------------------------------------------------
(Updated Nov. 16, 2015, 5:46 a.m.)
Review request for Falcon.
Bugs: FALCON-1486
https://issues.apache.org/jira/browse/FALCON-1486
Repository: falcon-git
Description
-------
FALCON-1486 : Add Unit Test cases for HiveDR
Diffs (updated)
-----
addons/hivedr/pom.xml c887166
addons/hivedr/src/main/java/org/apache/falcon/hive/HiveDRTool.java c3d9b5c
addons/hivedr/src/main/java/org/apache/falcon/hive/MetaStoreEventSourcer.java 0e12e89
addons/hivedr/src/test/java/org/apache/falcon/hive/HiveDRTest.java PRE-CREATION
pom.xml 6f2c480
Diff: https://reviews.apache.org/r/39649/diff/
Testing
-------
Yes
Thanks,
Peeyush Bishnoi
Re: Review Request 39649: FALCON-1486 : Add Unit Test cases for HiveDR
Posted by Peeyush Bishnoi <bp...@yahoo.co.in>.
> On Nov. 8, 2015, 9:20 a.m., Ajay Yadava wrote:
> > addons/hivedr/src/main/java/org/apache/falcon/hive/MetaStoreEventSourcer.java, line 152
> > <https://reviews.apache.org/r/39649/diff/2/?file=1116733#file1116733line152>
> >
> > nit: if it is only for tests then may be you can make it protected/package private instead of public. Will that not work?
Fixed.
- Peeyush
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39649/#review105609
-----------------------------------------------------------
On Nov. 5, 2015, 2:50 p.m., Peeyush Bishnoi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39649/
> -----------------------------------------------------------
>
> (Updated Nov. 5, 2015, 2:50 p.m.)
>
>
> Review request for Falcon.
>
>
> Bugs: FALCON-1486
> https://issues.apache.org/jira/browse/FALCON-1486
>
>
> Repository: falcon-git
>
>
> Description
> -------
>
> FALCON-1486 : Add Unit Test cases for HiveDR
>
>
> Diffs
> -----
>
> addons/hivedr/pom.xml 8905513
> addons/hivedr/src/main/java/org/apache/falcon/hive/HiveDRTool.java c3d9b5c
> addons/hivedr/src/main/java/org/apache/falcon/hive/MetaStoreEventSourcer.java 0e12e89
> addons/hivedr/src/test/java/org/apache/falcon/hive/HiveDRTest.java PRE-CREATION
> pom.xml 87c55e3
>
> Diff: https://reviews.apache.org/r/39649/diff/
>
>
> Testing
> -------
>
> Yes
>
>
> Thanks,
>
> Peeyush Bishnoi
>
>
Re: Review Request 39649: FALCON-1486 : Add Unit Test cases for HiveDR
Posted by Ajay Yadava <aj...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39649/#review105609
-----------------------------------------------------------
addons/hivedr/src/main/java/org/apache/falcon/hive/MetaStoreEventSourcer.java (line 148)
<https://reviews.apache.org/r/39649/#comment164237>
nit: if it is only for tests then may be you can make it protected/package private instead of public. Will that not work?
- Ajay Yadava
On Nov. 5, 2015, 2:50 p.m., Peeyush Bishnoi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39649/
> -----------------------------------------------------------
>
> (Updated Nov. 5, 2015, 2:50 p.m.)
>
>
> Review request for Falcon.
>
>
> Bugs: FALCON-1486
> https://issues.apache.org/jira/browse/FALCON-1486
>
>
> Repository: falcon-git
>
>
> Description
> -------
>
> FALCON-1486 : Add Unit Test cases for HiveDR
>
>
> Diffs
> -----
>
> addons/hivedr/pom.xml 8905513
> addons/hivedr/src/main/java/org/apache/falcon/hive/HiveDRTool.java c3d9b5c
> addons/hivedr/src/main/java/org/apache/falcon/hive/MetaStoreEventSourcer.java 0e12e89
> addons/hivedr/src/test/java/org/apache/falcon/hive/HiveDRTest.java PRE-CREATION
> pom.xml 87c55e3
>
> Diff: https://reviews.apache.org/r/39649/diff/
>
>
> Testing
> -------
>
> Yes
>
>
> Thanks,
>
> Peeyush Bishnoi
>
>