You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@orc.apache.org by Gang Wu <us...@gmail.com> on 2023/02/06 03:25:26 UTC

Re: Patch for proleptic calendar adjustment in C++

Hi Brian,

Just want to check in to see if you still have the plan?

Please let us know if you need anything from the community.

Best,
Gang

On Thu, Jan 12, 2023 at 10:20 AM Gang Wu <us...@gmail.com> wrote:

> Hi Brian,
>
> Proleptic calendar is a missing feature of the C++ library.
>
> Please open a JIRA ticket and submit the PR and I am glad to review it
> once the PR is ready.
>
> Thanks,
> Gang
>
> On Thu, Jan 12, 2023 at 9:47 AM Dongjoon Hyun <do...@gmail.com>
> wrote:
>
>> Please make a PR first because it depends on the code part your PR aims to
>> change.
>> In general, you can ping the authors of code around the changed part.
>>
>> Thanks,
>> Dongjoon.
>>
>>
>> On Wed, Jan 11, 2023 at 11:49 AM Brian Hulette <bh...@apache.org>
>> wrote:
>>
>> > Hello, I'm Brian Hulette, this is my first time writing to dev@orc, but
>> > I've contributed to both Arrow and Beam in the past. I recently worked
>> on a
>> > patch to add proleptic calendar timestamp/date conversion (like this
>> [1])
>> > to the C++ reader. I'd like to upstream the patch, is that something the
>> > community would be interested in? If so, who would be a good person to
>> > review?
>> >
>> > Thanks!
>> > Brian
>> >
>> > [1] https://github.com/apache/orc/pull/455
>> >
>>
>