[GitHub] [lucene] uschindler commented on a change in pull request #643: LUCENE-10400: revise constructors to load dictionary resources in kuromoji

[GitBox <gi...@apache.org>]

uschindler commented on a change in pull request #643:
URL: https://github.com/apache/lucene/pull/643#discussion_r799317558



##########
File path: lucene/analysis/kuromoji/src/java/org/apache/lucene/analysis/ja/dict/ConnectionCosts.java
##########
@@ -61,8 +68,63 @@ public ConnectionCosts(BinaryDictionary.ResourceScheme scheme, String path) thro
     }
   }
 
+  /**
+   * Create a {@link ConnectionCosts} from an external resource path.
+   *
+   * @param resourceLocation where to load resources from
+   * @throws IOException
+   */
+  public ConnectionCosts(String resourceLocation) throws IOException {

Review comment:
       This should take `Path`as Parameter, no String. According to Robert, `Paths.get()` should be put on forbidden list, as it makes testing with custom path impls impossible.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org