You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by "chungen0126 (via GitHub)" <gi...@apache.org> on 2026/10/22 09:58:05 UTC
[PR] HDDS-17305. Fix wrong default in description of ozone.scm.ha.ratis.leader.election.timeout [ozone]
chungen0126 opened a new pull request, #11690:
URL: https://github.com/apache/ozone/pull/11690
## What changes were proposed in this pull request?
The description of `ozone.scm.ha.ratis.leader.election.timeout` in `ozone-default.xml` says "Default is 1s", but the configured value is `5s` and `ScmConfigKeys.OZONE_SCM_HA_RATIS_LEADER_ELECTION_TIMEOUT_DEFAULT` is `5 * 1000L`. The text has been wrong since HDDS-5054.
This PR:
- Corrects the default in the description to 5s.
- Documents how the value is used: `RatisUtil#setRaftRpcProperties` sets it as `raft.server.rpc.timeout.min` of SCM's Ratis server, and sets `raft.server.rpc.timeout.max` to this value plus 200ms.
This is a documentation-only change; runtime behavior is unchanged.
## What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-17305
## How was this patch tested?
Documentation-only change.
- Validated `ozone-default.xml` with `xmllint --noout`.
- Verified the Ratis key names against `RaftServerConfigKeys.Rpc` in Ratis 3.2.1 and the +200ms offset against `RatisUtil#setRaftRpcProperties`.
- CI on fork: https://github.com/chungen0126/ozone/actions/runs/39748112166
Generated-by: Claude Code (Claude Opus 5.5)
🤖 Generated with [Claude Code](https://claude.com/claude-code)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-17305. Fix wrong default in description of ozone.scm.ha.ratis.leader.election.timeout [ozone]
Posted by "adoroszlai (via GitHub)" <gi...@apache.org>.
adoroszlai commented on PR #11690:
URL: https://github.com/apache/ozone/pull/11690#issuecomment-6349083425
Thanks @chungen0126 for the patch, @chihsuan, @peterxcli for the review.
Note: `[skip ci]` will make CI also skip updating the website with this change (`build`, `generate-config-doc`, `update-ozone-site-config-doc` are needed for that). The next full build will pick it up.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-17305. Fix wrong default in description of ozone.scm.ha.ratis.leader.election.timeout [ozone]
Posted by "adoroszlai (via GitHub)" <gi...@apache.org>.
adoroszlai merged PR #11690:
URL: https://github.com/apache/ozone/pull/11690
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-17305. Fix wrong default in description of ozone.scm.ha.ratis.leader.election.timeout [ozone]
Posted by "chungen0126 (via GitHub)" <gi...@apache.org>.
chungen0126 commented on PR #11690:
URL: https://github.com/apache/ozone/pull/11690#issuecomment-6347241808
> Unfortunately there is no easy way to distinguish between "documentation-only" change vs. functional change in `ozone-default.xml`. I propose adding `[skip ci]` in the commit message for future pull requests like this to avoid 2 x 1.5 hours of CI time per wall-clock (much more in real usage due to concurrency).
>
> What do you think?
Makes sense, let's do that! The CI has definitely been a bit overloaded.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-17305. Fix wrong default in description of ozone.scm.ha.ratis.leader.election.timeout [ozone]
Posted by "adoroszlai (via GitHub)" <gi...@apache.org>.
adoroszlai commented on PR #11690:
URL: https://github.com/apache/ozone/pull/11690#issuecomment-6346994605
Unfortunately there is no easy way to distinguish between "documentation-only" change vs. functional change in `ozone-default.xml`. I propose adding `[skip ci]` in the commit message for future pull requests like this to avoid 2 x 1.5 hours of CI time per wall-clock (much more in real usage due to concurrency).
What do you think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org