[GitHub] [activemq-artemis] wy96f opened a new pull request #2693: ARTEMIS-2368 Fix races on closing consumer

[GitBox <gi...@apache.org>]

wy96f opened a new pull request #2693: ARTEMIS-2368 Fix races on closing consumer
URL: https://github.com/apache/activemq-artemis/pull/2693
 
 
   There are some race conditions between closing consumer and session failover:
   1. When sending SessionConsumerCloseMessage timeout, conn::fail() is called resulting in current consumer is recreated on server side again but removed on client side.
   
   2. Between  SessionConsumerCloseMessage sending and session::removeConsume(), session failover happens resulting in consumer inconsistency.
   
   3. When an iteration over the consumers entrySet is made to recreate consumer during session failover process, consumer::close() is called, maybe leading to consumer inconsistency or ConcurrentModificationException thrown.
   
   We traverse through the cloned consumers entrySet, add synchronized block and check if consumer is closed while recreating consumer to fix the issue.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services