You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@ofbiz.apache.org by ja...@apache.org on 2009/11/19 17:06:44 UTC
svn commit: r882187 -
/ofbiz/trunk/framework/service/src/org/ofbiz/service/ModelServiceReader.java
Author: jacopoc
Date: Thu Nov 19 16:06:43 2009
New Revision: 882187
URL: http://svn.apache.org/viewvc?rev=882187&view=rev
Log:
Added two new IN parameter, internally (and automatically) set for service definitions:
login.username
login.password
They are already used by the authorization service ("userLogin") to authorize the user to the service call and to retrieve the userLogin object (if the user is authorized).
They can be passed to the service in the input context in place of the userLogin object: this is useful when the service is invoked from a remote system (thru SOAP etc...).
Modified:
ofbiz/trunk/framework/service/src/org/ofbiz/service/ModelServiceReader.java
Modified: ofbiz/trunk/framework/service/src/org/ofbiz/service/ModelServiceReader.java
URL: http://svn.apache.org/viewvc/ofbiz/trunk/framework/service/src/org/ofbiz/service/ModelServiceReader.java?rev=882187&r1=882186&r2=882187&view=diff
==============================================================================
--- ofbiz/trunk/framework/service/src/org/ofbiz/service/ModelServiceReader.java (original)
+++ ofbiz/trunk/framework/service/src/org/ofbiz/service/ModelServiceReader.java Thu Nov 19 16:06:43 2009
@@ -642,6 +642,22 @@
def.optional = true;
def.internal = true;
service.addParam(def);
+ // login.username
+ def = new ModelParam();
+ def.name = "login.username";
+ def.type = "String";
+ def.mode = "IN";
+ def.optional = true;
+ def.internal = true;
+ service.addParam(def);
+ // login.password
+ def = new ModelParam();
+ def.name = "login.password";
+ def.type = "String";
+ def.mode = "IN";
+ def.optional = true;
+ def.internal = true;
+ service.addParam(def);
// Locale
def = new ModelParam();
def.name = "locale";
Re: svn commit: r882187 - /ofbiz/trunk/framework/service/src/org/ofbiz/service/ModelServiceReader.java
Posted by Jacopo Cappellato <ja...@hotwaxmedia.com>.
Bilgin,
I've committed a better version of my work in rev. 883056
Let me know if you find other issues, this one should be working fine.
Jacopo
On Nov 21, 2009, at 8:29 AM, Jacopo Cappellato wrote:
> Thanks Bilgin: I have reverted it in rev. 882836
> I will investigate more and find a better solution. Sorry for the issue.
>
> Jacopo
>
> On Nov 21, 2009, at 12:47 AM, Bilgin Ibryam wrote:
>
>> Hi Jacopo,
>>
>> this change cause error in services which require auth.
>> For example, when I try to create a FixedAsset, I get the following error: You must be logged in to complete the [Accounting component base permission logic] process.
>>
>> Bilgin
>>
>>
>>
>> jacopoc@apache.org wrote:
>>> Author: jacopoc
>>> Date: Thu Nov 19 16:06:43 2009
>>> New Revision: 882187
>>>
>>> URL: http://svn.apache.org/viewvc?rev=882187&view=rev
>>> Log:
>>> Added two new IN parameter, internally (and automatically) set for service definitions:
>>> login.username
>>> login.password
>>> They are already used by the authorization service ("userLogin") to authorize the user to the service call and to retrieve the userLogin object (if the user is authorized).
>>> They can be passed to the service in the input context in place of the userLogin object: this is useful when the service is invoked from a remote system (thru SOAP etc...).
>>>
>>> Modified:
>>> ofbiz/trunk/framework/service/src/org/ofbiz/service/ModelServiceReader.java
>>>
>>> Modified: ofbiz/trunk/framework/service/src/org/ofbiz/service/ModelServiceReader.java
>>> URL: http://svn.apache.org/viewvc/ofbiz/trunk/framework/service/src/org/ofbiz/service/ModelServiceReader.java?rev=882187&r1=882186&r2=882187&view=diff
>>> ==============================================================================
>>> --- ofbiz/trunk/framework/service/src/org/ofbiz/service/ModelServiceReader.java (original)
>>> +++ ofbiz/trunk/framework/service/src/org/ofbiz/service/ModelServiceReader.java Thu Nov 19 16:06:43 2009
>>> @@ -642,6 +642,22 @@
>>> def.optional = true;
>>> def.internal = true;
>>> service.addParam(def);
>>> + // login.username
>>> + def = new ModelParam();
>>> + def.name = "login.username";
>>> + def.type = "String";
>>> + def.mode = "IN";
>>> + def.optional = true;
>>> + def.internal = true;
>>> + service.addParam(def);
>>> + // login.password
>>> + def = new ModelParam();
>>> + def.name = "login.password";
>>> + def.type = "String";
>>> + def.mode = "IN";
>>> + def.optional = true;
>>> + def.internal = true;
>>> + service.addParam(def);
>>> // Locale
>>> def = new ModelParam();
>>> def.name = "locale";
>>>
>>>
>>>
>>
>
Re: svn commit: r882187 - /ofbiz/trunk/framework/service/src/org/ofbiz/service/ModelServiceReader.java
Posted by Jacopo Cappellato <ja...@hotwaxmedia.com>.
Thanks Bilgin: I have reverted it in rev. 882836
I will investigate more and find a better solution. Sorry for the issue.
Jacopo
On Nov 21, 2009, at 12:47 AM, Bilgin Ibryam wrote:
> Hi Jacopo,
>
> this change cause error in services which require auth.
> For example, when I try to create a FixedAsset, I get the following error: You must be logged in to complete the [Accounting component base permission logic] process.
>
> Bilgin
>
>
>
> jacopoc@apache.org wrote:
>> Author: jacopoc
>> Date: Thu Nov 19 16:06:43 2009
>> New Revision: 882187
>>
>> URL: http://svn.apache.org/viewvc?rev=882187&view=rev
>> Log:
>> Added two new IN parameter, internally (and automatically) set for service definitions:
>> login.username
>> login.password
>> They are already used by the authorization service ("userLogin") to authorize the user to the service call and to retrieve the userLogin object (if the user is authorized).
>> They can be passed to the service in the input context in place of the userLogin object: this is useful when the service is invoked from a remote system (thru SOAP etc...).
>>
>> Modified:
>> ofbiz/trunk/framework/service/src/org/ofbiz/service/ModelServiceReader.java
>>
>> Modified: ofbiz/trunk/framework/service/src/org/ofbiz/service/ModelServiceReader.java
>> URL: http://svn.apache.org/viewvc/ofbiz/trunk/framework/service/src/org/ofbiz/service/ModelServiceReader.java?rev=882187&r1=882186&r2=882187&view=diff
>> ==============================================================================
>> --- ofbiz/trunk/framework/service/src/org/ofbiz/service/ModelServiceReader.java (original)
>> +++ ofbiz/trunk/framework/service/src/org/ofbiz/service/ModelServiceReader.java Thu Nov 19 16:06:43 2009
>> @@ -642,6 +642,22 @@
>> def.optional = true;
>> def.internal = true;
>> service.addParam(def);
>> + // login.username
>> + def = new ModelParam();
>> + def.name = "login.username";
>> + def.type = "String";
>> + def.mode = "IN";
>> + def.optional = true;
>> + def.internal = true;
>> + service.addParam(def);
>> + // login.password
>> + def = new ModelParam();
>> + def.name = "login.password";
>> + def.type = "String";
>> + def.mode = "IN";
>> + def.optional = true;
>> + def.internal = true;
>> + service.addParam(def);
>> // Locale
>> def = new ModelParam();
>> def.name = "locale";
>>
>>
>>
>
Re: svn commit: r882187 - /ofbiz/trunk/framework/service/src/org/ofbiz/service/ModelServiceReader.java
Posted by Bilgin Ibryam <bi...@gmail.com>.
Hi Jacopo,
this change cause error in services which require auth.
For example, when I try to create a FixedAsset, I get the following
error: You must be logged in to complete the [Accounting component base
permission logic] process.
Bilgin
jacopoc@apache.org wrote:
> Author: jacopoc
> Date: Thu Nov 19 16:06:43 2009
> New Revision: 882187
>
> URL: http://svn.apache.org/viewvc?rev=882187&view=rev
> Log:
> Added two new IN parameter, internally (and automatically) set for service definitions:
> login.username
> login.password
> They are already used by the authorization service ("userLogin") to authorize the user to the service call and to retrieve the userLogin object (if the user is authorized).
> They can be passed to the service in the input context in place of the userLogin object: this is useful when the service is invoked from a remote system (thru SOAP etc...).
>
> Modified:
> ofbiz/trunk/framework/service/src/org/ofbiz/service/ModelServiceReader.java
>
> Modified: ofbiz/trunk/framework/service/src/org/ofbiz/service/ModelServiceReader.java
> URL: http://svn.apache.org/viewvc/ofbiz/trunk/framework/service/src/org/ofbiz/service/ModelServiceReader.java?rev=882187&r1=882186&r2=882187&view=diff
> ==============================================================================
> --- ofbiz/trunk/framework/service/src/org/ofbiz/service/ModelServiceReader.java (original)
> +++ ofbiz/trunk/framework/service/src/org/ofbiz/service/ModelServiceReader.java Thu Nov 19 16:06:43 2009
> @@ -642,6 +642,22 @@
> def.optional = true;
> def.internal = true;
> service.addParam(def);
> + // login.username
> + def = new ModelParam();
> + def.name = "login.username";
> + def.type = "String";
> + def.mode = "IN";
> + def.optional = true;
> + def.internal = true;
> + service.addParam(def);
> + // login.password
> + def = new ModelParam();
> + def.name = "login.password";
> + def.type = "String";
> + def.mode = "IN";
> + def.optional = true;
> + def.internal = true;
> + service.addParam(def);
> // Locale
> def = new ModelParam();
> def.name = "locale";
>
>
>