You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by David Forsythe <df...@gmail.com> on 2016/12/11 04:00:48 UTC
Review Request 54636: Added LOCAL_IP to disk_full_framework_test.sh.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54636/
-----------------------------------------------------------
Review request for mesos and Ian Downes.
Bugs: 6614
https://issues.apache.org/jira/browse/6614
Repository: mesos
Description
-------
Added LOCAL_IP to disk_full_framework_test.sh.
Diffs
-----
src/tests/disk_full_framework_test.sh 83ae0947d4f5ec0a960e8cefa925cacbe6c6808e
Diff: https://reviews.apache.org/r/54636/diff/
Testing
-------
gmake check. Test still fails, but it no longer hangs when given the correct addr.
Thanks,
David Forsythe
Re: Review Request 54636: Added LOCAL_IP to
disk_full_framework_test.sh.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54636/#review158798
-----------------------------------------------------------
Patch looks great!
Reviews applied: [54636]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh
- Mesos ReviewBot
On Dec. 11, 2016, 4 a.m., David Forsythe wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54636/
> -----------------------------------------------------------
>
> (Updated Dec. 11, 2016, 4 a.m.)
>
>
> Review request for mesos and Ian Downes.
>
>
> Bugs: 6614
> https://issues.apache.org/jira/browse/6614
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added LOCAL_IP to disk_full_framework_test.sh.
>
>
> Diffs
> -----
>
> src/tests/disk_full_framework_test.sh 83ae0947d4f5ec0a960e8cefa925cacbe6c6808e
>
> Diff: https://reviews.apache.org/r/54636/diff/
>
>
> Testing
> -------
>
> gmake check. Test still fails, but it no longer hangs when given the correct addr.
>
>
> Thanks,
>
> David Forsythe
>
>
Re: Review Request 54636: Added LOCAL_IP to
disk_full_framework_test.sh.
Posted by Joris Van Remoortere <jo...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54636/#review167520
-----------------------------------------------------------
Closing this review due to inactivity. Please see our [guidelines](https://github.com/apache/mesos/blob/master/docs/reopening-reviews.md) for reopening reviews.
- Joris Van Remoortere
On Dec. 11, 2016, 4 a.m., David Forsythe wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54636/
> -----------------------------------------------------------
>
> (Updated Dec. 11, 2016, 4 a.m.)
>
>
> Review request for mesos and Ian Downes.
>
>
> Bugs: 6614
> https://issues.apache.org/jira/browse/6614
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added LOCAL_IP to disk_full_framework_test.sh.
>
>
> Diffs
> -----
>
> src/tests/disk_full_framework_test.sh 83ae0947d4f5ec0a960e8cefa925cacbe6c6808e
>
>
> Diff: https://reviews.apache.org/r/54636/diff/1/
>
>
> Testing
> -------
>
> gmake check. Test still fails, but it no longer hangs when given the correct addr.
>
>
> Thanks,
>
> David Forsythe
>
>