You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/05/13 06:41:31 UTC

[GitHub] [pulsar] cbornet opened a new pull request, #15240: Fix UserConfigFunction example

cbornet opened a new pull request, #15240:
URL: https://github.com/apache/pulsar/pull/15240

   ### Motivation
   UserConfigFunction example is incorrect as calling `get()` on an empty Optional will raise an exception. Also the result of `get()` will never be null so it's useless to check nullity.
   
   ### Modifications
   
   trivial
   
   ### Verifying this change
   
   - [x] Make sure that the change passes the CI checks.
   
   This change is a trivial rework / code cleanup without any test coverage.
   
   ### Does this pull request potentially affect one of the following parts:
   
   no
   
   *If `yes` was chosen, please highlight the changes*
   
     - Dependencies (does it add or upgrade a dependency): (yes / no)
     - The public API: (yes / no)
     - The schema: (yes / no / don't know)
     - The default values of configurations: (yes / no)
     - The wire protocol: (yes / no)
     - The rest endpoints: (yes / no)
     - The admin cli options: (yes / no)
     - Anything that affects deployment: (yes / no / don't know)
   
   ### Documentation
   
   Check the box below or label this PR directly.
   
   Need to update docs? 
   
   - [ ] `doc-required` 
   (Your PR needs to update docs and you will update later)
     
   - [x] `no-need-doc` 
   (Please explain why)
     
   - [ ] `doc` 
   (Your PR contains doc changes)
   
   - [ ] `doc-added`
   (Docs have been already added)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] HQebupt commented on pull request #15240: Fix UserConfigFunction example

Posted by GitBox <gi...@apache.org>.
HQebupt commented on PR #15240:
URL: https://github.com/apache/pulsar/pull/15240#issuecomment-1105069634

   LGTM


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] nicoloboschi merged pull request #15240: [fix][function] Fix UserConfigFunction example

Posted by GitBox <gi...@apache.org>.
nicoloboschi merged PR #15240:
URL: https://github.com/apache/pulsar/pull/15240


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] eolivelli commented on pull request #15240: Fix UserConfigFunction example

Posted by GitBox <gi...@apache.org>.
eolivelli commented on PR #15240:
URL: https://github.com/apache/pulsar/pull/15240#issuecomment-1131684757

   /pulsarbot rerun-failure-checks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] cbornet commented on pull request #15240: Fix UserConfigFunction example

Posted by GitBox <gi...@apache.org>.
cbornet commented on PR #15240:
URL: https://github.com/apache/pulsar/pull/15240#issuecomment-1124993367

   /pulsarbot rerun-failure-checks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] eolivelli closed pull request #15240: Fix UserConfigFunction example

Posted by GitBox <gi...@apache.org>.
eolivelli closed pull request #15240: Fix UserConfigFunction example
URL: https://github.com/apache/pulsar/pull/15240


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] cbornet closed pull request #15240: [fix][function] Fix UserConfigFunction example

Posted by GitBox <gi...@apache.org>.
cbornet closed pull request #15240: [fix][function] Fix UserConfigFunction example
URL: https://github.com/apache/pulsar/pull/15240


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] cbornet commented on pull request #15240: Fix UserConfigFunction example

Posted by GitBox <gi...@apache.org>.
cbornet commented on PR #15240:
URL: https://github.com/apache/pulsar/pull/15240#issuecomment-1131489294

   /pulsarbot rerun-failure-checks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] cbornet commented on pull request #15240: Fix UserConfigFunction example

Posted by GitBox <gi...@apache.org>.
cbornet commented on PR #15240:
URL: https://github.com/apache/pulsar/pull/15240#issuecomment-1124982106

   /pulsarbot rerun-failure-checks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org