You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@impala.apache.org by tm...@apache.org on 2018/10/05 21:39:17 UTC
[5/8] impala git commit: IMPALA-7667:
sentry.db.explicit.grants.permitted does not accept empty value
IMPALA-7667: sentry.db.explicit.grants.permitted does not accept empty value
Empty value in sentry.db.explicit.grants.permitted means allow all
privileges to be explicitly granted. However a bug in SENTRY-2424
causes empty value to be ignored. The patch uses a workaround to add
a space to mean the same thing as an empty value. The patch also
upgrades CDH_BUILD_NUMBER to 618371 to enable
sentry.db.explicit.grants.permitted configuration.
Testing:
- Ran all core tests
Change-Id: Iddcb80da6ba37405ce59e2d5cd79916f8eb004ec
Reviewed-on: http://gerrit.cloudera.org:8080/11592
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
Project: http://git-wip-us.apache.org/repos/asf/impala/repo
Commit: http://git-wip-us.apache.org/repos/asf/impala/commit/1914a8b5
Tree: http://git-wip-us.apache.org/repos/asf/impala/tree/1914a8b5
Diff: http://git-wip-us.apache.org/repos/asf/impala/diff/1914a8b5
Branch: refs/heads/master
Commit: 1914a8b5557e835cdf67161af1d12f883dbf25d1
Parents: 3a37c72
Author: Fredy Wijaya <fw...@cloudera.com>
Authored: Thu Oct 4 20:53:53 2018 -0700
Committer: Impala Public Jenkins <im...@cloudera.com>
Committed: Fri Oct 5 19:07:23 2018 +0000
----------------------------------------------------------------------
bin/impala-config.sh | 2 +-
fe/src/test/resources/sentry-site.xml.template | 6 +++---
fe/src/test/resources/sentry-site_no_oo.xml.template | 4 ++--
fe/src/test/resources/sentry-site_oo.xml.template | 4 ++--
fe/src/test/resources/sentry-site_oo_nogrant.xml.template | 4 ++--
5 files changed, 10 insertions(+), 10 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/impala/blob/1914a8b5/bin/impala-config.sh
----------------------------------------------------------------------
diff --git a/bin/impala-config.sh b/bin/impala-config.sh
index b9bfb7d..02e2eeb 100755
--- a/bin/impala-config.sh
+++ b/bin/impala-config.sh
@@ -158,7 +158,7 @@ fi
: ${CDH_DOWNLOAD_HOST:=native-toolchain.s3.amazonaws.com}
export CDH_DOWNLOAD_HOST
export CDH_MAJOR_VERSION=6
-export CDH_BUILD_NUMBER=559250
+export CDH_BUILD_NUMBER=618371
export IMPALA_HADOOP_VERSION=3.0.0-cdh6.x-SNAPSHOT
export IMPALA_HBASE_VERSION=2.1.0-cdh6.x-SNAPSHOT
export IMPALA_HIVE_VERSION=2.1.1-cdh6.x-SNAPSHOT
http://git-wip-us.apache.org/repos/asf/impala/blob/1914a8b5/fe/src/test/resources/sentry-site.xml.template
----------------------------------------------------------------------
diff --git a/fe/src/test/resources/sentry-site.xml.template b/fe/src/test/resources/sentry-site.xml.template
index 60b0da9..597a130 100644
--- a/fe/src/test/resources/sentry-site.xml.template
+++ b/fe/src/test/resources/sentry-site.xml.template
@@ -73,9 +73,9 @@
<name>sentry.store.jdbc.driver</name>
<value>org.postgresql.Driver</value>
</property>
-<!-- Empty means allow all privileges -->
+<!-- Use a space to mean allow all privileges. See SENTRY-2424 -->
<property>
-<name>sentry.db.explicit.grants.permitted</name>
-<value></value>
+ <name>sentry.db.explicit.grants.permitted</name>
+ <value> </value>
</property>
</configuration>
http://git-wip-us.apache.org/repos/asf/impala/blob/1914a8b5/fe/src/test/resources/sentry-site_no_oo.xml.template
----------------------------------------------------------------------
diff --git a/fe/src/test/resources/sentry-site_no_oo.xml.template b/fe/src/test/resources/sentry-site_no_oo.xml.template
index 1dbce81..cfebc9a 100644
--- a/fe/src/test/resources/sentry-site_no_oo.xml.template
+++ b/fe/src/test/resources/sentry-site_no_oo.xml.template
@@ -91,10 +91,10 @@
<name>sentry.hive.testing.mode</name>
<value>true</value>
</property>
- <!-- Empty means allow all privileges -->
+ <!-- Use a space to mean allow all privileges. See SENTRY-2424 -->
<property>
<name>sentry.db.explicit.grants.permitted</name>
- <value></value>
+ <value> </value>
</property>
<!-- Custom group mapping for custom cluster tests -->
<property>
http://git-wip-us.apache.org/repos/asf/impala/blob/1914a8b5/fe/src/test/resources/sentry-site_oo.xml.template
----------------------------------------------------------------------
diff --git a/fe/src/test/resources/sentry-site_oo.xml.template b/fe/src/test/resources/sentry-site_oo.xml.template
index d125933..3cd1b80 100644
--- a/fe/src/test/resources/sentry-site_oo.xml.template
+++ b/fe/src/test/resources/sentry-site_oo.xml.template
@@ -91,10 +91,10 @@
<name>sentry.hive.testing.mode</name>
<value>true</value>
</property>
- <!-- Empty means allow all privileges -->
+ <!-- Use a space to mean allow all privileges. See SENTRY-2424 -->
<property>
<name>sentry.db.explicit.grants.permitted</name>
- <value></value>
+ <value> </value>
</property>
<!-- Custom group mapping for custom cluster tests -->
<property>
http://git-wip-us.apache.org/repos/asf/impala/blob/1914a8b5/fe/src/test/resources/sentry-site_oo_nogrant.xml.template
----------------------------------------------------------------------
diff --git a/fe/src/test/resources/sentry-site_oo_nogrant.xml.template b/fe/src/test/resources/sentry-site_oo_nogrant.xml.template
index d984b69..7489bf6 100644
--- a/fe/src/test/resources/sentry-site_oo_nogrant.xml.template
+++ b/fe/src/test/resources/sentry-site_oo_nogrant.xml.template
@@ -91,10 +91,10 @@
<name>sentry.hive.testing.mode</name>
<value>true</value>
</property>
- <!-- Empty means allow all privileges -->
+ <!-- Use a space to mean allow all privileges. See SENTRY-2424 -->
<property>
<name>sentry.db.explicit.grants.permitted</name>
- <value></value>
+ <value> </value>
</property>
<!-- Custom group mapping for custom cluster tests -->
<property>