[GitHub] [arrow] zagto commented on a change in pull request #12669: ARROW-15974: Migrate flight/types.h header definitions to use Result<>

[GitBox <gi...@apache.org>]

zagto commented on a change in pull request #12669:
URL: https://github.com/apache/arrow/pull/12669#discussion_r831035563



##########
File path: cpp/src/arrow/flight/types.cc
##########
@@ -337,23 +366,40 @@ bool ActionType::Equals(const ActionType& other) const {
   return type == other.type && description == other.description;
 }
 
-Status MetadataRecordBatchReader::ReadAll(
-    std::vector<std::shared_ptr<RecordBatch>>* batches) {
-  FlightStreamChunk chunk;
+Status ResultStream::Next(std::unique_ptr<Result>* info) {
+  return Next().Value(info);
+}
+
+Status MetadataRecordBatchReader::Next(FlightStreamChunk* next) {
+  ARROW_ASSIGN_OR_RAISE(*next, Next());
+  return Status::OK();

Review comment:
       you're right




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org