[GitHub] [ozone] GlenGeng commented on pull request #2190: HDDS-5153. Decommissioning a dead node should complete immediately

[GitBox <gi...@apache.org>]

GlenGeng commented on pull request #2190:
URL: https://github.com/apache/ozone/pull/2190#issuecomment-828115989


   Hey @sodonnel. I have one concern. Can the check `checkContainersReplicatedOnNode`  be safely ignored for a dead node ? Will there be corner cases ?
   
   ```
           if (status.isDecommissioning() || status.isEnteringMaintenance()) {
             if (checkPipelinesClosedOnNode(dn)
                 // Ensure the DN has received and persisted the current maint
                 // state.
                 && status.getOperationalState()
                     == dn.getPersistedOpState()
                 && checkContainersReplicatedOnNode(dn)) {
   ``` 
   
   Another choice is, we can ignore the check 
   ```
                 && status.getOperationalState()
                     == dn.getPersistedOpState()
   ```
   for a dead node, since its persisted state can not be changed any more, which will make a dead node stuck in the queue. But we still reserve the check for replicas in that dead node. What do you think ?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org